From: Rob Herring <robh@kernel.org>
To: h00249924 <hutenghui@huawei.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Youlin Wang <wwx575822@notesmail.huawei.com>,
hanxiaolong3@hisilicon.com, suzhuangluan@hisilicon.com,
hantanglei@huawei.com, linux-kernel@vger.kernel.org,
Wei Xu <xuwei5@hisilicon.com>,
kongfei@hisilicon.com, ninggaoyu@hisilicon.com,
John Stultz <john.stultz@linaro.org>,
liyuequan@hisilicon.com, dmaengine@vger.kernel.org,
huangli295@hisilicon.com, wangyoulin1@hisilicon.com,
linux-arm-kernel@lists.infradead.org, cash.qianli@hisilicon.com
Subject: Re: [PATCH 3/3] arm64: dts: hi3660: Add hisi asp dma device
Date: Thu, 3 Jan 2019 20:44:49 -0600 [thread overview]
Message-ID: <20190104024449.GB17431@bogus> (raw)
In-Reply-To: <1545978983-124360-3-git-send-email-hutenghui@huawei.com>
On Fri, Dec 28, 2018 at 02:36:23PM +0800, h00249924 wrote:
> From: Youlin Wang <wwx575822@notesmail.huawei.com>
>
> Signed-off-by: John Stultz <john.stultz@linaro.org>
> Signed-off-by: Youlin Wang <wwx575822@notesmail.huawei.com>
> Signed-off-by: Tanglei Han <hantanglei@huawei.com>
> Cc: Wei Xu <xuwei5@hisilicon.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> ---
> arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> index f432b0a..5223e36 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> @@ -1122,5 +1122,19 @@
> };
> };
> };
> +
> + asp_dmac: asp_dmac@E804B000 {
dma-controller@e804b000
> + compatible = "hisilicon,hisi-pcm-asp-dma-1.0";
> + reg = <0x0 0xe804b000 0x0 0x1000>;
> + #dma-cells = <1>;
> + dma-channels = <16>;
> + dma-requests = <32>;
> + dma-min-chan = <0>;
> + dma-used-chans = <0xFFFE>;
Use lowercase hex.
But more importantly, as John mentioned, this and other properties
aren't documented.
> + dma-share;
> + interrupts = <0 216 4>;
> + interrupt-names = "asp_dma_irq";
> + status = "ok";
Don't need this.
> + };
> };
> };
> --
> 1.9.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-04 2:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-28 6:36 [PATCH 1/3] k3dma: Upgrade k3dma drever to support hisi_asp_dma hardware h00249924
2018-12-28 6:36 ` [PATCH 2/3] dmaengine: Extend the k3dma driver binding h00249924
2019-01-02 18:00 ` John Stultz
2019-01-03 23:21 ` Rob Herring
2018-12-28 6:36 ` [PATCH 3/3] arm64: dts: hi3660: Add hisi asp dma device h00249924
2019-01-04 2:44 ` Rob Herring [this message]
2019-01-04 17:24 ` [PATCH 1/3] k3dma: Upgrade k3dma drever to support hisi_asp_dma hardware Vinod Koul
2019-01-04 17:32 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190104024449.GB17431@bogus \
--to=robh@kernel.org \
--cc=cash.qianli@hisilicon.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=hantanglei@huawei.com \
--cc=hanxiaolong3@hisilicon.com \
--cc=huangli295@hisilicon.com \
--cc=hutenghui@huawei.com \
--cc=john.stultz@linaro.org \
--cc=kongfei@hisilicon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liyuequan@hisilicon.com \
--cc=mark.rutland@arm.com \
--cc=ninggaoyu@hisilicon.com \
--cc=suzhuangluan@hisilicon.com \
--cc=wangyoulin1@hisilicon.com \
--cc=wwx575822@notesmail.huawei.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).