Re: [PATCH] cpufreq: scmi: Fix frequency invariance in slow path

Sudeep Holla
2019-01-09T11:00:03Z

On Wed, Jan 09, 2019 at 10:42:36AM +0000, Quentin Perret wrote:
> The scmi-cpufreq driver calls the arch_set_freq_scale() callback on
> frequency changes to provide scale-invariant load-tracking signals to
> the scheduler. However, in the slow path, it does so while specifying
> the current and max frequencies in different units, hence resulting in a
> broken freq_scale factor.
>
> Fix this by passing all frequencies in KHz, as stored in the CPUFreq
> frequency table.
>
> Fixes: 99d6bdf33877 ("cpufreq: add support for CPU DVFS based on SCMI
> message protocol")

Good find.

Acked-by: Sudeep Holla <sudeep.holla@arm.com>

--
Regards,
Sudeep