From: Viresh Kumar <viresh.kumar@linaro.org>
To: Quentin Perret <quentin.perret@arm.com>
Cc: linux-pm@vger.kernel.org, rjw@rjwysocki.net,
linux-kernel@vger.kernel.org, qais.yousef@arm.com,
sudeep.holla@arm.com, dietmar.eggemann@arm.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] cpufreq: scmi: Fix frequency invariance in slow path
Date: Wed, 9 Jan 2019 16:15:11 +0530 [thread overview]
Message-ID: <20190109104511.mi3gtdcytkky4eyn@vireshk-i7> (raw)
In-Reply-To: <20190109104236.6532-1-quentin.perret@arm.com>
On 09-01-19, 10:42, Quentin Perret wrote:
> The scmi-cpufreq driver calls the arch_set_freq_scale() callback on
> frequency changes to provide scale-invariant load-tracking signals to
> the scheduler. However, in the slow path, it does so while specifying
> the current and max frequencies in different units, hence resulting in a
> broken freq_scale factor.
>
> Fix this by passing all frequencies in KHz, as stored in the CPUFreq
> frequency table.
>
> Fixes: 99d6bdf33877 ("cpufreq: add support for CPU DVFS based on SCMI
> message protocol")
> Signed-off-by: Quentin Perret <quentin.perret@arm.com>
> ---
> drivers/cpufreq/scmi-cpufreq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c
> index 50b1551ba894..3f0693439486 100644
> --- a/drivers/cpufreq/scmi-cpufreq.c
> +++ b/drivers/cpufreq/scmi-cpufreq.c
> @@ -52,9 +52,9 @@ scmi_cpufreq_set_target(struct cpufreq_policy *policy, unsigned int index)
> int ret;
> struct scmi_data *priv = policy->driver_data;
> struct scmi_perf_ops *perf_ops = handle->perf_ops;
> - u64 freq = policy->freq_table[index].frequency * 1000;
> + u64 freq = policy->freq_table[index].frequency;
>
> - ret = perf_ops->freq_set(handle, priv->domain_id, freq, false);
> + ret = perf_ops->freq_set(handle, priv->domain_id, freq * 1000, false);
> if (!ret)
> arch_set_freq_scale(policy->related_cpus, freq,
> policy->cpuinfo.max_freq);
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-09 10:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 10:42 [PATCH] cpufreq: scmi: Fix frequency invariance in slow path Quentin Perret
2019-01-09 10:45 ` Viresh Kumar [this message]
2019-01-09 10:56 ` Rafael J. Wysocki
2019-01-09 10:59 ` Quentin Perret
2019-01-09 11:03 ` Rafael J. Wysocki
2019-01-09 11:07 ` Quentin Perret
2019-01-09 10:59 ` Viresh Kumar
2019-01-09 10:59 ` Sudeep Holla
2019-01-11 10:41 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109104511.mi3gtdcytkky4eyn@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=qais.yousef@arm.com \
--cc=quentin.perret@arm.com \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox