From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA4BBC43387 for ; Wed, 9 Jan 2019 11:00:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B96882063F for ; Wed, 9 Jan 2019 11:00:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BuxRM5zy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B96882063F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=L20vUS4zOebbW1SFhLAT/kKXb7hfuRQuH7/XvUnip88=; b=BuxRM5zyNqkqgA hMEqwbliYpOr3BflcqQcYWSCAjWLnKFoqBYYuZP1LznPHD6wGE1CSv7E2TH2OPMazXb3A1Whc3T6s Av+Qx3jVOQg3et30/hfuhkbdH63weQehKPy2ZeOsTFBfp4gB1hCd6w56UUeBAu708GL37Y6vyFKyU iSYNLvf0YasuajThxAT3TWRr4r53flHlDRkQ0OqCkx0HvJm7KfvWHqYHQL0e4Ly4jQ6TXlrF+NUMy ZMKASz8H6x7ayKfVa9jTdFfYFRdRJmKkxReJZwDbl5YCCu5jwel0cQ4a+z0wVrUw45KQA7vZ9VP73 ximkYUsMBjb4CdFf8PGw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ghBaZ-0002GP-P5; Wed, 09 Jan 2019 10:59:59 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ghBaW-0002DT-2E for linux-arm-kernel@lists.infradead.org; Wed, 09 Jan 2019 10:59:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F358CA78; Wed, 9 Jan 2019 02:59:53 -0800 (PST) Received: from e107155-lin (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 77D353F70D; Wed, 9 Jan 2019 02:59:52 -0800 (PST) Date: Wed, 9 Jan 2019 10:59:45 +0000 From: Sudeep Holla To: Quentin Perret Subject: Re: [PATCH] cpufreq: scmi: Fix frequency invariance in slow path Message-ID: <20190109105945.GA18034@e107155-lin> References: <20190109104236.6532-1-quentin.perret@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190109104236.6532-1-quentin.perret@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190109_025956_161617_78CBCA79 X-CRM114-Status: GOOD ( 10.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, viresh.kumar@linaro.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, qais.yousef@arm.com, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 09, 2019 at 10:42:36AM +0000, Quentin Perret wrote: > The scmi-cpufreq driver calls the arch_set_freq_scale() callback on > frequency changes to provide scale-invariant load-tracking signals to > the scheduler. However, in the slow path, it does so while specifying > the current and max frequencies in different units, hence resulting in a > broken freq_scale factor. > > Fix this by passing all frequencies in KHz, as stored in the CPUFreq > frequency table. > > Fixes: 99d6bdf33877 ("cpufreq: add support for CPU DVFS based on SCMI > message protocol") Good find. Acked-by: Sudeep Holla -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel