From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 181BAC43387 for ; Wed, 9 Jan 2019 14:56:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D6C41206BB for ; Wed, 9 Jan 2019 14:56:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ose1pRem" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D6C41206BB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:References:In-Reply-To:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8qiNaRyebifJjsDdZI8gmMu7sNhAnKAEUDmzhyGDyGM=; b=Ose1pRemqz0ON3hSh5xGgqSeN eYKfFXYqrUJbTsL5hCcQbS9JQBm99YdIqP5tVgGNjougdzG5nTR3Fsk8YZ1D8uPTR1tfGolLxN41v nFv6Fm5NTB7/HWv8EZ2Ae7ngJ6EhICZGLPB23svmW/byoi9Vyqo4y1du/aTPIbJHUSG2YXLbLFNJv TIZH3wYlvI5YXpJCKuznP3mo+x/fddOp7VhIUQGkHLUPQYYYQaVX21UfE2Vax3lFDQHcBbRfTOqEn XlnAQMJf4M8q/KLqDNmbQAPO8OUBJfs9uk1EX9AbCk0zFL0IFQZ/wxXiBqEtcgFvbCuJC+a88ttot CbiLjt6sQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ghFHl-0007Su-6V; Wed, 09 Jan 2019 14:56:49 +0000 Received: from mail-out.m-online.net ([212.18.0.10]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ghFHg-0007SO-Lk; Wed, 09 Jan 2019 14:56:47 +0000 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 43ZXJm4gXsz1qxJt; Wed, 9 Jan 2019 15:56:40 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 43ZXJm3BYVz1qsnX; Wed, 9 Jan 2019 15:56:40 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 7sIPBn9zPRHf; Wed, 9 Jan 2019 15:56:37 +0100 (CET) X-Auth-Info: bhdoaYGhXoKse58XiQTPGzwcJ1Q1gpbVktPB3rBiP4E= Received: from jawa (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 9 Jan 2019 15:56:37 +0100 (CET) Date: Wed, 9 Jan 2019 15:56:30 +0100 From: Lukasz Majewski To: Schrempf Frieder Subject: Re: [PATCH v6 0/5] spi: spi-mem: Add driver for NXP FlexSPI controller Message-ID: <20190109155630.3ec34c60@jawa> In-Reply-To: <7188c406-3dd2-88a6-b6ed-d5e8bf678df8@kontron.de> References: <1546939346-20181-1-git-send-email-yogeshnarayan.gaur@nxp.com> <7188c406-3dd2-88a6-b6ed-d5e8bf678df8@kontron.de> Organization: denx.de X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190109_065645_013202_87E2B202 X-CRM114-Status: GOOD ( 23.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , Yogesh Narayan Gaur , "marek.vasut@gmail.com" , "linux-kernel@vger.kernel.org" , "linux-spi@vger.kernel.org" , "boris.brezillon@bootlin.com" , "broonie@kernel.org" , "linux-mtd@lists.infradead.org" , "computersforpeace@gmail.com" , "shawnguo@kernel.org" , "robh@kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: multipart/mixed; boundary="===============2911506917049022009==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2911506917049022009== Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/qfV7IP6UbfJ_zClhLB+efu+"; protocol="application/pgp-signature" --Sig_/qfV7IP6UbfJ_zClhLB+efu+ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Schrempf, > On 08.01.19 10:24, Yogesh Narayan Gaur wrote: > > - Add driver for NXP FlexSPI host controller > >=20 > > FlexSPI is a flexsible SPI host controller [1], Chapter 30 page > > 1475, which supports two SPI channels and up to 4 external devices. > > Each channel supports Single/Dual/Quad/Octal mode data transfer > > (1/2/4/8 bidirectional data lines) i.e. FlexSPI acts as an > > interface to external devices, maximum 4, each with up to 8 > > bidirectional data lines. > >=20 > > - Tested this driver with mtd_debug(Erase/Write/Read) utility and > > JFFS2 filesystem mounting and booting on NXP LX2160ARDB[2] and > > LX2160AQDS targets. LX2160ARDB is having two NOR slave device > > connected on single bus A i.e. A0 and A1 (CS0 and CS1). > > LX2160AQDS is having two NOR slave device connected on separate > > buses one flash on A0 and second on B1 i.e. (CS0 and CS3). > > Verified this driver on following SPI NOR flashes: > > Micron, mt35xu512aba, [Read - 1 bit mode] > > Cypress, s25fl512s, [Read - 1/2/4 bit mode] > >=20 > > [1] https://www.nxp.com/docs/en/reference-manual/IMXRT1050RM.pdf > > [2] > > https://patchwork.kernel.org/project/linux-arm-kernel/list/?submitter= =3D182097 > >=20 > > Yogesh Narayan Gaur (5): > > spi: spi-mem: Add driver for NXP FlexSPI controller > > dt-bindings: spi: add binding file for NXP FlexSPI controller > > arm64: dts: lx2160a: add FlexSPI node property > > arm64: defconfig: enable NXP FlexSPI driver > > MAINTAINERS: add maintainers for the NXP FlexSPI driver > >=20 > > Changes for v6: > > - Rebase on top of v5.0-rc1. =20 >=20 > Your patches don't apply to v5.0-rc1. It seems like you have instead=20 > rebased onto the for-5.1 or for-next branch of the SPI tree. I guess=20 > this is okay, but you should have pointed that out correctly here. If I may ask for a few (1-2) days, so I can test this code on vf610 NXP SoC. As fair as I remember there were some issues when I tested it a few months back. >=20 > > - Incorporated review comments for > > patch 'spi: spi-mem: Add driver for NXP FlexSPI controller'. > > - Updated s-b tag in all patches. > > Changes for v5: > > - Rebase on top of v4.20-rc2 > > - Incorporated review comments for > > patch 'spi: spi-mem: Add driver for NXP FlexSPI controller'. > > Changes for v4: > > - Incorporated review comments for > > patch 'spi: spi-mem: Add driver for NXP FlexSPI controller'. > > - Incorporated binding file review comments. > > Changes for v3: > > - Incorporated review comments for > > patch 'spi: spi-mem: Add driver for NXP FlexSPI controller'. > > Changes for v2: > > - Incorporated Boris review comments and drop below patches as per > > the comments. > > - Patch 'spi: add slave device size in spi_device struct' > > - Patch 'spi: add flags for octal I/O data transfer' > > - Incorporated DTS and Binding file review comments of Shawn Guo > > and Rob Herring. > >=20 > > .../devicetree/bindings/spi/spi-nxp-fspi.txt | 39 + > > MAINTAINERS | 7 + > > .../boot/dts/freescale/fsl-lx2160a-rdb.dts | 22 + > > .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 13 + > > arch/arm64/configs/defconfig | 1 + > > drivers/spi/Kconfig | 10 + > > drivers/spi/Makefile | 1 + > > drivers/spi/spi-nxp-fspi.c | 1095 > > +++++++++++++++++ 8 files changed, 1188 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt create mode > > 100644 drivers/spi/spi-nxp-fspi.c=20 > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/ Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/qfV7IP6UbfJ_zClhLB+efu+ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAlw2C54ACgkQAR8vZIA0 zr0Bygf8CIJkJt1rC2YiQntRmvFJk7rlDUHSGzV+pRjNWOGCzkv9Q8wBs7GUjXeC XcOe+RXQgzwhAH3ByyxMBmtdC55PqceJDb30NQyExXCVhMpuqdmU2G0R7l9g6H8D odGNDv6IC47oMzaq8zT6dC2f1iddFpfuQ4qvyDjBmEpyqTKPFFSH8KNTRa6Kjoph Opg8/CjSvxaPQMtBQkl0MqKI5lr9iSAMPrL6Gk3FnU0hqMtEZmgbBflieJoIZo77 5mvs1nWSWAs8yEvVqH1VN9HqBLvZSi8RvMgCzvQB4kt/gh3ehGPN9hLbELeMDp24 xasMUxYP8WrDjPZtm5kwEWX9gcvbxQ== =S3Bd -----END PGP SIGNATURE----- --Sig_/qfV7IP6UbfJ_zClhLB+efu+-- --===============2911506917049022009== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2911506917049022009==--