From: Kalle Valo <kvalo@codeaurora.org>
To: Zumeng Chen <zumeng.chen@gmail.com>
Cc: tony@atomide.com, Zumeng Chen <zumeng.chen@gmail.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] wlcore: Fix memory leak in case wl12xx_fetch_firmware failure
Date: Thu, 10 Jan 2019 11:32:10 +0000 (UTC) [thread overview]
Message-ID: <20190110113210.28E7C608A5@smtp.codeaurora.org> (raw)
In-Reply-To: <1545205829-31979-1-git-send-email-zumeng.chen@gmail.com>
Zumeng Chen <zumeng.chen@gmail.com> wrote:
> Release fw_status, raw_fw_status, and tx_res_if when wl12xx_fetch_firmware
> failed instead of meaningless goto out to avoid the following memory leak
> reports(Only the last one listed):
>
> unreferenced object 0xc28a9a00 (size 512):
> comm "kworker/0:4", pid 31298, jiffies 2783204 (age 203.290s)
> hex dump (first 32 bytes):
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> backtrace:
> [<6624adab>] kmemleak_alloc+0x40/0x74
> [<500ddb31>] kmem_cache_alloc_trace+0x1ac/0x270
> [<db4d731d>] wl12xx_chip_wakeup+0xc4/0x1fc [wlcore]
> [<76c5db53>] wl1271_op_add_interface+0x4a4/0x8f4 [wlcore]
> [<cbf30777>] drv_add_interface+0xa4/0x1a0 [mac80211]
> [<65bac325>] ieee80211_reconfig+0x9c0/0x1644 [mac80211]
> [<2817c80e>] ieee80211_restart_work+0x90/0xc8 [mac80211]
> [<7e1d425a>] process_one_work+0x284/0x42c
> [<55f9432e>] worker_thread+0x2fc/0x48c
> [<abb582c6>] kthread+0x148/0x160
> [<63144b13>] ret_from_fork+0x14/0x2c
> [< (null)>] (null)
> [<1f6e7715>] 0xffffffff
>
> Signed-off-by: Zumeng Chen <zumeng.chen@gmail.com>
Patch applied to wireless-drivers-next.git, thanks.
ba2ffc96321c wlcore: Fix memory leak in case wl12xx_fetch_firmware failure
--
https://patchwork.kernel.org/patch/10736825/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-01-10 11:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 7:50 [PATCH 1/1] wlcore: Fix memory leak in case wl12xx_fetch_firmware failure Zumeng Chen
2019-01-10 11:32 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110113210.28E7C608A5@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tony@atomide.com \
--cc=zumeng.chen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).