Re: [PATCH v2] ARM: dts: imx: Add Y Soft IOTA Draco, Hydra and Ursa boards

Vokáč Michal
2019-01-08T11:41:09Z

On 28.12.2018 19:20, Fabio Estevam wrote:
> On Tue, Dec 18, 2018 at 12:42 PM Vokáč Michal <Michal.Vokac@ysoft.com> wrote:
>
>> +&fec {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_enet>;
>> + phy-mode = "rgmii-id";
>> + phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_HIGH>;
>
> Are you sure this is active high?
>
> The FEC driver ignores the polarity of phy-reset-gpios and it assumes
> the GPIO reset as active low.
>
> If it really is active high, then you would need to pass the
> "phy-reset-active-high" property.

Good catch! Originally it was phy-reset-gpios = <&gpio1 25 0> which is
active high as well. And as you say, the polarity is ignored. Later on
I decided to change all the GPIO specifiers to use defines instead of
numbers. I just swapped 0 for GPIO_ACTIVE_HIGH without using brain cells.

I will use GPIO_ACTIVE_LOW there to be correct even though it is ignored.

>> +/ {
>> + model = "Y Soft IOTA Draco i.MX6Solo board";
>> + compatible = "ysoft,imx6dl-yapp4-draco", "fsl,imx6dl";
>> +
>> + cpus {
>> + /delete-node/ cpu@1;
>
> Is this really needed? We don't usually do this on imx6solo dts board files.
>
> Only one CPU will be brought up online on imx6solo anyway.

OK, it is really not necessary. I will remove it.

>> + };
>> +
>> + memory@10000000 {
>
> Need to pass "device_type = "memory";"

OK.

>> +/ {
>> + model = "Y Soft IOTA Hydra i.MX6DualLite board";
>> + compatible = "ysoft,imx6dl-yapp4-hydra", "fsl,imx6dl";
>> +
>> + memory@10000000 {
>
> Need to pass "device_type = "memory";"

OK.

>> + memory@10000000 {
>
> Need to pass "device_type = "memory";"

OK.

Thank you for the review Fabio.
All the best,