From: Shawn Guo <shawnguo@kernel.org>
To: Aisheng Dong <aisheng.dong@nxp.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"dongas86@gmail.com" <dongas86@gmail.com>,
"khilman@kernel.org" <khilman@kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
Rob Herring <robh+dt@kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/3] dt-bindings: fsl: scu: add fallback compatible string for power domain
Date: Fri, 11 Jan 2019 17:00:11 +0800 [thread overview]
Message-ID: <20190111090009.GG32649@dragon> (raw)
In-Reply-To: <1545148524-658-2-git-send-email-aisheng.dong@nxp.com>
On Tue, Dec 18, 2018 at 04:01:20PM +0000, Aisheng Dong wrote:
> SCU power domain can be used in the same way by IMX8QXP and IMX8QM SoCs.
> Let's add a "fsl,scu-pd" fallback compatible string to allow other SoCs
> to reuse the common part.
This is not the practice we used to match devices with compatibilities,
i.e. coding the compatible string with the SoC name that firstly
introduces the device, and use the compatible as fallback for new SoCs.
Shawn
>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
> Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> index c20f38e..849b671 100644
> --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> @@ -58,7 +58,10 @@ This binding for the SCU power domain providers uses the generic power
> domain binding[2].
>
> Required properties:
> -- compatible: Should be "fsl,imx8qxp-scu-pd".
> +- compatible: Should be one of:
> + "fsl,imx8qxp-scu-pd"
> + followed by "fsl,scu-pd"
> +
> - #power-domain-cells: Must be 1. Contains the Resource ID used by
> SCU commands.
> See detailed Resource ID list from:
> @@ -145,7 +148,7 @@ firmware {
> };
>
> pd: imx8qx-pd {
> - compatible = "fsl,imx8qxp-scu-pd";
> + compatible = "fsl,imx8qxp-scu-pd", "fsl,scu-pd";
> #power-domain-cells = <1>;
> };
> };
> --
> 2.7.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-11 9:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 16:01 [PATCH 0/3] firmware: imx: scu-pd: add fallback compatible string support Aisheng Dong
2018-12-18 16:01 ` [PATCH 1/3] dt-bindings: fsl: scu: add fallback compatible string for power domain Aisheng Dong
2018-12-28 23:28 ` Rob Herring
2019-01-11 9:00 ` Shawn Guo [this message]
2019-01-11 9:06 ` Shawn Guo
2019-01-11 10:48 ` Aisheng Dong
2019-01-11 13:03 ` Shawn Guo
2019-01-11 15:24 ` Aisheng Dong
2019-01-21 16:31 ` Rob Herring
2018-12-18 16:01 ` [PATCH 2/3] dt-bindings: fsl: scu: add imx8qm scu power domain support Aisheng Dong
2018-12-28 23:28 ` Rob Herring
2018-12-18 16:01 ` [PATCH 3/3] firmware: imx: scu-pd: add fallback compatible string support Aisheng Dong
2019-01-12 1:39 ` Shawn Guo
2018-12-28 2:38 ` [PATCH 0/3] " Aisheng Dong
2018-12-28 13:24 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190111090009.GG32649@dragon \
--to=shawnguo@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=dongas86@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).