From: Shawn Guo <shawnguo@kernel.org>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/4] ARM: dts: imx6qdl-phytec-pfla02: Add some labels
Date: Sat, 12 Jan 2019 11:21:57 +0800 [thread overview]
Message-ID: <20190112032156.GA11426@dragon> (raw)
In-Reply-To: <20181223163141.6792-4-shc_work@mail.ru>
On Sun, Dec 23, 2018 at 07:31:41PM +0300, Alexander Shiyan wrote:
> This patch adds labels to devices that can be reused in top-level dts.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> index 81007d6..a685ff7 100644
> --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> @@ -41,12 +41,12 @@
> gpio_leds: leds {
> compatible = "gpio-leds";
>
> - green {
> + led_green: led_green {
We usually use hyphen than underscore in node name, so led-green for
node please.
> label = "phyflex:green";
> gpios = <&gpio1 30 GPIO_ACTIVE_HIGH>;
> };
>
> - red {
> + led_red: led_red {
Ditto
> label = "phyflex:red";
> gpios = <&gpio2 31 GPIO_ACTIVE_HIGH>;
> };
> @@ -71,7 +71,7 @@
> status = "okay";
> cs-gpios = <&gpio4 24 GPIO_ACTIVE_LOW>;
>
> - flash@0 {
> + flash: flash@0 {
Please use a specific name for labelling, for example:
m25p80: flash@0 {
> compatible = "m25p80", "jedec,spi-nor";
> spi-max-frequency = <20000000>;
> reg = <0>;
> @@ -99,12 +99,12 @@
> pinctrl-0 = <&pinctrl_i2c1>;
> status = "okay";
>
> - eeprom@50 {
> + eeprom: eeprom@50 {
Ditto
> compatible = "atmel,24c32";
> reg = <0x50>;
> };
>
> - pmic@58 {
> + pmic: pmic@58 {
Ditto
Shawn
> compatible = "dlg,da9063";
> reg = <0x58>;
> interrupt-parent = <&gpio2>;
> --
> 2.10.2
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-01-12 3:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-23 16:31 [PATCH 1/4] ARM: dts: imx6q-phytec-pbab01: Remove duplicate "chosen" node Alexander Shiyan
2018-12-23 16:31 ` [PATCH 2/4] ARM: dts: imx6q/dl-phytec-pfla02: Remove duplicate nodes Alexander Shiyan
2018-12-23 16:31 ` [PATCH 3/4] ARM: dts: imx6qdl-phytec-pfla02: Replace magic numbers Alexander Shiyan
2019-01-12 3:13 ` Shawn Guo
2018-12-23 16:31 ` [PATCH 4/4] ARM: dts: imx6qdl-phytec-pfla02: Add some labels Alexander Shiyan
2019-01-12 3:21 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190112032156.GA11426@dragon \
--to=shawnguo@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).