From: "Guido Günther" <agx@sigxcpu.org>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Sascha Hauer <s.hauer@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: imx8mq: Add pwm
Date: Mon, 14 Jan 2019 18:02:18 +0100 [thread overview]
Message-ID: <20190114170218.GA4168@bogon.m.sigxcpu.org> (raw)
In-Reply-To: <1547484331.2718.8.camel@pengutronix.de>
Hi,
On Mon, Jan 14, 2019 at 05:45:31PM +0100, Lucas Stach wrote:
> Hi Guido,
>
> Am Montag, den 14.01.2019, 17:30 +0100 schrieb Guido Günther:
> > We can reuse the pwm from fsl,imx27-pwm as with other imx SOCs.
> >
> > > Signed-off-by: Guido Günther <agx@sigxcpu.org>
> > ---
> > This is against linux-next (next-20190114)
> >
> > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 44 +++++++++++++++++++++++
> > 1 file changed, 44 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > index 8e9d6d5ed7b2..53ed0bdfc06a 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > @@ -252,6 +252,50 @@
> > > clocks = <&clk IMX8MQ_CLK_WDOG3_ROOT>;
> > > status = "disabled";
> > > };
> > +
> > > > + pwm1: pwm@30660000 {
> > > + compatible = "fsl,imx8mq-pwm", "fsl,imx27-pwm";
> > > + reg = <0x30660000 0x10000>;
> > > + interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
> > > + clocks = <&clk IMX8MQ_CLK_PWM1_ROOT>,
> > + <&clk IMX8MQ_CLK_PWM1_ROOT>;
>
> Please align the second entry with the first one,as with all the other
> nodes in this file.
Emacs mode fighting with me. I'll send a v2 with that fixed and moved to
the AIPS2 bus.
Thanks,
-- Guido
>
> > + clock-names = "ipg", "per";
> > > + #pwm-cells = <2>;
> > > + status = "disabled";
> > > + };
> > +
> > > > + pwm2: pwm@30670000 {
> > > + compatible = "fsl,imx8mq-pwm", "fsl,imx27-pwm";
> > > + reg = <0x30670000 0x10000>;
> > > + interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>;
> > > + clocks = <&clk IMX8MQ_CLK_PWM2_ROOT>,
> > > + <&clk IMX8MQ_CLK_PWM2_ROOT>;
> > > + clock-names = "ipg", "per";
> > > + #pwm-cells = <2>;
> > > + status = "disabled";
> > > + };
> > +
> > > > + pwm3: pwm@30680000 {
> > > + compatible = "fsl,imx8mq-pwm", "fsl,imx27-pwm";
> > > + reg = <0x30680000 0x10000>;
> > > + interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
> > > + clocks = <&clk IMX8MQ_CLK_PWM3_ROOT>,
> > > + <&clk IMX8MQ_CLK_PWM3_ROOT>;
> > > + clock-names = "ipg", "per";
> > > + #pwm-cells = <2>;
> > > + status = "disabled";
> > > + };
> > +
> > > > + pwm4: pwm@30690000 {
> > > + compatible = "fsl,imx8mq-pwm", "fsl,imx27-pwm";
> > > + reg = <0x30690000 0x10000>;
> > > + interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>;
> > > + clocks = <&clk IMX8MQ_CLK_PWM4_ROOT>,
> > > + <&clk IMX8MQ_CLK_PWM4_ROOT>;
> > > + clock-names = "ipg", "per";
> > > + #pwm-cells = <2>;
> > > + status = "disabled";
> > + };
>
> All those addresses are within the AIPS2 bus range, so this patch adds
> them to the wrong bus.
>
> Regards,
> Lucas
>
> > };
> >
> > > bus@30400000 { /* AIPS2 */
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-01-14 17:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 16:30 [PATCH] arm64: dts: imx8mq: Add pwm Guido Günther
2019-01-14 16:45 ` Lucas Stach
2019-01-14 17:02 ` Guido Günther [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114170218.GA4168@bogon.m.sigxcpu.org \
--to=agx@sigxcpu.org \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox