From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24355C43444 for ; Tue, 15 Jan 2019 05:50:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E153420656 for ; Tue, 15 Jan 2019 05:50:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NcxonpO3"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="YD/aV1bY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E153420656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Message-Id:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PPIBa7UP1nkQFs10osMNAXu/Rs59GVL704aubta0U7A=; b=NcxonpO3gAojFn wrYsboJwd5xmPis2A7CguUgeizo2LmJjwlsLivFssWSTeX7lHnZY/p4VNWd9xRVb85M1/H8yeo0b9 qzpqIeHt0feeiS8172/eD6d/3RL3jNTcEoNUip9ltPqhMBYd0z8buI5iHEHUBzdMSxHg+cPVFazKy Fw8bxO7Gbu1br2mb86XxolGyD6jqkaL/+VYW2OeinYmMnKGp+LIttjNGnaCewisDc1jeZQL5h2HwY f1Fqf2TtDpncpfq7n8hl3Z8CARWFvoSpo2UcHbfaGv4dEAC+XH18FE7kjNkKnBzbx1LgQzxeleLoT dnqZTYzWLD/2Z00YxmMg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gjHbu-0001DT-PC; Tue, 15 Jan 2019 05:50:02 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gjHbr-0001Cz-DG for linux-arm-kernel@lists.infradead.org; Tue, 15 Jan 2019 05:50:00 +0000 Received: from devnote (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9678B20656; Tue, 15 Jan 2019 05:49:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547531398; bh=OsNbKiOw4wC2BGgc0y+q1WmevhGN5MS5HBVUsKEr3Ao=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YD/aV1bYlT9JBqyuX7FQozAs4TTkv/t4gLaNQr6DdeJLSC/50wtmS2upU9/fBZCaL gPyViv5g/QDVmYvtA9NvI0QNxfAnOEvk85lRPaMEZ4ewCCA03LMADru3uT7/OjNX/m 26UlNHYNoeafYBNg5lDIPwEQtDg5hXKQ1u6Bc8jE= Date: Tue, 15 Jan 2019 14:49:55 +0900 From: Masami Hiramatsu To: James Morse Subject: Re: [PATCH 1/3] arm64: kprobes: Move extable address check into arch_prepare_kprobe() Message-Id: <20190115144955.b3a6cfae18035ae46ffdcfc2@kernel.org> In-Reply-To: <92c160a8-7627-0c64-ed73-df616e9c057d@arm.com> References: <154502881646.30629.9938335052821665530.stgit@devbox> <154502884653.30629.3172839440883293817.stgit@devbox> <20190108113953.8bc0cc7d196ddba370377217@kernel.org> <20190109110500.b4b5049f4c67dfc85b9ced4e@kernel.org> <92c160a8-7627-0c64-ed73-df616e9c057d@arm.com> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190114_214959_484491_3DC7789E X-CRM114-Status: GOOD ( 19.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pratyush Anand , Catalin Marinas , Will Deacon , linux-kernel , "David A . Long" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 11 Jan 2019 18:22:38 +0000 James Morse wrote: > Hi, > > On 09/01/2019 02:05, Masami Hiramatsu wrote: > > On Tue, 8 Jan 2019 17:13:36 +0000 > > James Morse wrote: > >> On 08/01/2019 02:39, Masami Hiramatsu wrote: > >>> On Thu, 3 Jan 2019 17:05:18 +0000 > >>> James Morse wrote: > >>>> On 17/12/2018 06:40, Masami Hiramatsu wrote: > >>>>> Move extable address check into arch_prepare_kprobe() from > >>>>> arch_within_kprobe_blacklist(). > >>>> > >>>> I'm trying to work out the pattern for what should go in the blacklist, and what > >>>> should be rejected by the arch code. > >>>> > >>>> It seems address-ranges should be blacklisted as the contents don't matter. > >>>> easy-example: the idmap text. > >>> > >>> Yes, more precisely, the code smaller than a function (symbol), it must be > >>> rejected by arch_prepare_kprobe(), since blacklist is poplated based on > >>> kallsyms. > >> > >> Ah, okay, so the pattern is the blacklist should only be for whole symbols, > >> (which explains why its usually based on sections). > > > > Correct. Actually, the blacklist is generated based on the symbol info > > from symbol address. > > > >> I see kprobe_add_ksym_blacklist() would go wrong if you give it something like: > >> platform_drv_probe+0x50/0xb0, as it will log platform_drv_probe+0x50 as the > >> start_addr and platform_drv_probe+0x50+0xb0 as the end. > > > > Yes, it expects given address is the entry of a symbol. > > >> But how does anything from the arch code's blacklist get into the > >> kprobe_blacklist list? > > > > It should be done via arch_populate_kprobe_blacklist(). > > >> We don't have an arch_populate_kprobe_blacklist(), so rely on > >> within_kprobe_blacklist() calling arch_within_kprobe_blacklist() with the > >> address, as well as walking kprobe_blacklist. > >> > >> Is this cleanup ahead of a series that does away with > >> arch_within_kprobe_blacklist() so that debugfs list is always complete? > > > > Right, after this cleanup, I will send arch_populate_kprobe_blacklist() > > patch for arm64 and others. My plan is to move all arch_within_kprobe_blacklist() > > to arch_populate_kprobe_blacklist() so that user can get more precise blacklist > > via debugfs. > > Thanks, now it all makes sense! > > Reviewed-by: James Morse Thanks! > > > Could you include a paragraph like that in the cover-letter or commit-message? > The 'fix' in the cover-letter subject had me looking for the bug! Ok, I'll update commit message with your reviewed-by. Thank you! > > > Thanks, > > James -- Masami Hiramatsu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel