From: Wolfram Sang <wsa@the-dreams.de>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
linux-i2c@vger.kernel.org,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
linux-arm-kernel@lists.infradead.org,
NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [PATCH v5 1/2] i2c: imx: notify about real errors on dma i2c_imx_dma_request
Date: Tue, 15 Jan 2019 22:54:45 +0100 [thread overview]
Message-ID: <20190115215445.rjfio7i6sx62qfh5@ninjato> (raw)
In-Reply-To: <20190109055650.32259-2-o.rempel@pengutronix.de>
[-- Attachment #1.1: Type: text/plain, Size: 639 bytes --]
On Wed, Jan 09, 2019 at 06:56:49AM +0100, Oleksij Rempel wrote:
> At least on i.MX5x, the DMA events for I2C and SDHC use the same channel
> and there can only be a single user. So in this case there should be no
> message emitted that looks like an error if the I2C device doesn't have
> an assigned DMA channel. In contrast real problems that were only
> emitted at debug level before should be described at a higher level
> to be better visible and so understandable.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied to for-next, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-15 21:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 5:56 [PATCH v5 0/2] i2c: imx: rework imx error handling Oleksij Rempel
2019-01-09 5:56 ` [PATCH v5 1/2] i2c: imx: notify about real errors on dma i2c_imx_dma_request Oleksij Rempel
2019-01-15 21:54 ` Wolfram Sang [this message]
2019-01-09 5:56 ` [PATCH v5 2/2] i2c: imx: improve the error handling in i2c_imx_dma_request() Oleksij Rempel
2019-01-15 21:54 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190115215445.rjfio7i6sx62qfh5@ninjato \
--to=wsa@the-dreams.de \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=o.rempel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox