From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD592C43387 for ; Wed, 16 Jan 2019 02:06:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9EDA82082F for ; Wed, 16 Jan 2019 02:06:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Lc9B/epR"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="d2pwfKoD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9EDA82082F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5DFryfQ5pNdRe5qPJuzIZO/k8DMiC83wD65A5R5Y4nY=; b=Lc9B/epRBjtz+F fjPkKQqaivGWWPfRDAr9JmrBA9IssptsK+x7ZUo7l0VEV/+0/X/+H+jnHiEqAa7xH6OVwX7Gju59/ BMT40P4pjUYtKpmYoINcT4zZQSgspRDe9Iy/2iy+Rre4AqDuA/bAjqk9QRM+aUn5LNf12Dvn7z4eK 2nDe5eNvsE4d8NmFmJxZrkOFa6TUuFCGZboSXS6V+XuCCdsEoXJqIr7PXesuKAVHmLabMSmAiWGtF KhrA5C5wUprhFjWKFQrEzEUCfwYN4rEwd9aE6WAII1SvUc+VdYKWS8v7+5uahsjiN0brVSr1cvYo6 h2XLHAUnbXIJcnHNaiUg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gjaaq-0001Fc-LO; Wed, 16 Jan 2019 02:06:12 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gjaan-0001FB-3k for linux-arm-kernel@lists.infradead.org; Wed, 16 Jan 2019 02:06:10 +0000 Received: from dragon (61-216-91-114.HINET-IP.hinet.net [61.216.91.114]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7E7762082F; Wed, 16 Jan 2019 02:06:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547604368; bh=yL62E1MSsM+fjN8pSX8/J71nC2mdkCIoqBNx+bYjIIQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=d2pwfKoDt7uQ46J3tdNIoK2Ph7jh+QjAAG+Q6XGOpblPJ9xenyrcdVf05SRM+wjMG hXL6icef2cZcNxWvQklJXDvxmnaIIPTZES2n7xEcYNYYtpIPQN/2Pe12lag7akeesA W9fobg5HbzoW6o1mPfJPQmhpkvPlml1tlPwIYQ1A= Date: Wed, 16 Jan 2019 10:05:45 +0800 From: Shawn Guo To: Peng Ma Subject: Re: [v2] arm64: dts: lx2160a: add sata node support Message-ID: <20190116020543.GB15808@dragon> References: <20190114095500.1600-1-peng.ma@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190114095500.1600-1-peng.ma@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190115_180609_201970_76593661 X-CRM114-Status: GOOD ( 16.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, leoyang.li@nxp.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 14, 2019 at 09:55:00AM +0000, Peng Ma wrote: > Add sata node support and Enable sata support I would suggest you reword the commit log like below: Add SATA device nodes for fsl-lx2160a and enable support for QDS and RDB boards. > > Signed-off-by: Peng Ma > --- > changed for V2: > - put the 'status' at the end of property list > - add lx2160aqds sata support > > arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts | 16 +++++++ > arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 16 +++++++ > arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 44 +++++++++++++++++++++ > 3 files changed, 76 insertions(+), 0 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts > index 99a22ab..0289955 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts > @@ -110,3 +110,19 @@ > &usb1 { > status = "okay"; > }; > + > +&sata0 { Please sort the labeling nodes alphabetically. Shawn > + status = "okay"; > +}; > + > +&sata1 { > + status = "okay"; > +}; > + > +&sata2 { > + status = "okay"; > +}; > + > +&sata3 { > + status = "okay"; > +}; > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts > index 6481e5f..aacca27 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts > @@ -117,3 +117,19 @@ > &usb1 { > status = "okay"; > }; > + > +&sata0 { > + status = "okay"; > +}; > + > +&sata1 { > + status = "okay"; > +}; > + > +&sata2 { > + status = "okay"; > +}; > + > +&sata3 { > + status = "okay"; > +}; > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > index a79f5c1..4390aea 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > @@ -762,5 +762,49 @@ > ; > dma-coherent; > }; > + > + sata0: sata@3200000 { Please sort nodes with unit-address in order of the address. Shawn > + compatible = "fsl,lx2160a-ahci"; > + reg = <0x0 0x3200000 0x0 0x10000>, > + <0x7 0x100520 0x0 0x4>; > + reg-names = "ahci", "sata-ecc"; > + interrupts = ; > + clocks = <&clockgen 4 3>; > + dma-coherent; > + status = "disabled"; > + }; > + > + sata1: sata@3210000 { > + compatible = "fsl,lx2160a-ahci"; > + reg = <0x0 0x3210000 0x0 0x10000>, > + <0x7 0x100520 0x0 0x4>; > + reg-names = "ahci", "sata-ecc"; > + interrupts = ; > + clocks = <&clockgen 4 3>; > + dma-coherent; > + status = "disabled"; > + }; > + > + sata2: sata@3220000 { > + compatible = "fsl,lx2160a-ahci"; > + reg = <0x0 0x3220000 0x0 0x10000>, > + <0x7 0x100520 0x0 0x4>; > + reg-names = "ahci", "sata-ecc"; > + interrupts = ; > + clocks = <&clockgen 4 3>; > + dma-coherent; > + status = "disabled"; > + }; > + > + sata3: sata@3230000 { > + compatible = "fsl,lx2160a-ahci"; > + reg = <0x0 0x3230000 0x0 0x10000>, > + <0x7 0x100520 0x0 0x4>; > + reg-names = "ahci", "sata-ecc"; > + interrupts = ; > + clocks = <&clockgen 4 3>; > + dma-coherent; > + status = "disabled"; > + }; > }; > }; > -- > 1.7.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel