* [PATCH -next] dmaengine: xilinx_dma: remove set but not used variable 'tail_segment'
@ 2019-01-09 12:10 YueHaibing
2019-01-09 12:49 ` Radhey Shyam Pandey
2019-01-20 5:23 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2019-01-09 12:10 UTC (permalink / raw)
To: Vinod Koul, Dan Williams, Michal Simek, Radhey Shyam Pandey,
Andrea Merello, Appana Durga Kedareswara Rao
Cc: dmaengine, kernel-janitors, YueHaibing, linux-arm-kernel
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/dma/xilinx/xilinx_dma.c: In function 'xilinx_vdma_start_transfer':
drivers/dma/xilinx/xilinx_dma.c:1104:33: warning:
variable 'tail_segment' set but not used [-Wunused-but-set-variable]
It not used since commit b8349172b400 ("dmaengine: xilinx_dma: Drop SG support
for VDMA IP")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/dma/xilinx/xilinx_dma.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c
index d9431af..c8acd34 100644
--- a/drivers/dma/xilinx/xilinx_dma.c
+++ b/drivers/dma/xilinx/xilinx_dma.c
@@ -1101,7 +1101,6 @@ static void xilinx_vdma_start_transfer(struct xilinx_dma_chan *chan)
struct xilinx_vdma_config *config = &chan->config;
struct xilinx_dma_tx_descriptor *desc, *tail_desc;
u32 reg, j;
- struct xilinx_vdma_tx_segment *tail_segment;
struct xilinx_vdma_tx_segment *segment, *last = NULL;
int i = 0;
@@ -1120,9 +1119,6 @@ static void xilinx_vdma_start_transfer(struct xilinx_dma_chan *chan)
tail_desc = list_last_entry(&chan->pending_list,
struct xilinx_dma_tx_descriptor, node);
- tail_segment = list_last_entry(&tail_desc->segments,
- struct xilinx_vdma_tx_segment, node);
-
/* Configure the hardware using info in the config structure */
if (chan->has_vflip) {
reg = dma_read(chan, XILINX_VDMA_REG_ENABLE_VERTICAL_FLIP);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH -next] dmaengine: xilinx_dma: remove set but not used variable 'tail_segment'
2019-01-09 12:10 [PATCH -next] dmaengine: xilinx_dma: remove set but not used variable 'tail_segment' YueHaibing
@ 2019-01-09 12:49 ` Radhey Shyam Pandey
2019-01-20 5:23 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Radhey Shyam Pandey @ 2019-01-09 12:49 UTC (permalink / raw)
To: YueHaibing, Vinod Koul, Dan Williams, Michal Simek,
Andrea Merello, Appana Durga Kedareswara Rao
Cc: dmaengine@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
> -----Original Message-----
> From: YueHaibing <yuehaibing@huawei.com>
> Sent: Wednesday, January 9, 2019 5:41 PM
> To: Vinod Koul <vkoul@kernel.org>; Dan Williams
> <dan.j.williams@intel.com>; Michal Simek <michals@xilinx.com>; Radhey
> Shyam Pandey <radheys@xilinx.com>; Andrea Merello
> <andrea.merello@gmail.com>; Appana Durga Kedareswara Rao
> <appanad@xilinx.com>
> Cc: YueHaibing <yuehaibing@huawei.com>; dmaengine@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; kernel-janitors@vger.kernel.org
> Subject: [PATCH -next] dmaengine: xilinx_dma: remove set but not used
> variable 'tail_segment'
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/dma/xilinx/xilinx_dma.c: In function 'xilinx_vdma_start_transfer':
> drivers/dma/xilinx/xilinx_dma.c:1104:33: warning:
> variable 'tail_segment' set but not used [-Wunused-but-set-variable]
>
> It not used since commit b8349172b400 ("dmaengine: xilinx_dma: Drop SG
> support
> for VDMA IP")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thanks for the patch.
Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
> ---
> drivers/dma/xilinx/xilinx_dma.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c
> index d9431af..c8acd34 100644
> --- a/drivers/dma/xilinx/xilinx_dma.c
> +++ b/drivers/dma/xilinx/xilinx_dma.c
> @@ -1101,7 +1101,6 @@ static void xilinx_vdma_start_transfer(struct
> xilinx_dma_chan *chan)
> struct xilinx_vdma_config *config = &chan->config;
> struct xilinx_dma_tx_descriptor *desc, *tail_desc;
> u32 reg, j;
> - struct xilinx_vdma_tx_segment *tail_segment;
> struct xilinx_vdma_tx_segment *segment, *last = NULL;
> int i = 0;
>
> @@ -1120,9 +1119,6 @@ static void xilinx_vdma_start_transfer(struct
> xilinx_dma_chan *chan)
> tail_desc = list_last_entry(&chan->pending_list,
> struct xilinx_dma_tx_descriptor, node);
>
> - tail_segment = list_last_entry(&tail_desc->segments,
> - struct xilinx_vdma_tx_segment, node);
> -
> /* Configure the hardware using info in the config structure */
> if (chan->has_vflip) {
> reg = dma_read(chan,
> XILINX_VDMA_REG_ENABLE_VERTICAL_FLIP);
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] dmaengine: xilinx_dma: remove set but not used variable 'tail_segment'
2019-01-09 12:10 [PATCH -next] dmaengine: xilinx_dma: remove set but not used variable 'tail_segment' YueHaibing
2019-01-09 12:49 ` Radhey Shyam Pandey
@ 2019-01-20 5:23 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2019-01-20 5:23 UTC (permalink / raw)
To: YueHaibing
Cc: Andrea Merello, Radhey Shyam Pandey, kernel-janitors,
Michal Simek, Appana Durga Kedareswara Rao, dmaengine,
Dan Williams, linux-arm-kernel
On 09-01-19, 12:10, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/dma/xilinx/xilinx_dma.c: In function 'xilinx_vdma_start_transfer':
> drivers/dma/xilinx/xilinx_dma.c:1104:33: warning:
> variable 'tail_segment' set but not used [-Wunused-but-set-variable]
>
> It not used since commit b8349172b400 ("dmaengine: xilinx_dma: Drop SG support
> for VDMA IP")
Applied, thanks
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-20 5:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-09 12:10 [PATCH -next] dmaengine: xilinx_dma: remove set but not used variable 'tail_segment' YueHaibing
2019-01-09 12:49 ` Radhey Shyam Pandey
2019-01-20 5:23 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox