From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Sean Paul <sean@poorly.run>
Cc: Rafal Ciepiela <rafalc@cadence.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Kishon Vijay Abraham I <kishon@ti.com>,
Krzysztof Witos <kwitos@cadence.com>,
Chen-Yu Tsai <wens@csie.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v4 8/9] phy: Add Cadence D-PHY support
Date: Mon, 21 Jan 2019 14:39:34 +0100 [thread overview]
Message-ID: <20190121133934.5e3uwk5x6vzno36w@flea> (raw)
In-Reply-To: <20190117135322.GB114153@art_vandelay>
[-- Attachment #1.1: Type: text/plain, Size: 555 bytes --]
Hi Sean,
On Thu, Jan 17, 2019 at 08:53:22AM -0500, Sean Paul wrote:
> On Wed, Jan 09, 2019 at 10:33:25AM +0100, Maxime Ripard wrote:
> > + opts->wakeup = cdns_dphy_get_wakeup_time_ns(dphy) * 1000;
>
> This should be "/ 1000" since the units of wakeup is us now (thanks to patch 2).
> You've made this change in patch 9, so I think it's just a misplaced fixup.
Good catch, this was fixed in patch 9, but it definitely belongs there.
Thanks!
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-21 13:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 9:33 [PATCH v4 0/9] phy: Add configuration interface for MIPI D-PHY devices Maxime Ripard
2019-01-09 9:33 ` [PATCH v4 1/9] phy: dphy: Remove unused header Maxime Ripard
2019-01-09 9:33 ` [PATCH v4 2/9] phy: dphy: Change units of wakeup and init parameters Maxime Ripard
2019-01-09 9:33 ` [PATCH v4 3/9] phy: dphy: Clarify lanes parameter documentation Maxime Ripard
2019-01-09 9:33 ` [PATCH v4 4/9] sun6i: dsi: Convert to generic phy handling Maxime Ripard
2019-02-07 8:16 ` Paul Kocialkowski
2019-01-09 9:33 ` [PATCH v4 5/9] phy: Move Allwinner A31 D-PHY driver to drivers/phy/ Maxime Ripard
2019-01-09 9:33 ` [PATCH v4 6/9] drm/bridge: cdns: Separate DSI and D-PHY configuration Maxime Ripard
2019-01-16 8:36 ` Kishon Vijay Abraham I
2019-01-17 13:33 ` Sean Paul
2019-01-21 15:43 ` Maxime Ripard
2019-01-09 9:33 ` [PATCH v4 7/9] dt-bindings: phy: Move the Cadence D-PHY bindings Maxime Ripard
2019-01-09 12:39 ` Sakari Ailus
2019-01-09 9:33 ` [PATCH v4 8/9] phy: Add Cadence D-PHY support Maxime Ripard
2019-01-09 12:41 ` Sakari Ailus
2019-01-17 13:53 ` Sean Paul
2019-01-21 13:39 ` Maxime Ripard [this message]
2019-01-09 9:33 ` [PATCH v4 9/9] drm/bridge: cdns: Convert to phy framework Maxime Ripard
2019-01-16 8:37 ` Kishon Vijay Abraham I
2019-01-17 13:53 ` Sean Paul
2019-01-09 12:28 ` [PATCH v4 0/9] phy: Add configuration interface for MIPI D-PHY devices Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121133934.5e3uwk5x6vzno36w@flea \
--to=maxime.ripard@bootlin.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kishon@ti.com \
--cc=kwitos@cadence.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=rafalc@cadence.com \
--cc=sean@poorly.run \
--cc=thomas.petazzoni@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox