From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D446C31681 for ; Mon, 21 Jan 2019 17:19:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4837A2085A for ; Mon, 21 Jan 2019 17:19:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CbhGcQAE"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="DrndDkLt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4837A2085A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=alien8.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Fw8lO3zpXmySHA/WF/4est47Fv512oVRByafYwQeS2U=; b=CbhGcQAEpe5pZw NlWsKykVKpaS2mo53H/UYbf9YCLf4eMH6OA5Zyv/bw3t+Y5hfNoB380692wGE1tHdgvH+uZG9ek1h ffcHTGD+Hu/gRRkBQ3ToprsPk+wgsjKHZ2A2qju8mGSJPmkpl9aum3uIwf6LUVPL3NESrhc6cVidh oLtOup0mb5vo8XQbvuNbXKv45R/ZX2a56P7Vzld05EQDD4r0kJ+jIDcOvgHeB1VMDKm51YS8UX7mm 1mJ8QF/fQY7dvNl9PjfhkUHi2xYbiMpJrh2ErOtyLzW5A0kECb+pxkLBOSQfVi8/4me0EtidQEAAO Mjr7CC6q638IBWZiRFZA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gldEH-0003F0-SC; Mon, 21 Jan 2019 17:19:21 +0000 Received: from mail.skyhub.de ([5.9.137.197]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gldEE-0003EN-BF for linux-arm-kernel@lists.infradead.org; Mon, 21 Jan 2019 17:19:19 +0000 Received: from zn.tnic (p200300EC2BC62500FDF77747CEA11C98.dip0.t-ipconnect.de [IPv6:2003:ec:2bc6:2500:fdf7:7747:cea1:1c98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 276E11EC0338; Mon, 21 Jan 2019 18:19:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1548091152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=1MXOUxe2dbSP+5oFW8GgdzjEvQ+X1l4EA8y1vGM0hKg=; b=DrndDkLtJdjx1KB9a/JKFiQgTM/MUMKU4PIo5UofKAkOAdhcTqUUEYeQueiEOjKlq7XtDL eN1kVewDUXjxzEFZNaaYXdtFjnG37Q2wunAs/F9IK6Ju+9KMsZeu+DUtundf6O7nBUgubg 0y64gipYCQPbzysoQ4TR1DMDtbxJt8s= Date: Mon, 21 Jan 2019 18:19:10 +0100 From: Borislav Petkov To: James Morse Subject: Re: [PATCH v7 19/25] ACPI / APEI: Only use queued estatus entry during _in_nmi_notify_one() Message-ID: <20190121171910.GM29166@zn.tnic> References: <20181203180613.228133-1-james.morse@arm.com> <20181203180613.228133-20-james.morse@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20181203180613.228133-20-james.morse@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190121_091918_533653_0998179B X-CRM114-Status: GOOD ( 14.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rafael Wysocki , Tony Luck , Fan Wu , linux-mm@kvack.org, Marc Zyngier , Catalin Marinas , Xie XiuQi , Will Deacon , Christoffer Dall , Dongjiu Geng , linux-acpi@vger.kernel.org, Naoya Horiguchi , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, Len Brown Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 03, 2018 at 06:06:07PM +0000, James Morse wrote: > Each struct ghes has an worst-case sized buffer for storing the > estatus. If an error is being processed by ghes_proc() in process > context this buffer will be in use. If the error source then triggers > an NMI-like notification, the same buffer will be used by > _in_nmi_notify_one() to stage the estatus data, before > __process_error() copys it into a queued estatus entry. > > Merge __process_error()s work into _in_nmi_notify_one() so that > the queued estatus entry is used from the beginning. Use the new > ghes_peek_estatus() to know how much memory to allocate from > the ghes_estatus_pool before reading the records. > > Reported-by: Borislav Petkov > Signed-off-by: James Morse > > Change since v6: > * Added a comment explaining the 'ack-error, then goto no_work'. > * Added missing esatus-clearing, which is necessary after reading the GAS, > --- > drivers/acpi/apei/ghes.c | 59 ++++++++++++++++++++++++---------------- > 1 file changed, 35 insertions(+), 24 deletions(-) Reviewed-by: Borislav Petkov -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel