From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70C53C31681 for ; Mon, 21 Jan 2019 18:48:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4680D21734 for ; Mon, 21 Jan 2019 18:48:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="k+ukSu+k"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="ToDocmLg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4680D21734 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h/wRaoz5w/W3VkR709riwIUgaoz7LhG55UhRwUXWyRA=; b=k+ukSu+kwrGOoH TQ8erOVM1hz9wxh+jKzDhx8Lc99nrgnA3ITttqboTnt9/TYtnu9e1RfRX2UksUxIMhCkk/FR3xqux feyKyzUt9GKjajlepL/5iVgexZ1Bo3kE1VJbTxdgk/sPZOmXjAPcOsfFibnST3Q/QRQnd63Pn7PvV A16xytOcpGcvd/PiFW4Afu8JxjQnwLGY0fruOh/YG1jlCT3M681zMYHLbJyhfvF58yYMGLKM0m+Mo tyklfFrJWI/N5gP1xu2BynrflcEN0zUb5XNTSR9cLM2xsrp4klzWPhpPP7U6mqUzibe5jrdbvpN3H 5xNBiNw+5fvB0Uogx79Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1glech-0005lL-9D; Mon, 21 Jan 2019 18:48:39 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1glecd-0005Zz-G4 for linux-arm-kernel@lists.infradead.org; Mon, 21 Jan 2019 18:48:37 +0000 Received: by mail-pl1-x641.google.com with SMTP id u6so10198999plm.8 for ; Mon, 21 Jan 2019 10:48:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4mZezEn1UW24F8aB9UFTfdM9cpPm9T0nT/EyQb5XwN0=; b=ToDocmLgGraL3RjtQ8CjjFfaQvcJNQKBmvwbbW0miI0IXJEvMhw8sc33ImRy15gOju XbsWH0re5r7c8p8EBFhdzZUMk4fUUuqA9F6xPTmayEz2yWlK23IY4/cgnAeGifXDfNWd UgqZCnrHkvF4bte6fKZhqX9dfx6Q+IsX61GVk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4mZezEn1UW24F8aB9UFTfdM9cpPm9T0nT/EyQb5XwN0=; b=eaoNjeRPN4iG0Z7rQSliueiqJoETyU1HWxE1kqDLRpOa9LcIxwb7humy47afgJszUG XsbMjpRuLZy3T5FwWlW3lkMaKclk9n0dNMJ25G6QVVlTGH3es2dj8R8Z2FGL+2NlKHpa K5udfeE70CIULf/ri1SItlcRzESgDVlLIt2vwZFsTt04uZipvEhrxBlAL6ydtAs5iyJ7 ue/04PPvZIQcUTSrMzI52K7Q9i7Vlg1O+XYSqHoBfTjWfSGn68rpQiBaznamB+CczB4q fVd84kYPgvX0u0sML9o04vlobIw7rTfDO4vSTRYiOwPVByeNIGqzfqdqmeX5icer19ZE QidQ== X-Gm-Message-State: AJcUukfkJc5bBbWczlDZQZfUFHoZLTbCoMpLD1ZfOWrVBw5RDsBr3xVo GCHZdNrOV180LJrzPa5LvGTP0w== X-Google-Smtp-Source: ALg8bN6YuOUWlu/RnYIJj+Q9q3wV9SZWA+/kpBoyYUY1TUPZhfhOrFG5zKhV1jmRDbjCVHJ1J3kJDA== X-Received: by 2002:a17:902:1745:: with SMTP id i63mr30504539pli.145.1548096514706; Mon, 21 Jan 2019 10:48:34 -0800 (PST) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id 6sm25432211pfv.30.2019.01.21.10.48.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Jan 2019 10:48:34 -0800 (PST) Date: Mon, 21 Jan 2019 11:48:31 -0700 From: Mathieu Poirier To: Vivek Gautam Subject: Re: [PATCHv3 3/4] coresight: etm4x: Add support to enable ETMv4.2 Message-ID: <20190121184831.GB14049@xps15> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190121_104835_540289_2DA57AA4 X-CRM114-Status: GOOD ( 21.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Sai Prakash Ranjan , Rajendra Nayak , Suzuki K Poulose , Alexander Shishkin , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Doug Anderson , Bjorn Andersson , David Brown , Rob Herring , Sibi Sankar , Leo Yan , Andy Gross , Stephen Boyd , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 21, 2019 at 04:18:36PM +0530, Vivek Gautam wrote: > > On 1/18/2019 5:52 PM, Sai Prakash Ranjan wrote: > > SDM845 has ETMv4.2 and can use the existing etm4x driver. > > But the current etm driver checks only for ETMv4.0 and > > errors out for other etm4x versions. This patch adds this > > missing support to enable SoC's with ETMv4x to use same > > driver by checking only the ETM architecture major version > > number. > > > > Without this change, we get below error during etm probe: > > > > / # dmesg | grep etm > > [ 6.660093] coresight-etm4x: probe of 7040000.etm failed with error -22 > > [ 6.666902] coresight-etm4x: probe of 7140000.etm failed with error -22 > > [ 6.673708] coresight-etm4x: probe of 7240000.etm failed with error -22 > > [ 6.680511] coresight-etm4x: probe of 7340000.etm failed with error -22 > > [ 6.687313] coresight-etm4x: probe of 7440000.etm failed with error -22 > > [ 6.694113] coresight-etm4x: probe of 7540000.etm failed with error -22 > > [ 6.700914] coresight-etm4x: probe of 7640000.etm failed with error -22 > > [ 6.707717] coresight-etm4x: probe of 7740000.etm failed with error -22 > > > > With this change, etm probe is successful: > > > > / # dmesg | grep coresight > > [ 6.659198] coresight-etm4x 7040000.etm: CPU0: ETM v4.2 initialized > > [ 6.665848] coresight-etm4x 7140000.etm: CPU1: ETM v4.2 initialized > > [ 6.672493] coresight-etm4x 7240000.etm: CPU2: ETM v4.2 initialized > > [ 6.679129] coresight-etm4x 7340000.etm: CPU3: ETM v4.2 initialized > > [ 6.685770] coresight-etm4x 7440000.etm: CPU4: ETM v4.2 initialized > > [ 6.692403] coresight-etm4x 7540000.etm: CPU5: ETM v4.2 initialized > > [ 6.699024] coresight-etm4x 7640000.etm: CPU6: ETM v4.2 initialized > > [ 6.705646] coresight-etm4x 7740000.etm: CPU7: ETM v4.2 initialized > > > > Signed-off-by: Sai Prakash Ranjan > > --- > > drivers/hwtracing/coresight/coresight-etm4x.c | 2 +- > > drivers/hwtracing/coresight/coresight-etm4x.h | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c > > index 53e2fb6e86f6..93d5f1f3145e 100644 > > --- a/drivers/hwtracing/coresight/coresight-etm4x.c > > +++ b/drivers/hwtracing/coresight/coresight-etm4x.c > > @@ -55,7 +55,7 @@ static void etm4_os_unlock(struct etmv4_drvdata *drvdata) > > static bool etm4_arch_supported(u8 arch) > > { > > - switch (arch) { > > + switch (arch >> 4) { > > > While this looks good, from what it looks like arch is a combination of > major version > minor version. So, will it be better to masks, and shifts macros instead of > a magic > number shift. > But, frankly it's upto Mathieu to decide the readability of this. So, I > leave it to him. The layout of the architecture is already well defined in etm4_init_arch_data() [1]. As such just doing the following would be fine with me: /* Mask out the minor version nuber */ switch (arch & 0xf) { Of course by proceeding this way we don't need to modify the define in coresight-etm4x.h. Regards, Mathieu [1]. https://elixir.bootlin.com/linux/latest/source/drivers/hwtracing/coresight/coresight-etm4x.c#L508 > > Thanks > Vivek > > > case ETM_ARCH_V4: > > break; > > default: > > diff --git a/drivers/hwtracing/coresight/coresight-etm4x.h b/drivers/hwtracing/coresight/coresight-etm4x.h > > index 52786e9d8926..05d4bd330881 100644 > > --- a/drivers/hwtracing/coresight/coresight-etm4x.h > > +++ b/drivers/hwtracing/coresight/coresight-etm4x.h > > @@ -136,7 +136,7 @@ > > #define ETM_MAX_RES_SEL 16 > > #define ETM_MAX_SS_CMP 8 > > -#define ETM_ARCH_V4 0x40 > > +#define ETM_ARCH_V4 0x4 > > #define ETMv4_SYNC_MASK 0x1F > > #define ETM_CYC_THRESHOLD_MASK 0xFFF > > #define ETM_CYC_THRESHOLD_DEFAULT 0x100 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel