From: Catalin Marinas <catalin.marinas@arm.com>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: will.deacon@arm.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Lucas Stach <l.stach@pengutronix.de>
Subject: Re: [PATCH] arm64: Kconfig.platforms: fix warning unmet direct dependencies
Date: Fri, 25 Jan 2019 14:32:15 +0000 [thread overview]
Message-ID: <20190125143215.GE25901@arrakis.emea.arm.com> (raw)
In-Reply-To: <20190115191839.13823-1-anders.roxell@linaro.org>
On Tue, Jan 15, 2019 at 08:18:39PM +0100, Anders Roxell wrote:
> When ARCH_MXC get enabled, ARM64_ERRATUM_845719 will be selected and
> this warning will happen when COMPAT isn't set.
>
> WARNING: unmet direct dependencies detected for ARM64_ERRATUM_845719
> Depends on [n]: COMPAT [=n]
> Selected by [y]:
> - ARCH_MXC [=y]
>
> Rework to add 'if COMPAT' before ARM64_ERRATUM_845719 gets selected,
> since ARM64_ERRATUM_845719 depends on COMPAT.
>
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
> arch/arm64/Kconfig.platforms | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index 251ecf34cb02..d4faca775d9c 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -145,7 +145,7 @@ config ARCH_MVEBU
> config ARCH_MXC
> bool "ARMv8 based NXP i.MX SoC family"
> select ARM64_ERRATUM_843419
> - select ARM64_ERRATUM_845719
> + select ARM64_ERRATUM_845719 if COMPAT
> help
> This enables support for the ARMv8 based SoCs in the
> NXP i.MX family.
Actually, do we need to select the errata workarounds explicitly? That
seems to be the only case where we do it (commit 930507c18304, "arm64:
add basic Kconfig symbols for i.MX8"). They are default y, so we
shouldn't need to force them on.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-25 14:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 19:18 [PATCH] arm64: Kconfig.platforms: fix warning unmet direct dependencies Anders Roxell
2019-01-25 14:32 ` Catalin Marinas [this message]
2019-01-25 15:57 ` Lucas Stach
2019-01-30 8:43 ` Anders Roxell
2019-01-30 18:21 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190125143215.GE25901@arrakis.emea.arm.com \
--to=catalin.marinas@arm.com \
--cc=anders.roxell@linaro.org \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).