From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BC7FC282C7 for ; Sat, 26 Jan 2019 16:54:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F746218A6 for ; Sat, 26 Jan 2019 16:54:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Q1zF8Nas"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="DGeHc5v5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F746218A6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oRV4DWZiZL4lbej9Y+mPf6jaALvY7PS4kQ7L6fCxwLE=; b=Q1zF8Nasz0ZgPQ jqW0eG1ao49dZJFFZlmt3nHK1gpAfGm8/fZDwtd8NdZzA+jqjrXtpwetS6UNyxeKuNlANSKJdSfNV sVIiT8jhGtT+n+iOn6cAD3eoGbl0Gv6AzmMhY4jK+fXZA/yxK10Ct9m+HYIavJ6Um0IEirtzCpNWE XRHphWNop85sRjhfjXTH6aSmoGAF8c//FS0oztasqoKLQ+sKtEER8HbWFXH/hSLR0B72Pwi9P0snY 1i3aW7TM3gqXboBd5dCQpJFtabcR7VOrOQsNs+1DaSaUeYi77gIfXHl2KefIVs7A96On/RxEKt6Dp o8ntIIy6RJX1mGANZAOw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gnREG-0007O7-Hg; Sat, 26 Jan 2019 16:54:48 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gnREC-0007NN-A6; Sat, 26 Jan 2019 16:54:45 +0000 Received: from bbrezillon (unknown [91.160.177.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 66E9621872; Sat, 26 Jan 2019 16:54:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548521681; bh=U97JhAc67TlIoQxUSKMiEuA/BMeDSBdzpp3PIvkto18=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DGeHc5v5OwpsLrtBKuw5LKAZtnbOM1h3gUlVB+JpQVIoI9ZFI388RiN1YZs2GYCUc NH1xt5YrV0NkoLod8XeOTNgAUbQM66STTm60psyzC9xptsRDww83fVfCdNNjACkiOa k87uIPS9qbh24NlaJ9ZDpSTWSCC5Bxu3pFRuRvlo= Date: Sat, 26 Jan 2019 17:54:29 +0100 From: Boris Brezillon To: "Gustavo A. R. Silva" Subject: Re: [PATCH] mtd: rawnand: mark expected switch fall-throughs Message-ID: <20190126175429.65e6bfd8@bbrezillon> In-Reply-To: <853a267c-807b-c613-6662-93730a0b4c33@embeddedor.com> References: <20190125210950.GA27855@embeddedor> <20190126105208.221a2051@bbrezillon> <853a267c-807b-c613-6662-93730a0b4c33@embeddedor.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190126_085444_366529_B1C7853A X-CRM114-Status: GOOD ( 14.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kees Cook , Wan ZongShun , Richard Weinberger , linux-kernel@vger.kernel.org, Marek Vasut , Kyungmin Park , linux-mtd@lists.infradead.org, Miquel Raynal , Brian Norris , David Woodhouse , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 26 Jan 2019 07:48:50 -0600 "Gustavo A. R. Silva" wrote: > Hey Boris, > > On 1/26/19 3:52 AM, Boris Brezillon wrote: > > On Fri, 25 Jan 2019 15:09:50 -0600 > > "Gustavo A. R. Silva" wrote: > > > >> diff --git a/drivers/mtd/nand/raw/nandsim.c b/drivers/mtd/nand/raw/nandsim.c > >> index 933d1a629c51..d33e15dc4cdc 100644 > >> --- a/drivers/mtd/nand/raw/nandsim.c > >> +++ b/drivers/mtd/nand/raw/nandsim.c > >> @@ -2251,9 +2251,10 @@ static int __init ns_init_module(void) > >> > >> switch (bbt) { > >> case 2: > >> - chip->bbt_options |= NAND_BBT_NO_OOB; > >> + chip->bbt_options |= NAND_BBT_NO_OOB; > >> + /* fall through */ > >> case 1: > >> - chip->bbt_options |= NAND_BBT_USE_FLASH; > >> + chip->bbt_options |= NAND_BBT_USE_FLASH; > > > > You miss a '/* fall through */' here. > > > > Not really. Notice that in this case the code falls through > to a break statement. Still find it weird to mandate fall through comments in all cases but this one... > > >> case 0: > >> break; > >> default: > > Thanks > -- > Gustavo > > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel