From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AA4EC282C0 for ; Sun, 27 Jan 2019 07:34:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 12B252148D for ; Sun, 27 Jan 2019 07:34:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Xkkh8Lwz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12B252148D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/altVjrJFkl3N8fcB9SuX0LYlVjxgrAkWWzgGd7CJpc=; b=Xkkh8LwzMYreRE iQ8Nko0NNRus/D9+/SLHoOlAdGL8ViayhLm8Z7bHqTl8FkrEYDNxkWAMaeYjuX2XRrzDveDsR8G2i ErRYPONkwBR7NsM1JSZE9XBWC7ZrrBmlH7hQSbM6G43w3lUbJMztMuezqWYzKDUECH2I+dXTdrOar BbAaOcGppl/hvRcJpL6dGepxwmjC1qqY2gaCM3bPqcPFVmpEvCBWAUaE8MlteLVwU6h/P9XZQF7X0 owf/0nYPHbJBGnXuQ3/PzclLk04+v0ed3CNism49rOWlxZoNFfD6bRsowtNcWw2OJ4mGNVQwOp4EE icjp9pAKO0vDO08iEjig==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gnewf-0001oz-Fo; Sun, 27 Jan 2019 07:33:33 +0000 Received: from asavdk4.altibox.net ([109.247.116.15]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gnewb-0001og-EM for linux-arm-kernel@lists.infradead.org; Sun, 27 Jan 2019 07:33:31 +0000 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 5A475803F7; Sun, 27 Jan 2019 08:33:23 +0100 (CET) Date: Sun, 27 Jan 2019 08:33:22 +0100 From: Sam Ravnborg To: Konstantin Sudakov Subject: Re: [PATCH 4/4] drm/panel: Add Rondo RB070D30 panel Message-ID: <20190127073321.GA9954@ravnborg.org> References: <15b81a58eddd5d3fbfa418293cf1c817ef46423a.1548236066.git-series.maxime.ripard@bootlin.com> <20190126153946.GB17756@ravnborg.org> <1548566815.202603076@f339.i.mail.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1548566815.202603076@f339.i.mail.ru> User-Agent: Mutt/1.5.21 (2010-09-15) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=UpRNyd4B c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=kj9zAlcOel0A:10 a=Lw8i-Fxf77uV5PkrcBsA:9 a=CjuIK1q_8ugA:10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190126_233329_670643_AF258B80 X-CRM114-Status: GOOD ( 11.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bbrezillon@kernel.org, Maxime Ripard , Maarten Lankhorst , dri-devel@lists.freedesktop.org, Paul Kocialkowski , Chen-Yu Tsai , Sean Paul , Thomas Petazzoni , Jagan Teki , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Konstantin > >> + ctx->gpios.updn = devm_gpiod_get(&dsi->dev, "updn", GPIOD_OUT_LOW); > >> + if (IS_ERR(ctx->gpios.updn)) { > >> + dev_err(&dsi->dev, "Couldn't get our updn GPIO\n"); > >> + return PTR_ERR(ctx->gpios.updn); > >> + } > > This gpio is never used, it is only read from DT > The gpio is initialized with low state. The state may be inverted by DT. The same for the "shlr". > It is a vertical / horizontal inversion. Ohh, then it makes sense again. Consider adding a comment so this becomes more obvious Sam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel