From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: festevam@gmail.com
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de,
shawnguo@kernel.org, cphealy@gmail.com, linux-imx@nxp.com
Subject: Re: [PATCH] arm64: dts: imx8mq: Add ECSPI support
Date: Sun, 27 Jan 2019 13:34:38 -0800 [thread overview]
Message-ID: <20190127213438.30424-1-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <20190126212824.15641-1-festevam@gmail.com>
> Add support for the three ECSPI ports present on i.MX8MQ.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 39 +++++++++++++++++++++++
> 1 file changed, 39 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 892063a7c26c..45b9d4a8b0da 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -26,6 +26,9 @@
> serial1 = &uart2;
> serial2 = &uart3;
> serial3 = &uart4;
> + spi0 = &ecspi1;
> + spi1 = &ecspi2;
> + spi2 = &ecspi3;
> };
>
> ckil: clock-ckil {
> @@ -381,6 +384,42 @@
> #size-cells = <1>;
> ranges = <0x30800000 0x30800000 0x400000>;
>
> + ecspi1: spi@30820000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "fsl,imx8mq-ecspi", "fsl,imx51-ecspi";
> + reg = <0x0 0x30820000 0x0 0x10000>;
AIPS3 in upstream tree uses #address-cells = <1> and size-cells = <1>,
so 'reg' property of this and other nodes needs to be adjusted for
that (vendor tree uses 2/2). With that small problem fixed:
Tested-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Thanks,
Andrey Smirnov
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-27 21:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-26 21:28 [PATCH] arm64: dts: imx8mq: Add ECSPI support Fabio Estevam
2019-01-27 21:34 ` Andrey Smirnov [this message]
2019-01-28 10:36 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190127213438.30424-1-andrew.smirnov@gmail.com \
--to=andrew.smirnov@gmail.com \
--cc=cphealy@gmail.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).