From: Carlo Caione <ccaione@baylibre.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: mark.rutland@arm.com, andrew@lunn.ch, f.fainelli@gmail.com,
devicetree@vger.kernel.org, s.hauer@pengutronix.de,
Russell King - ARM Linux admin <linux@armlinux.org.uk>,
robh+dt@kernel.org, abailon@baylibre.com, kernel@pengutronix.de,
fabio.estevam@nxp.com, shawnguo@kernel.org, aisheng.dong@nxp.com,
linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com
Subject: Re: [PATCH 0/3] at803x: Add quirk to disable SmartEEE
Date: Mon, 28 Jan 2019 10:46:20 +0000 [thread overview]
Message-ID: <20190128104620.3e724lfm5xv5il4x@xps> (raw)
In-Reply-To: <3e09ef54-f817-2659-4e9e-74a88a80cbcc@gmail.com>
On 25/01/19 20:27, Heiner Kallweit wrote:
/cut
>>> Thanks for the link. According to the description SmartEEE works
>>> only if
>>> both link partners support it (hence are Atheros PHY's). I would assume
>>> that this usually isn't the case, shouldn't the feature be an opt-in
>>> therefore?
>>
>> I'm not convinced about that - I've been using AtherOS SmartEEE with
>> i.MX6 for quite some time (I have patches which allow me to read out
>> the stats via ethtool, and configure it - they're specific to the
>> FEC driver though.) SmartEEE works just like EEE for me, and I
>> notice no problems.
>>
>> I have i.MX6 boards connected to Netgear GS116 and similar switches,
>> and also Marvell DSA switches on other platforms.
>>
>> This is why I said above about "more detail". Then maybe folk would
>> know what to look for to see whether there is a problem.
>>
>OK, then the description of the referenced patch isn't fully correct
>and SmartEEE and EEE are partially compatible, and the problem is
>just that we don't know exactly to which extent.
Reading from the datasheet at [0] it seems that SmartEEE is compatible
with EEE but it's something different.
With SmartEEE the PHY can actually enter LPI state even if this is not
supported by the link partner since the LPI pattern is generated inside
the PHY itself, so auto-implementing a sort of EEE.
So AFAICT EEE and SmartEEE are two different things requiring two
different properties in the DTS if we want to have the possibility to
disable it.
Cheers,
[0]
https://media.digikey.com/pdf/Data%20Sheets/CSR%20PDFs/AR8031_DS_(Atheros)_Rev1.0_Aug2011.pdf
--
Carlo Caione
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-28 10:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 12:55 [PATCH 0/3] at803x: Add quirk to disable SmartEEE Carlo Caione
2019-01-25 12:55 ` [PATCH 1/3] net: phy: at803x: Introduce " Carlo Caione
2019-01-25 12:55 ` [PATCH 2/3] dt-bindings: net: at803x: Document at803x, smarteee-disabled property Carlo Caione
2019-01-25 18:42 ` [PATCH 2/3] dt-bindings: net: at803x: Document at803x,smarteee-disabled property Florian Fainelli
2019-01-25 12:55 ` [PATCH 3/3] arm64: dts: imx8mq-evk: Disable SmartEEE Carlo Caione
2019-01-25 13:06 ` [PATCH 0/3] at803x: Add quirk to disable SmartEEE Russell King - ARM Linux admin
2019-01-25 18:15 ` Heiner Kallweit
2019-01-25 18:48 ` Carlo Caione
2019-01-25 19:07 ` Heiner Kallweit
2019-01-25 19:19 ` Russell King - ARM Linux admin
2019-01-25 19:27 ` Heiner Kallweit
2019-01-28 10:46 ` Carlo Caione [this message]
2019-01-28 15:57 ` Russell King - ARM Linux admin
2019-01-28 18:23 ` Heiner Kallweit
2019-01-28 19:04 ` Russell King - ARM Linux admin
2019-01-30 10:16 ` Carlo Caione
2019-01-30 10:47 ` Russell King - ARM Linux admin
2019-04-12 0:25 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190128104620.3e724lfm5xv5il4x@xps \
--to=ccaione@baylibre.com \
--cc=abailon@baylibre.com \
--cc=aisheng.dong@nxp.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox