From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0814C282C7 for ; Tue, 29 Jan 2019 05:10:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7511E20989 for ; Tue, 29 Jan 2019 05:10:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pPTfxh68"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="fBdEth4G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7511E20989 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Wba0VQt8K0gqjruQ9YbAcXm3UGa26N2f0Fy23toi5u0=; b=pPTfxh68r063wf T2MZYTKV0LaBeSyfqPnUITo+02Ar+H3TJjYYi3QKTayFDvMB6AKWWvff3bmGz4oA9fZeMwwF0eWxH POXQIlSlVvd0hL9gndsdzMCYiVKN539qqz8T1FtO3bOJPoOIe4T4Z6z9FiAwCiHn56uMgi3zX5h4/ qtrMvBJRvJdxS78IA8DSoPfrV1XBj+d1vH6hsyXw/BH2AkoIpNQuaTvvdz/KBmH07CrgqPRpZWjIw r7Qn+/IWSJRurhW8HOebhrPDIkTcqjvNmbfsxTDDaw+4N8mtSKU2QSm7jJn6saC2JRKbw8/OTxvu9 UjheZzD3z6/FYV+RqJMg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1goLfS-0000Lr-RG; Tue, 29 Jan 2019 05:10:38 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1goLfP-0000LU-SG for linux-arm-kernel@lists.infradead.org; Tue, 29 Jan 2019 05:10:37 +0000 Received: by mail-pg1-x543.google.com with SMTP id g189so8254270pgc.5 for ; Mon, 28 Jan 2019 21:10:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cghF4RrrqxX5D1y/VJFr26feFrzLaLgJa3F7VF8MXHc=; b=fBdEth4GbH8Q26/lRA8cz1HUih9W9HBiWo9QgeF0/PtdWSDITv4a1Y71IXu4gEJh04 qlTYMElanHGaoi8Rz8VV5MRHG2inGs1ECehu7+Whla87oKhtMxomJLGEklfdxMankJ8N q+8pJKH+zceNlQanZJyl5bVoS9cAEqCIcd+WQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cghF4RrrqxX5D1y/VJFr26feFrzLaLgJa3F7VF8MXHc=; b=Md2cXf1wiT2qon7e8hh+x8yJsnmSRF1xzJ0yYYVVk6rdxtqkwb93+FJtr6bSG+RiGn dqklSP4+1VCJgCdIqePOIppm3uvNbAMivw2iGtjW2kL6gTC9h4Bz59CqkY9KkeMSH4H7 tYcEh+IS2xuV/WABWBu6VMbQLY+7Wf6Nj7eUbz8JoRwaAfIT/HBEjTx9edB3SLhB34ST IYFRhtJ1KOEso3OtwlQjk+3qDYPLgow7kRM7VxQ8YK+D4Q+C17SvvyKTX3bCLvYyKPXE 8Mem7Eiw5BHgHkdOPbTZnCtXqZwc94KzJa5MA+/cqNuSLmYGwFJ+I6JmUXeCqlS7bYXr vJgA== X-Gm-Message-State: AJcUukfffqR/Yenb0A07JC//aPRVQXwgFnLynP9ChAkBQBWasPQ30Ixg EjmWzcVvR2waXW0mABacVdOonA== X-Google-Smtp-Source: ALg8bN5v50+LDKkZA9h892m1xO1UFoDhY+EPYK/xKnHB2z5Tqi2p6qbs7WDQ89hGhGhZ0VRL6Iw5pA== X-Received: by 2002:a62:b80a:: with SMTP id p10mr24585184pfe.32.1548738634323; Mon, 28 Jan 2019 21:10:34 -0800 (PST) Received: from localhost ([122.172.102.63]) by smtp.gmail.com with ESMTPSA id z191sm41901766pgd.74.2019.01.28.21.10.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Jan 2019 21:10:32 -0800 (PST) Date: Tue, 29 Jan 2019 10:40:30 +0530 From: Viresh Kumar To: Quentin Perret Subject: Re: [PATCH 1/7] PM / OPP: Introduce a power estimation helper Message-ID: <20190129051030.gu5nhr6vmcd35bzk@vireshk-i7> References: <20190128165522.31749-1-quentin.perret@arm.com> <20190128165522.31749-2-quentin.perret@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190128165522.31749-2-quentin.perret@arm.com> User-Agent: NeoMutt/20180323-120-3dd1ac X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190128_211035_921046_3B15AF3B X-CRM114-Status: GOOD ( 21.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, nm@ti.com, lorenzo.pieralisi@arm.com, devicetree@vger.kernel.org, sboyd@kernel.org, rjw@rjwysocki.net, mka@chromium.org, linux-pm@vger.kernel.org, liviu.dudau@arm.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, sudeep.holla@arm.com, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28-01-19, 16:55, Quentin Perret wrote: > diff --git a/drivers/opp/of.c b/drivers/opp/of.c > index 06f0f632ec47..7572a2eb2fd4 100644 > --- a/drivers/opp/of.c > +++ b/drivers/opp/of.c > @@ -1047,3 +1047,63 @@ struct device_node *dev_pm_opp_get_of_node(struct dev_pm_opp *opp) > return of_node_get(opp->np); > } > EXPORT_SYMBOL_GPL(dev_pm_opp_get_of_node); > + > +/** > + * of_dev_pm_opp_get_cpu_power() - Estimates the power of a CPU > + * @mW: pointer to the power estimate in milli-watts > + * @KHz: pointer to the OPP's frequency, in kilo-hertz > + * @cpu: CPU for which power needs to be estimated > + * > + * Computes the power estimated by @CPU at the first OPP above @KHz (ceil), > + * and updates @KHz and @mW accordingly. > + * > + * The power is estimated as P = C * V^2 * f, with C the CPU's capacitance > + * (read from the 'dynamic-power-coefficient' devicetree binding) and V and f > + * respectively the voltage and frequency of the OPP. > + * > + * Return: -ENODEV if the CPU device cannot be found, -EINVAL if the power > + * calculation failed because of missing parameters, 0 otherwise. > + */ > +int of_dev_pm_opp_get_cpu_power(unsigned long *mW, unsigned long *KHz, int cpu) I would suggest to change the return type to unsigned long and return 0 for errors and positive values for mW. > +{ > + unsigned long mV, Hz, MHz; MHz is used only once, I think you can get rid of it just open code the division by 1000000. Maybe remove Hz as well and directly use kHz. > + struct device *cpu_dev; > + struct dev_pm_opp *opp; > + struct device_node *np; > + u32 cap; > + u64 tmp; Name this mW with the above changes. > + int ret; > + > + cpu_dev = get_cpu_device(cpu); > + if (!cpu_dev) > + return -ENODEV; > + > + np = of_node_get(cpu_dev->of_node); > + if (!np) > + return -EINVAL; > + > + ret = of_property_read_u32(np, "dynamic-power-coefficient", &cap); > + of_node_put(np); > + if (ret) > + return -EINVAL; > + > + Hz = *KHz * 1000; > + opp = dev_pm_opp_find_freq_ceil(cpu_dev, &Hz); > + if (IS_ERR(opp)) > + return -EINVAL; > + > + mV = dev_pm_opp_get_voltage(opp) / 1000; > + dev_pm_opp_put(opp); > + if (!mV) > + return -EINVAL; > + > + MHz = Hz / 1000000; > + tmp = (u64)cap * mV * mV * MHz; > + do_div(tmp, 1000000000); > + > + *mW = (unsigned long)tmp; > + *KHz = Hz / 1000; > + > + return 0; > +} > +EXPORT_SYMBOL_GPL(of_dev_pm_opp_get_cpu_power); > diff --git a/include/linux/pm_opp.h b/include/linux/pm_opp.h > index 0a2a88e5a383..fedde14f5187 100644 > --- a/include/linux/pm_opp.h > +++ b/include/linux/pm_opp.h > @@ -322,6 +322,7 @@ int dev_pm_opp_of_get_sharing_cpus(struct device *cpu_dev, struct cpumask *cpuma > struct device_node *dev_pm_opp_of_get_opp_desc_node(struct device *dev); > struct device_node *dev_pm_opp_get_of_node(struct dev_pm_opp *opp); > int of_get_required_opp_performance_state(struct device_node *np, int index); > +int of_dev_pm_opp_get_cpu_power(unsigned long *mW, unsigned long *KHz, int cpu); > #else > static inline int dev_pm_opp_of_add_table(struct device *dev) > { > @@ -364,6 +365,10 @@ static inline int of_get_required_opp_performance_state(struct device_node *np, > { > return -ENOTSUPP; > } Add a blank line here. We missed adding the same before of_get_required_opp_performance_state() earlier, maybe add the new routine before of_get_required_opp_performance_state() and add blank line before and after it :) > +static inline int of_dev_pm_opp_get_cpu_power(unsigned long *mW, unsigned long *KHz, int cpu) > +{ > + return -ENOTSUPP; > +} > #endif > > #endif /* __LINUX_OPP_H__ */ > -- > 2.20.1 -- viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel