From: Eric Biggers <ebiggers@kernel.org>
To: linux-crypto@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>
Cc: Tim Chen <tim.c.chen@linux.intel.com>,
linux-arm-kernel@lists.infradead.org,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [PATCH v2 0/3] crypto: crct10dif assembly cleanup and optimizations
Date: Tue, 29 Jan 2019 00:00:26 -0800 [thread overview]
Message-ID: <20190129080029.22261-1-ebiggers@kernel.org> (raw)
The x86, arm, and arm64 asm implementations of crct10dif are very
difficult to understand partly because many of the comments, labels, and
macros are named incorrectly: the lengths mentioned are usually off by a
factor of two from the actual code. Many other things are unnecessarily
convoluted as well, e.g. there are many more fold constants than
actually needed and some aren't fully reduced.
This series therefore cleans up all these implementations to be much
more maintainable. I also made some small optimizations where I saw
opportunities, resulting in slightly better performance.
This is based on top of the pending patches from Ard Biesheuvel.
These all pass the new extra self-tests.
Changed since v1:
- Moved constants in arm implementation to .rodata.
- Eliminated a few instructions from the x86 implementation.
- Tweaked a few comments.
Eric Biggers (3):
crypto: x86/crct10dif-pcl - cleanup and optimizations
crypto: arm/crct10dif-ce - cleanup and optimizations
crypto: arm64/crct10dif-ce - cleanup and optimizations
arch/arm/crypto/crct10dif-ce-core.S | 554 ++++++++--------
arch/arm/crypto/crct10dif-ce-glue.c | 2 +-
arch/arm64/crypto/crct10dif-ce-core.S | 496 +++++++-------
arch/arm64/crypto/crct10dif-ce-glue.c | 4 +-
arch/x86/crypto/crct10dif-pcl-asm_64.S | 844 +++++++++---------------
arch/x86/crypto/crct10dif-pclmul_glue.c | 3 +-
6 files changed, 797 insertions(+), 1106 deletions(-)
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2019-01-29 8:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 8:00 Eric Biggers [this message]
2019-01-29 8:00 ` [PATCH v2 1/3] crypto: x86/crct10dif-pcl - cleanup and optimizations Eric Biggers
2019-01-29 8:00 ` [PATCH v2 2/3] crypto: arm/crct10dif-ce " Eric Biggers
2019-01-29 8:00 ` [PATCH v2 3/3] crypto: arm64/crct10dif-ce " Eric Biggers
2019-01-29 13:15 ` [PATCH v2 0/3] crypto: crct10dif assembly " Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129080029.22261-1-ebiggers@kernel.org \
--to=ebiggers@kernel.org \
--cc=ard.biesheuvel@linaro.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).