From: Thierry Reding <thierry.reding@gmail.com>
To: Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
linux-kernel@vger.kernel.org,
Jonathan Hunter <jonathanh@nvidia.com>,
Joseph Lo <josephl@nvidia.com>,
linux-tegra@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2 2/6] clocksource: tegra: add Tegra210 timer driver
Date: Tue, 29 Jan 2019 11:29:12 +0100 [thread overview]
Message-ID: <20190129102912.GC28850@ulmo> (raw)
In-Reply-To: <20190129084155.GX7714@pdeschrijver-desktop.Nvidia.com>
[-- Attachment #1.1: Type: text/plain, Size: 1000 bytes --]
On Tue, Jan 29, 2019 at 10:41:55AM +0200, Peter De Schrijver wrote:
> On Mon, Jan 28, 2019 at 04:09:08PM +0100, Thierry Reding wrote:
>
> ...
>
> >
> > Up to here this is a duplicate of timer-tegra20.c. And a lot of
> > tegra210_timer_init() is the same as tegra20_timer_init() as well. Can't
> > we unify the two drivers instead?
> >
> > The power cycle restrictions of the architected timer, do they not apply
> > to chips earlier than Tegra210 either? So don't we need all of these
> > additional features on the timer-tegra20.c driver as well? If so that
>
> No. Chips prior to Tegra114 do not have an arch timer and the arch timer
> does work correctly on Cortex-A15 so Tegra114 and Tegra124 can use it.
> It's broken on Cortex-A57 though, so we can't use it as a wakeup source
> on Tegra210.
If chips prior to Tegra114 don't have an architected timer, then we
can't remove the timer-tegra20 driver, because we still need it on
Tegra20 and Tegra30, right?
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-29 10:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 9:18 [PATCH V2 0/6] Add CPUidle support for Tegra210 Joseph Lo
2019-01-28 9:18 ` [PATCH V2 1/6] dt-bindings: timer: add Tegra210 timer Joseph Lo
2019-01-28 9:18 ` [PATCH V2 2/6] clocksource: tegra: add Tegra210 timer driver Joseph Lo
2019-01-28 13:00 ` Daniel Lezcano
2019-01-29 3:07 ` Joseph Lo
2019-01-28 15:09 ` Thierry Reding
2019-01-29 3:35 ` Joseph Lo
2019-01-29 9:16 ` Jon Hunter
2019-01-29 8:41 ` Peter De Schrijver
2019-01-29 10:29 ` Thierry Reding [this message]
2019-01-30 2:40 ` Joseph Lo
2019-01-31 9:01 ` Peter De Schrijver
2019-01-28 9:18 ` [PATCH V2 3/6] arm64: dts: tegra210: fix timer node Joseph Lo
2019-01-28 9:18 ` [PATCH V2 4/6] arm64: dts: tegra210: add CPU idle states properties Joseph Lo
2019-01-28 9:18 ` [PATCH V2 5/6] arm64: dts: tegra210-p2180: Enable CPU idle support Joseph Lo
2019-01-28 9:18 ` [PATCH V2 6/6] arm64: dts: tegra210-smaug: " Joseph Lo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129102912.GC28850@ulmo \
--to=thierry.reding@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=jonathanh@nvidia.com \
--cc=josephl@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pdeschrijver@nvidia.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).