From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF1F5C169C4 for ; Tue, 29 Jan 2019 15:50:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7EB86214DA for ; Tue, 29 Jan 2019 15:50:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HMxbURf4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7EB86214DA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N/A2fClffhJfYUZqI/St3GbccBqXIbelmHJTaYHHu6A=; b=HMxbURf4ciHHaI OPR+azTR+4V0dab6TP5beY+rmAvB2LjHEEXjdMu9xkBiW8530gs/lr0UNWisNPWGF27hy5goFLEq6 dk1Vbh+rZga+Qil+zFZxA0T4xs/7Y16PVo9q8GVHtDPyRI+IvnSlOfshuruuY6GQf6c9OAqkkN6QJ dTpfz8z86bGtVbeMWBn+aFupI5TPuzlcSrVNKyRprG6kXFGjznVM+3InxR4em02jA3HbD0PIWRYT3 KoMBVO7Et0CEGM5T8ts7fQt3nlEG5NShFH/JvWSBmBJ/1CNtU0uXf7ONJKZN4XMYwQMzWsLxy+5mf Nz2dfgPZSX5v41JLLv7g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1goVeu-0002Iz-0n; Tue, 29 Jan 2019 15:50:44 +0000 Received: from asavdk4.altibox.net ([109.247.116.15]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1goVeq-0000cq-QR for linux-arm-kernel@lists.infradead.org; Tue, 29 Jan 2019 15:50:42 +0000 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 5F1F780480; Tue, 29 Jan 2019 16:48:34 +0100 (CET) Date: Tue, 29 Jan 2019 16:48:33 +0100 From: Sam Ravnborg To: Maxime Ripard Subject: Re: [PATCH 4/4] drm/panel: Add Rondo RB070D30 panel Message-ID: <20190129154833.GA22238@ravnborg.org> References: <15b81a58eddd5d3fbfa418293cf1c817ef46423a.1548236066.git-series.maxime.ripard@bootlin.com> <20190126153946.GB17756@ravnborg.org> <20190129153748.4jpx4kkortmlgq4r@flea> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190129153748.4jpx4kkortmlgq4r@flea> User-Agent: Mutt/1.5.21 (2010-09-15) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=UpRNyd4B c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=kj9zAlcOel0A:10 a=n1W8fZcEApDds0Mnx3oA:9 a=CjuIK1q_8ugA:10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190129_075041_030690_44806A23 X-CRM114-Status: GOOD ( 11.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Konstantin Sudakov , bbrezillon@kernel.org, dri-devel@lists.freedesktop.org, Paul Kocialkowski , Chen-Yu Tsai , Sean Paul , Thomas Petazzoni , Jagan Teki , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Maxime. > > > + } > > > + > > > + drm_mode_set_name(mode); > > > + > > > + mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED; > > > + drm_mode_probed_add(connector, mode); > > > + > > > + panel->connector->display_info.bpc = 8; > > > + panel->connector->display_info.width_mm = 154; > > > + panel->connector->display_info.height_mm = 85; > > See comment on height above. > > Same goes for bpc > > Sorry, I'm not sure to follow you here. bpc and height are both set? I assumed that if we had specified height and width in display_mode then we did not have to do it here. But I may be wrong. And for bpc I was plain wrong. Sam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel