From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: Ludovic Desroches <ludovic.desroches@microchip.com>,
linux-mmc@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: atmel-mci: enable 8 bits buswidth support
Date: Tue, 29 Jan 2019 21:12:39 +0100 [thread overview]
Message-ID: <20190129201239.GC19959@piout.net> (raw)
In-Reply-To: <20190129164950.31052-1-nicolas.ferre@microchip.com>
On 29/01/2019 17:49:12+0100, Nicolas Ferre wrote:
> This patch adds support for 8-bit buswidth.
> Relevant SDCR value modified.
>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> drivers/mmc/host/atmel-mci.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
> index 47189f9ed4e2..735aa5871358 100644
> --- a/drivers/mmc/host/atmel-mci.c
> +++ b/drivers/mmc/host/atmel-mci.c
> @@ -1410,6 +1410,9 @@ static void atmci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
> case MMC_BUS_WIDTH_4:
> slot->sdc_reg |= ATMCI_SDCBUS_4BIT;
> break;
> + case MMC_BUS_WIDTH_8:
> + slot->sdc_reg |= ATMCI_SDCBUS_8BIT;
> + break;
> }
>
> if (ios->clock) {
> @@ -2275,8 +2278,11 @@ static int atmci_init_slot(struct atmel_mci *host,
> * use only one bit for data to prevent fifo underruns and overruns
> * which will corrupt data.
> */
> - if ((slot_data->bus_width >= 4) && host->caps.has_rwproof)
> + if ((slot_data->bus_width >= 4) && host->caps.has_rwproof) {
> mmc->caps |= MMC_CAP_4_BIT_DATA;
> + if (slot_data->bus_width >= 8)
> + mmc->caps |= MMC_CAP_8_BIT_DATA;
> + }
>
> if (atmci_get_version(host) < 0x200) {
> mmc->max_segs = 256;
> --
> 2.17.1
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-29 20:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 16:49 [PATCH] mmc: atmel-mci: enable 8 bits buswidth support Nicolas Ferre
2019-01-29 20:12 ` Alexandre Belloni [this message]
2019-01-30 9:20 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129201239.GC19959@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=nicolas.ferre@microchip.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).