From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEB7DC282D7 for ; Wed, 30 Jan 2019 18:22:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 857FC2087F for ; Wed, 30 Jan 2019 18:22:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="S62J75n1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 857FC2087F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Mzl/DWi1T3IVWxndHVq5+YxKOf8K48olfUqCYh7wvOM=; b=S62J75n1m6O1dy 6QCL2aptTpLfXrXtB94TKPrORBKugstB0RnzSd0jFj0M/33Og75YZKjX++gu4mM3QCHeLWo6bU61q YVNGKivyBS4vFpuS+sIDHrzEyVT+6nuE9MoDJezRUBZOpuu84pxhqpnmsK19yZWnypAowPwbaaMxL BwIT7jdOCKtjp2X46XZg3pEzRJIwwK0njHEMSL+rQSB6tp9G06fQ3inKin7bGb/euo0Dr0wToWBKu vhqMBnGmnp1qSlaelsdA6N7RXznRALxI35/c9C4N/y9cYmrqFtMc6Rm/M9sCk2Co9z1p0X0bR7VVp L5EtwB/ukSzZpkLVzn0w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gouV6-0001hB-VF; Wed, 30 Jan 2019 18:22:16 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gouUi-0001QE-Uc for linux-arm-kernel@lists.infradead.org; Wed, 30 Jan 2019 18:21:58 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 65E2B80D; Wed, 30 Jan 2019 10:21:52 -0800 (PST) Received: from fuggles.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 56AA63F557; Wed, 30 Jan 2019 10:21:51 -0800 (PST) Date: Wed, 30 Jan 2019 18:21:48 +0000 From: Will Deacon To: Anders Roxell Subject: Re: [PATCH] arm64: Kconfig.platforms: fix warning unmet direct dependencies Message-ID: <20190130182148.GO18558@fuggles.cambridge.arm.com> References: <20190115191839.13823-1-anders.roxell@linaro.org> <20190125143215.GE25901@arrakis.emea.arm.com> <1548431829.28802.50.camel@pengutronix.de> <20190130084321.GB3369@localhost.localdomain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190130084321.GB3369@localhost.localdomain> User-Agent: Mutt/1.11.1+86 (6f28e57d73f2) () X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190130_102153_169230_135384E8 X-CRM114-Status: GOOD ( 28.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lucas Stach Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 30, 2019 at 09:43:21AM +0100, Anders Roxell wrote: > On 2019-01-25 16:57, Lucas Stach wrote: > > Am Freitag, den 25.01.2019, 14:32 +0000 schrieb Catalin Marinas: > > > On Tue, Jan 15, 2019 at 08:18:39PM +0100, Anders Roxell wrote: > > > > When ARCH_MXC get enabled, ARM64_ERRATUM_845719 will be selected and > > > > this warning will happen when COMPAT isn't set. > > > > = > > > > WARNING: unmet direct dependencies detected for ARM64_ERRATUM_845719 > > > > =A0 Depends on [n]: COMPAT [=3Dn] > > > > =A0 Selected by [y]: > > > > =A0 - ARCH_MXC [=3Dy] > > > > = > > > > Rework to add 'if COMPAT' before ARM64_ERRATUM_845719 gets selected, > > > > since ARM64_ERRATUM_845719 depends on COMPAT. > > > > = > > > > > > Signed-off-by: Anders Roxell > > > > --- > > > > =A0arch/arm64/Kconfig.platforms | 2 +- > > > > =A01 file changed, 1 insertion(+), 1 deletion(-) > > > > = > > > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.plat= forms > > > > index 251ecf34cb02..d4faca775d9c 100644 > > > > --- a/arch/arm64/Kconfig.platforms > > > > +++ b/arch/arm64/Kconfig.platforms > > > > @@ -145,7 +145,7 @@ config ARCH_MVEBU > > > > =A0config ARCH_MXC > > > > > > =A0 bool "ARMv8 based NXP i.MX SoC family" > > > > > > =A0 select ARM64_ERRATUM_843419 > > > > > > - select ARM64_ERRATUM_845719 > > > > > > + select ARM64_ERRATUM_845719 if COMPAT > > > > > > =A0 help > > > > > > =A0 =A0=A0This enables support for the ARMv8 based SoCs in the > > > > =A0 =A0=A0NXP i.MX family. > > > = > > > Actually, do we need to select the errata workarounds explicitly? That > > > seems to be the only case where we do it (commit 930507c18304, "arm64: > > > add basic Kconfig symbols for i.MX8"). They are default y, so we > > > shouldn't need to force them on. > > = > > This is based on past experience. We've had a lot of cases were people > > did not enable the necessary CPU errata workaround, which then usually > > lead to very hard to debug system failures. It is on our list of things > > to look out for now, but I would feel much better if there is just no > > chance for a user to misconfigure the kernel in this way. > > = > = > Would a better approach be to remove the 'depends on COMPAT' in the > Kconfig and move it into the src files instead see below. I'd prefer to keep the dependency here, because the erratum is not applicable for native (64-bit) userspace. I think your original patch is fine, so: Acked-by: Will Deacon Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel