From: Eric Biggers <ebiggers@kernel.org>
To: linux-crypto@vger.kernel.org, Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Tim Chen <tim.c.chen@linux.intel.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/3] crypto: arm/crct10dif-ce - cleanup and optimizations
Date: Wed, 30 Jan 2019 12:55:55 -0800 [thread overview]
Message-ID: <20190130205553.GA231835@gmail.com> (raw)
In-Reply-To: <20190130031444.28935-3-ebiggers@kernel.org>
On Tue, Jan 29, 2019 at 07:14:43PM -0800, Eric Biggers wrote:
> + .macro __adrl, out, sym
> + movw \out, #:lower16:\sym
> + movt \out, #:upper16:\sym
> + .endm
Hi Ard, it seems we need the __LINUX_ARM_ARCH__ < 7 case after all?
The kbuild test robot reported a build error, which can be reproduced with:
( cat arch/arm/configs/multi_v7_defconfig;
echo CONFIG_ARCH_MULTI_V6=y;
echo CONFIG_CRC_T10DIF=y;
echo CONFIG_CRYPTO_CRCT10DIF_ARM_CE=y ) > .config
make olddefconfig
make arch/arm/crypto/crct10dif-ce-core.o
AS arch/arm/crypto/crct10dif-ce-core.o
arch/arm/crypto/crct10dif-ce-core.S: Assembler messages:
arch/arm/crypto/crct10dif-ce-core.S:165: Error: .err encountered
arch/arm/crypto/crct10dif-ce-core.S:165: Error: selected processor does not support `movw fold_consts_ptr,#:lower16:.Lfold_across_128_bytes_consts' in ARM mode
arch/arm/crypto/crct10dif-ce-core.S:165: Error: selected processor does not support `movt fold_consts_ptr,#:upper16:.Lfold_across_128_bytes_consts' in ARM mode
arch/arm/crypto/crct10dif-ce-core.S:267: Error: .err encountered
arch/arm/crypto/crct10dif-ce-core.S:267: Error: selected processor does not support `movw r3,#:lower16:.Lbyteshift_table+16' in ARM mode
arch/arm/crypto/crct10dif-ce-core.S:267: Error: selected processor does not support `movt r3,#:upper16:.Lbyteshift_table+16' in ARM mode
arch/arm/crypto/crct10dif-ce-core.S:329: Error: .err encountered
arch/arm/crypto/crct10dif-ce-core.S:329: Error: selected processor does not support `movw fold_consts_ptr,#:lower16:.Lfold_across_16_bytes_consts' in ARM mode
arch/arm/crypto/crct10dif-ce-core.S:329: Error: selected processor does not support `movt fold_consts_ptr,#:upper16:.Lfold_across_16_bytes_consts' in ARM mode
scripts/Makefile.build:367: recipe for target 'arch/arm/crypto/crct10dif-ce-core.o' failed
make[1]: *** [arch/arm/crypto/crct10dif-ce-core.o] Error 1
Makefile:1709: recipe for target 'arch/arm/crypto/crct10dif-ce-core.o' failed
make: *** [arch/arm/crypto/crct10dif-ce-core.o] Error 2
- Eric
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-30 20:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 3:14 [PATCH v3 0/3] crypto: crct10dif assembly cleanup and optimizations Eric Biggers
2019-01-30 3:14 ` [PATCH v3 1/3] crypto: x86/crct10dif-pcl - " Eric Biggers
2019-01-30 3:14 ` [PATCH v3 2/3] crypto: arm/crct10dif-ce " Eric Biggers
2019-01-30 20:55 ` Eric Biggers [this message]
2019-01-30 21:00 ` Ard Biesheuvel
2019-01-30 21:08 ` Eric Biggers
2019-01-30 3:14 ` [PATCH v3 3/3] crypto: arm64/crct10dif-ce " Eric Biggers
2019-01-30 8:33 ` [PATCH v3 0/3] crypto: crct10dif assembly " Ard Biesheuvel
2019-01-30 9:13 ` Herbert Xu
2019-01-30 9:19 ` Ard Biesheuvel
2019-01-31 3:37 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130205553.GA231835@gmail.com \
--to=ebiggers@kernel.org \
--cc=ard.biesheuvel@linaro.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).