From: Viresh Kumar <viresh.kumar@linaro.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: nm@ti.com, linux-pm@vger.kernel.org, sboyd@kernel.org,
rjw@rjwysocki.net, linux-kernel@vger.kernel.org,
Quentin Perret <quentin.perret@arm.com>,
sudeep.holla@arm.com, dietmar.eggemann@arm.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/5] PM / OPP: Introduce a power estimation helper
Date: Thu, 31 Jan 2019 12:52:09 +0530 [thread overview]
Message-ID: <20190131072209.nhbgid3cystvr2p5@vireshk-i7> (raw)
In-Reply-To: <20190130190703.GM81583@google.com>
On 30-01-19, 11:07, Matthias Kaehlcke wrote:
> On Wed, Jan 30, 2019 at 05:05:02PM +0000, Quentin Perret wrote:
> > +static int __maybe_unused _get_cpu_power(unsigned long *mW, unsigned long *kHz,
> > + int cpu)
>
> why __maybe_unused?
Yeah, it isn't required I think. He probably added it for the case
where CONFIG_ENERGY_MODEL=n, but even then an inline routine is
defined which will accept it as argument and wouldn't do anything with
it. Had it been a macro, we would have required __maybe_unused but not
now.
--
viresh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-31 7:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 17:05 [PATCH v2 0/5] Register an Energy Model for Arm reference platforms Quentin Perret
2019-01-30 17:05 ` [PATCH v2 1/5] PM / OPP: Introduce a power estimation helper Quentin Perret
2019-01-30 19:07 ` Matthias Kaehlcke
2019-01-31 7:22 ` Viresh Kumar [this message]
2019-01-31 9:34 ` Quentin Perret
2019-01-31 9:37 ` Viresh Kumar
2019-01-31 9:42 ` Quentin Perret
2019-01-31 7:26 ` Viresh Kumar
2019-01-31 9:51 ` Quentin Perret
2019-01-30 17:05 ` [PATCH v2 2/5] cpufreq: dt: Register an Energy Model Quentin Perret
2019-01-30 17:05 ` [PATCH v2 3/5] cpufreq: scpi: " Quentin Perret
2019-01-30 17:05 ` [PATCH v2 4/5] cpufreq: arm_big_little: " Quentin Perret
2019-01-30 17:05 ` [PATCH v2 5/5] cpufreq: scmi: " Quentin Perret
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190131072209.nhbgid3cystvr2p5@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mka@chromium.org \
--cc=nm@ti.com \
--cc=quentin.perret@arm.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox