linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Joseph Lo <josephl@nvidia.com>
Cc: linux-tegra@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Jonathan Hunter <jonathanh@nvidia.com>
Subject: Re: [PATCH V4 6/7] arm64: dts: tegra210-p2180: Enable CPU idle support
Date: Thu, 31 Jan 2019 13:57:11 +0100	[thread overview]
Message-ID: <20190131125711.GL23438@ulmo> (raw)
In-Reply-To: <20190131092410.28222-7-josephl@nvidia.com>


[-- Attachment #1.1: Type: text/plain, Size: 1087 bytes --]

On Thu, Jan 31, 2019 at 05:24:09PM +0800, Joseph Lo wrote:
> Enable CPU idle support for Jetson TX1 platform.
> 
> Signed-off-by: Joseph Lo <josephl@nvidia.com>
> ---
> v4:
>  * no change
> v3:
>  * no change
> v2:
>  * no change
> ---
>  arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi b/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi
> index 053458a5db55..d1a492c63e96 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi
> @@ -305,6 +305,12 @@
>  		cpu@3 {
>  			enable-method = "psci";
>  		};
> +
> +		idle-states {
> +			c7 {
> +				status = "okay";

Doesn't seem like the code currently cares, but the bindings are
specific, so this looks good to me.

Given that we need the timer in order to get out of this state, I'm
assuming that I should hold back on these patches until the driver
changes have been merged to make sure we don't regress. Is that
correct?

Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-01-31 12:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-31  9:24 [PATCH V4 0/7] Add CPUidle support for Tegra210 Joseph Lo
2019-01-31  9:24 ` [PATCH V4 1/7] dt-bindings: timer: add Tegra210 timer Joseph Lo
2019-01-31  9:24 ` [PATCH V4 2/7] clocksource: tegra: add Tegra210 timer support Joseph Lo
2019-01-31 11:23   ` Thierry Reding
2019-01-31  9:24 ` [PATCH V4 3/7] soc/tegra: default select TEGRA_TIMER for Tegra210 Joseph Lo
2019-01-31 11:26   ` Thierry Reding
2019-02-01  2:23     ` Joseph Lo
2019-01-31  9:24 ` [PATCH V4 4/7] arm64: dts: tegra210: fix timer node Joseph Lo
2019-01-31  9:24 ` [PATCH V4 5/7] arm64: dts: tegra210: add CPU idle states properties Joseph Lo
2019-01-31  9:24 ` [PATCH V4 6/7] arm64: dts: tegra210-p2180: Enable CPU idle support Joseph Lo
2019-01-31 12:57   ` Thierry Reding [this message]
2019-02-01  2:26     ` Joseph Lo
2019-01-31  9:24 ` [PATCH V4 7/7] arm64: dts: tegra210-smaug: " Joseph Lo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190131125711.GL23438@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=josephl@nvidia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-tegra@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).