From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43130C169C4 for ; Thu, 31 Jan 2019 16:10:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0B557218AC for ; Thu, 31 Jan 2019 16:10:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mX57dlkD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B557218AC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U3s0w0n82c1n080Hx+NYmEEDNJCX91Lyub9IaVhhKLk=; b=mX57dlkDO3lmtG eAwV+yCWMtuyAgHPNR0lZnX63O3R/ymcubWYHmTQOJKR1GmEwkbuefJRpDA8kaJQnVeD7txLGX/qT v2yqeP4r39UcxxY7pKoIVpO0F9PAyKG+fqw9dPzSinU3Em8yTaaXI4HQukmrjcNrmur5VAdNdyhB7 te/gxL6cAUMXhI/kMXNcPC48I2rWsesE2L4kv/VB0o35wXJLmEodYXuaclUUDNFzcP50PuFeYks06 mwN5qyQw/hrtASM87aFyNp+fOIzENv7T03KlRDhxe69KIP0+9Fz8pEUz25wsuZKwStLD1UeL+EQU0 nAhH15HAap1tzRnIpr5Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gpEuv-0000aR-K4; Thu, 31 Jan 2019 16:10:17 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gpEur-0000Vs-Sn for linux-arm-kernel@lists.infradead.org; Thu, 31 Jan 2019 16:10:15 +0000 X-Originating-IP: 90.88.147.226 Received: from windsurf (aaubervilliers-681-1-27-226.w90-88.abo.wanadoo.fr [90.88.147.226]) (Authenticated sender: thomas.petazzoni@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 8EC09FF814; Thu, 31 Jan 2019 16:10:03 +0000 (UTC) Date: Thu, 31 Jan 2019 17:10:01 +0100 From: Thomas Petazzoni To: Leigh Brown Subject: Re: Out-of-tree mwlwifi driver crashes Message-ID: <20190131171001.42f181e5@windsurf> In-Reply-To: <3029c89268680e5abe4f073d8247f74d@solinno.co.uk> References: <01e409217be1c1cb08ac3bab072fccd3@solinno.co.uk> <20190129155913.163f1e98@windsurf> <20190129163117.0af2ebb3@windsurf> <8eb5b2981e6e60e91a3eacbb88a5ee7b@solinno.co.uk> <20190131164653.2599d6e7@windsurf> <3029c89268680e5abe4f073d8247f74d@solinno.co.uk> Organization: Bootlin X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190131_081014_080337_89A2FF51 X-CRM114-Status: GOOD ( 12.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pci@vger.kernel.org, =?UTF-8?B?THXDrXM=?= Mendes , Russell King - ARM Linux admin , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 31 Jan 2019 16:06:10 +0000 Leigh Brown wrote: > > diff --git a/drivers/pci/pci-bridge-emul.c > > b/drivers/pci/pci-bridge-emul.c > > index 129738362d90..f99b80c19809 100644 > > --- a/drivers/pci/pci-bridge-emul.c > > +++ b/drivers/pci/pci-bridge-emul.c > > @@ -142,11 +142,7 @@ const static struct pci_bridge_reg_behavior > > pci_regs_behavior[] = { > > }, > > > > [PCI_PREF_MEMORY_BASE / 4] = { > > - /* The high 12-bits of pref mem base/limit are RW */ > > - .rw = GENMASK(31, 20) | GENMASK(15, 4), > > - > > - /* The low four bits of pref mem base/limit are RO */ > > - .ro = GENMASK(19, 16) | GENMASK(3, 0), > > + .ro = ~0, > > }, > > > > [PCI_PREF_BASE_UPPER32 / 4] = { > > Thanks for responding. I had to manually apply the patch, but it > certainly fixes the issue. Ah, good to hear this. Let's see if I can find a good fix for this then. Thanks, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel