From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98B4CC169C4 for ; Thu, 31 Jan 2019 16:56:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4345D218AF for ; Thu, 31 Jan 2019 16:56:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XrSTO9xU"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="WYPSA056" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4345D218AF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LifTGeVWm5hPjWWhnu5PiKDdgbXY/xB9gbk7g6jwh9M=; b=XrSTO9xUSZU/dz yFyLiDRP6ZQ1FReA3IMuNlCRQBOMrxMMbDWZLjl4sCNO/Rrzci+oOSkJngE5wuybIXP6PMmLRZKzZ Iw7/50VwDYuXQHzYlaHX23LwUHJUXLNTGVvJYhuc+8QFZbMlpSzUnZmCNgENqigkv54KTd4X04TXV FDZIoXaWfcyNnw6I0/qcIm6AwPxXh/kPfHTDeQdgZNLOPRmhsudIunZDTO+95BJbvnTJA/qBlIlyf BVUaJB2Eb2zMxpgrZEUi8iZR5SeVka1dml0q6cUGljJaULqcgTrUpSYTIKYQjKnj9B7b/9akFm0Zo pmW87o356ItKQ39mwoDA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gpFd1-00015g-FO; Thu, 31 Jan 2019 16:55:51 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gpFcx-00014f-9y; Thu, 31 Jan 2019 16:55:48 +0000 Received: from bbrezillon (91-160-177-164.subs.proxad.net [91.160.177.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5EDE2218AF; Thu, 31 Jan 2019 16:55:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548953746; bh=5InK5VVpqOh9e3SQsYJHpCS38H6ABMfXKqzoKGLxjl8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WYPSA056mZica1VwG8DG43PAnno1y7GGhDARRwdmhsXCFiuDIwkUHXb/rKr4t1Y5S rMuz1uK6DC1gWjjKzeJYMvgjOQCv7yC4tNWXhUPt0HzXncCzWZ/Kjaq5Ng6xz79y/9 LfE9MVeeEWfA7rQ5SELv1Xt9OeLpXBZ+uvdxG/Sk= Date: Thu, 31 Jan 2019 17:55:35 +0100 From: Boris Brezillon To: Subject: Re: [PATCH v2 01/10] spi: atmel-quadspi: cache MR value to avoid a write access Message-ID: <20190131175535.3f60ccff@bbrezillon> In-Reply-To: <20190131161515.21605-2-tudor.ambarus@microchip.com> References: <20190131161515.21605-1-tudor.ambarus@microchip.com> <20190131161515.21605-2-tudor.ambarus@microchip.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190131_085547_366428_55062871 X-CRM114-Status: GOOD ( 14.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-spi@vger.kernel.org, Ludovic.Desroches@microchip.com, broonie@kernel.org, linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 31 Jan 2019 16:15:28 +0000 wrote: > From: Tudor Ambarus > > Cache MR value to avoid write access when setting the controller > in Serial Memory Mode (SMM). SMM is set in exec_op() and not at > probe time, to let room for future regular SPI support. > > Signed-off-by: Tudor Ambarus > --- > v2: cache MR value instead of moving the write access at probe > > drivers/spi/atmel-quadspi.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c > index ddc712410812..fe05aee5d845 100644 > --- a/drivers/spi/atmel-quadspi.c > +++ b/drivers/spi/atmel-quadspi.c > @@ -155,6 +155,7 @@ struct atmel_qspi { > struct clk *clk; > struct platform_device *pdev; > u32 pending; > + u32 mr; > struct completion cmd_completion; > }; > > @@ -238,7 +239,9 @@ static int atmel_qspi_exec_op(struct spi_mem *mem, const struct spi_mem_op *op) > icr = QSPI_ICR_INST(op->cmd.opcode); > ifr = QSPI_IFR_INSTEN; > > - qspi_writel(aq, QSPI_MR, QSPI_MR_SMM); > + /* Set the QSPI controller in Serial Memory Mode */ > + if (!(aq->mr & QSPI_MR_SMM)) if (aq->mr != QSPI_MR_SMM) > + qspi_writel(aq, QSPI_MR, QSPI_MR_SMM); You need to update ->mr here. > > mode = find_mode(op); > if (mode < 0) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel