From: Sudeep Holla <sudeep.holla@arm.com>
To: Joseph Lo <josephl@nvidia.com>
Cc: linux-pm@vger.kernel.org,
Daniel Lezcano <daniel.lezcano@linaro.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Sudeep Holla <sudeep.holla@arm.com>,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2] cpuidle: dt: bail out if the idle-state DT node is not compatible
Date: Fri, 1 Feb 2019 11:48:38 +0000 [thread overview]
Message-ID: <20190201114838.GA10042@e107155-lin> (raw)
In-Reply-To: <20190201021639.27245-1-josephl@nvidia.com>
On Fri, Feb 01, 2019 at 10:16:39AM +0800, Joseph Lo wrote:
> Currently, the DT of the idle states will be parsed first whether it's
> compatible or not. This could cause a warning message that comes from if
> the CPU doesn't support identical idle states. E.g. Tegra186 can run
> with 2 Cortex-A57 and 2 Denver cores with different idle states on
> different types of these cores.
>
> So fix it by checking the match node earlier, then it can make sure it
> only goes through the idle states that the CPU supported.
>
> Signed-off-by: Joseph Lo <josephl@nvidia.com>
> ---
> v2:
> * fix it by moving of_match_node earlier, so we don't need to match the
> node twice like the v1 did.
Neat, thanks for the quick patch. FWIW,
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-01 11:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 2:16 [PATCH V2] cpuidle: dt: bail out if the idle-state DT node is not compatible Joseph Lo
2019-02-01 11:48 ` Sudeep Holla [this message]
2019-02-06 10:25 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201114838.GA10042@e107155-lin \
--to=sudeep.holla@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=josephl@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox