From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB176C282D8 for ; Fri, 1 Feb 2019 11:54:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BBD362082C for ; Fri, 1 Feb 2019 11:54:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dOTJodwe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBD362082C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WqFnPF7PA42kA6hIicvAMBFEEImjnWpjq4+9H2n0e2M=; b=dOTJodweYGTMBQ EEO2Dr9V8OnoWYigtXc7bNxrD8YesEMlkr4/6s9+qVWhmKDmzsGdrFxvr/gvnnfmmLHjUuvxSTBa+ UK1dkOyBdqRCWiwJlTwnnxKHVktku2zY9MF4n32IWHMlpguJGvNzjKpBDkllUWNqSw34aLDHzSIem Y0G6L4ZFs9lmHV8hFMUMb23wm/kmpxUna1WSzVZ3RTjvfvtmqPcO3L1v/6LqAornHW/YaGpP7bO8H I2lYf/y38p+unawLDQD6qPvMBWrRzYrqi5qXvNCIYdcLQvFXSKXnEYWn4Su4odIpXPuOCsvBQDELX 9lpqStvjrjycOGdQuayg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gpXOc-0001i6-W5; Fri, 01 Feb 2019 11:54:10 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gpXOV-0001a4-9C for linux-arm-kernel@lists.infradead.org; Fri, 01 Feb 2019 11:54:05 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D85AD80D; Fri, 1 Feb 2019 03:54:01 -0800 (PST) Received: from e107155-lin (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E76073F59C; Fri, 1 Feb 2019 03:53:59 -0800 (PST) Date: Fri, 1 Feb 2019 11:53:57 +0000 From: Sudeep Holla To: Quentin Perret Subject: Re: [PATCH v3 4/5] cpufreq: arm_big_little: Register an Energy Model Message-ID: <20190201115357.GB10042@e107155-lin> References: <20190201093101.31869-1-quentin.perret@arm.com> <20190201093101.31869-5-quentin.perret@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190201093101.31869-5-quentin.perret@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190201_035403_679883_2418B877 X-CRM114-Status: GOOD ( 18.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, linux-pm@vger.kernel.org, sboyd@kernel.org, viresh.kumar@linaro.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, mka@chromium.org, Sudeep Holla , dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 01, 2019 at 09:31:00AM +0000, Quentin Perret wrote: > From: Dietmar Eggemann > > Now that PM_OPP provides a helper function to estimate the power > consumed by CPUs, make sure to try and register an Energy Model (EM) > from the arm_big_little CPUFreq driver, hence ensuring interested > subsystems (the task scheduler, for example) can make use of that > information when available. > > Signed-off-by: Dietmar Eggemann > Signed-off-by: Quentin Perret > --- > drivers/cpufreq/arm_big_little.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/cpufreq/arm_big_little.c b/drivers/cpufreq/arm_big_little.c > index cf62a1f64dd7..18b05bcb2614 100644 > --- a/drivers/cpufreq/arm_big_little.c > +++ b/drivers/cpufreq/arm_big_little.c > @@ -487,6 +487,14 @@ static int bL_cpufreq_init(struct cpufreq_policy *policy) > policy->cpuinfo.transition_latency = > arm_bL_ops->get_transition_latency(cpu_dev); > > + ret = dev_pm_opp_get_opp_count(cpu_dev); > + if (ret <= 0) { > + dev_dbg(cpu_dev, "OPP table is not ready, deferring probe\n"); > + return -EPROBE_DEFER; > + } The only user of this has the check in init_opp_table that gets called from get_cluster_clk_and_freq_table. So the above is not necessary, you can drop it. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel