From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1F5EC282DB for ; Sat, 2 Feb 2019 07:15:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9EF8121872 for ; Sat, 2 Feb 2019 07:15:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fmDBl6y/"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="jnC27kdT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9EF8121872 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HwdIiW/UUUKAiUp2o50OkjKKYZpc6P3uZoBl1WhrnoQ=; b=fmDBl6y/bk4QVH oV/G6HzcjFdA0Vke7i5kWFrO0Onn42knbaMkZ2D0+KltS0S6WqDTIxaLZcglb0iaembYKKlFAK26M dAR+v7O9+ivp1cUYhP4xWBoKkzYRzDkN1EmiXb1D+guGz+aVW+2zgSZV/1AwkIghxql1zvJYpuqvt M2/eLGerAc4C69oyAPGaDK1Wk/RQBYbmAOcW5rKU6QYF0jJDpVr100I35/NePUvtbAisHevLnl/KP oMLSYCtjuKicvCpKLzjUHSmYfTT2aIcCOx6HbpFVcf2/nv3sN1yF2gjaTJzIOpJPoO6j7CTOjSAQN IyU7sChVZmpFxH7Qmf5A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gppWH-0002wo-CA; Sat, 02 Feb 2019 07:15:17 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gppWF-0002wL-5y; Sat, 02 Feb 2019 07:15:16 +0000 Received: from bbrezillon (91-160-177-164.subs.proxad.net [91.160.177.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 868BD20869; Sat, 2 Feb 2019 07:15:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549091714; bh=pe2Sgi9wB9pgA71g5eSonL3P7g0Axagq1YpMcrCeSnQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jnC27kdTCZew7WT0oAlu50LnVVmsAOemYotBxRSe2wBn3bTK/yf19u3bE9MXcl3J1 Fnt/7o24+6r7qTPoeeoXv0OPuiJzkGhsh+mqsNqWYzaisB6Aecj8jfZgsgT/HdqdJv W43kHzh3aBiHNYvjak75PLtJlFziEhi0uT/F+UdI= Date: Sat, 2 Feb 2019 08:15:02 +0100 From: Boris Brezillon To: Subject: Re: [PATCH v3 10/13] dt-bindings: spi: atmel-quadspi: make "pclk" mandatory Message-ID: <20190202081502.47ca404d@bbrezillon> In-Reply-To: <20190202040653.1217-11-tudor.ambarus@microchip.com> References: <20190202040653.1217-1-tudor.ambarus@microchip.com> <20190202040653.1217-11-tudor.ambarus@microchip.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190201_231515_241298_1AF9E262 X-CRM114-Status: GOOD ( 14.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org, Cyrille.Pitchen@microchip.com, robh+dt@kernel.org, linux-spi@vger.kernel.org, Ludovic.Desroches@microchip.com, broonie@kernel.org, linux-mtd@lists.infradead.org, bugalski.piotr@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 2 Feb 2019 04:07:39 +0000 wrote: > From: Tudor Ambarus > > Naming clocks is a good practice. Make "pclk" madatory even if > we support unnamed clock in the driver, to be backward compatible > with old DTs. > > Suggested-by: Boris Brezillon > Signed-off-by: Tudor Ambarus > --- > v3: new patch > > Documentation/devicetree/bindings/spi/atmel-quadspi.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/atmel-quadspi.txt b/Documentation/devicetree/bindings/spi/atmel-quadspi.txt > index e9dae6264d89..1de54e87f5d6 100644 > --- a/Documentation/devicetree/bindings/spi/atmel-quadspi.txt > +++ b/Documentation/devicetree/bindings/spi/atmel-quadspi.txt > @@ -9,6 +9,7 @@ Required properties: > - qspi_mmap: memory mapped address space > - interrupts: Should contain the interrupt for the device. > - clocks: The phandle of the clock needed by the QSPI controller. > +- clock-names: Should contain "pclk" for the peripheral clock. > - #address-cells: Should be <1>. > - #size-cells: Should be <0>. > > @@ -20,6 +21,7 @@ spi@f0020000 { > reg-names = "qspi_base", "qspi_mmap"; > interrupts = <52 IRQ_TYPE_LEVEL_HIGH 7>; > clocks = <&pmc PMC_TYPE_PERIPHERAL 52>; > + clock-names = "pclk" Missing semicolon. Once fixed you can add Reviewed-by: Boris Brezillon > #address-cells = <1>; > #size-cells = <0>; > pinctrl-names = "default"; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel