From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D9EEC282C4 for ; Mon, 4 Feb 2019 09:34:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FCCE214DA for ; Mon, 4 Feb 2019 09:34:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="N3IacxKo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1FCCE214DA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1x+IqCMF5aUtmFuOPeUmV4DlF7rWkk4rW9x83Q6z49c=; b=N3IacxKorEOIcK1oIyuNl4r5v bnC2xN+1vpEfSOdlHMC5BYevtRlx3iinkTyVwuvC18o0lL8e4UMY0FEnT+ridgKiC+kaoC8dMT7Ve TWj8OrO+/IPQJ64oqSKgPnfVJyQV1T1S0iNBXxNiHLRHqol5vPkvKVzt8cgOCCLivVL6ehggZ5usc nbl+6NXVHx/0bk2iJtukTihWmnhjhd8KQ64Exf/O+htK89ZlgHhsDP1Rq3/1l5UGjO38k8N9RchXz DT2K1O+9RTLuBjv7nSYkNhWC1asBxePKKMxfW1EPzdeezRnw8ledtFeS4dzngHjAdb5xMkQ/IGh4O b6uO8kuFA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gqaeK-0007H4-Mm; Mon, 04 Feb 2019 09:34:44 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gqaeH-0007G5-Bt for linux-arm-kernel@lists.infradead.org; Mon, 04 Feb 2019 09:34:43 +0000 X-Originating-IP: 90.88.147.226 Received: from localhost (aaubervilliers-681-1-27-226.w90-88.abo.wanadoo.fr [90.88.147.226]) (Authenticated sender: maxime.ripard@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 9BB5CC000E; Mon, 4 Feb 2019 09:34:28 +0000 (UTC) Date: Mon, 4 Feb 2019 10:34:27 +0100 From: Maxime Ripard To: Chen-Yu Tsai Subject: Re: [PATCH 2/3] mmc: sunxi: Filter out unsupported modes declared in the device tree Message-ID: <20190204093427.vg63e5xmd7u52leh@flea> References: <20190203155628.16767-1-wens@csie.org> <20190203155628.16767-3-wens@csie.org> MIME-Version: 1.0 In-Reply-To: <20190203155628.16767-3-wens@csie.org> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190204_013441_554279_73A658A4 X-CRM114-Status: GOOD ( 21.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Ulf Hansson , Chris Blake , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-sunxi@googlegroups.com, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============2214420643718354548==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2214420643718354548== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="p42mp7wsvouznbye" Content-Disposition: inline --p42mp7wsvouznbye Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 03, 2019 at 11:56:27PM +0800, Chen-Yu Tsai wrote: > The MMC device tree bindings include properties used to signal various > signalling speed modes. Until now the sunxi driver was accepting them > without any further filtering, while the sunxi device trees were not > actually using them. >=20 > Since some of the H5 boards can not run at higher speed modes stably, > we are resorting to declaring the higher speed modes per-board. >=20 > Regardless, having boards declare modes and blindly following them, > even without proper support in the driver, is generally a bad thing. >=20 > Filter out all unsupported modes from the capabilities mask after > the device tree properties have been parsed. >=20 > Cc: > Signed-off-by: Chen-Yu Tsai >=20 > --- >=20 > This should be backported to stable kernels in case people try to run > new device trees (that declare newly supported modes) with old kernels. > --- > drivers/mmc/host/sunxi-mmc.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) >=20 > diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c > index 7415af8c8ff6..a01433012db0 100644 > --- a/drivers/mmc/host/sunxi-mmc.c > +++ b/drivers/mmc/host/sunxi-mmc.c > @@ -1415,6 +1415,22 @@ static int sunxi_mmc_probe(struct platform_device = *pdev) > if (ret) > goto error_free_dma; > =20 > + /* > + * If we don't support delay chains in the SoC, we can't use any > + * of the DDR speed modes. Mask them out in case the device > + * tree specifies the properties for them, which gets added to > + * the caps by mmc_of_parse() above. > + */ > + if (!(host->cfg->clk_delays || host->use_new_timings)) > + mmc->caps &=3D ~(MMC_CAP_3_3V_DDR | MMC_CAP_1_8V_DDR | > + MMC_CAP_1_2V_DDR); > + > + /* TODO: UHS modes untested due to lack of supporting boards */ > + mmc->caps &=3D ~MMC_CAP_UHS; I've tested up to SDR104 and it works on the A64 at least > + /* TODO: This driver doesn't support HS200 and HS400 modes yet */ > + mmc->caps2 &=3D ~(MMC_CAP2_HS200 | MMC_CAP2_HS400); And HS200 works too. Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --p42mp7wsvouznbye Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXFgHIwAKCRDj7w1vZxhR xQSuAQDzqY3AgbX6jdcqPJZ8CyLaVSntDctVN1OhIxNi/NLn0gEA/LUVZ2v6jW7j y5XrPWcvFc9RMdlngq/1H74VfzPbXgU= =FTPy -----END PGP SIGNATURE----- --p42mp7wsvouznbye-- --===============2214420643718354548== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2214420643718354548==--