From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F059C282CB for ; Tue, 5 Feb 2019 08:57:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DAE9D20844 for ; Tue, 5 Feb 2019 08:57:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="REHDE1Iq"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="g8Ltrq5O" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DAE9D20844 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZsdE86VAWXX0qA88+Q4d3HkKXLMsuK3bv1fuSb3s9oU=; b=REHDE1IqWWamUb JLfPoZ/GhGyPYfNNO0/hNSNVzS2jr4qGa9hIr6THqhmZh7L/TodYQQnTz6qF1MnxRqH/aJeq3fTiQ oKwsezRJEu7MVsU9n9w/HVeC2+3kVqv1GgL8KQp++pXrig7Ed/1MBEWmdQFSg4XoMnSQzvs3N/ZIV NziiN1GZMnI4WV972MnRohsZTqcY6tPjjYw1EFAIuixJ6VBzQsOyxvQ5YHOllTI/ut9NwtIi1zqgB Xwuyv0HL99oWlO55mCntlcM3GEIq1b5Vgp7URomVfhqtafppT+8NWudoJvK2ccL5rP3vetUJgo3nt nrG4B8ZXgGuA8NVRt38g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gqwY6-0005w3-E1; Tue, 05 Feb 2019 08:57:46 +0000 Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gqwY3-0005vg-6h for linux-arm-kernel@lists.infradead.org; Tue, 05 Feb 2019 08:57:45 +0000 Received: by mail-ed1-x544.google.com with SMTP id x30so2213049edx.2 for ; Tue, 05 Feb 2019 00:57:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ylesqHaiKaW/6oHTiJCqsubSPJwOncKJWSmHdIHxLRg=; b=g8Ltrq5OuXaGt9aZlOwBHEFIUHp/sSQFsM85vWk1CBEGQ8T8fAg7lHrkkjVCpzl3lG 6fTKVJ4WKT8qKEkJs4u1l/jPL/Q7lxi5JN9R8chRmTg265EUezK2vFeUKPPVKWuWTOwc hy7gS4jcamLCYMlZKZNZjMs63motj0NypDZKo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=ylesqHaiKaW/6oHTiJCqsubSPJwOncKJWSmHdIHxLRg=; b=WEx7jPmt0rYOUr+vTY24G+JLgcup3vUpXDntHTcYALdsW6bF7Oc7DQyVMRWCJ4j/1K VRYh6RdGuvI01leGjrJOzXK86MWxj4wW6gecutvii8AJig/bO3ZcKuSeC3t9hkzxW2A9 PLe9fj6cMiJwxdHwIaGJ1VEfiyRjuJ8A7bfWCAfG9kHYwPmkDvQnN9gCObj252CezN8x JKq+X1KVPfPeAYKgBoCsFY8PkeUAtvSyQAjW2PPrrF8V8imNFKhRin+6wObDUBeRGKwe 9leelYAWVRbI2e6c4vbsRw+sNlm+l88CT35d78Sjj70OmROA1alh8nm/sCZRqMWN3WEu z1Ew== X-Gm-Message-State: AHQUAuYYYyWySVNIF7sBb90E7kC9c/7XaUBM+A0VswlfVTlNUAAaRHPw xTatRwg5MFzBLMChW1rGR2AVbg== X-Google-Smtp-Source: AHgI3IbZ/262EZGhquT7lGARjrm3h+XYkktYpdYDShmciY9lKtx3MsUH93uO5sbyxAZvu7NBPJorfA== X-Received: by 2002:a17:906:63c9:: with SMTP id u9mr2752660ejk.190.1549357061114; Tue, 05 Feb 2019 00:57:41 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id x30sm4830141edd.30.2019.02.05.00.57.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Feb 2019 00:57:39 -0800 (PST) Date: Tue, 5 Feb 2019 09:57:37 +0100 From: Daniel Vetter To: Thierry Reding Subject: Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel Message-ID: <20190205085737.GY3271@phenom.ffwll.local> References: <20190203185501.8958-1-anarsoul@gmail.com> <20190203185501.8958-9-anarsoul@gmail.com> <20190204074350.GC16448@ulmo> <20190204082353.GE19087@ulmo> <20190204094012.GP3271@phenom.ffwll.local> <20190204112218.GB10412@ulmo> <20190204155909.GU3271@phenom.ffwll.local> <20190204162258.GB25476@ulmo> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190204162258.GB25476@ulmo> X-Operating-System: Linux phenom 4.19.0-1-amd64 User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190205_005743_246958_1EB66516 X-CRM114-Status: GOOD ( 44.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Archit Taneja , Andrzej Hajda , David Airlie , linux-sunxi , dri-devel , Maxime Ripard , Chen-Yu Tsai , Rob Herring , Sean Paul , Laurent Pinchart , Daniel Vetter , arm-linux , Icenowy Zheng Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 04, 2019 at 05:22:58PM +0100, Thierry Reding wrote: > On Mon, Feb 04, 2019 at 04:59:09PM +0100, Daniel Vetter wrote: > > On Mon, Feb 04, 2019 at 12:22:18PM +0100, Thierry Reding wrote: > > > On Mon, Feb 04, 2019 at 10:40:12AM +0100, Daniel Vetter wrote: > > > > On Mon, Feb 04, 2019 at 09:23:59AM +0100, Thierry Reding wrote: > > > > > On Mon, Feb 04, 2019 at 12:13:55AM -0800, Vasily Khoruzhick wrote: > > > > > > On Sun, Feb 3, 2019 at 11:43 PM Thierry Reding wrote: > > > > > > > > > > > > > > On Sun, Feb 03, 2019 at 10:54:57AM -0800, Vasily Khoruzhick wrote: > > > > > > > > eDP panels usually have EDID EEPROM, so there's no need to define panel > > > > > > > > width/height or any modes/timings in dts. But this panel still may have > > > > > > > > regulator and/or backlight. > > > > > > > > > > > > > > > > Signed-off-by: Vasily Khoruzhick > > > > > > > > --- > > > > > > > > .../devicetree/bindings/display/panel/panel-edp.txt | 7 +++++++ > > > > > > > > 1 file changed, 7 insertions(+) > > > > > > > > create mode 100644 Documentation/devicetree/bindings/display/panel/panel-edp.txt > > > > > > > > > > > > > > Please don't try to make panels look more generic than they really are. > > > > > > > You're going to have to provide a compatible string for your device that > > > > > > > is more specific than "panel-edp". You claim that you don't need any > > > > > > > extra information that is panel specific, but you don't know that now. > > > > > > > We have in the past thought that we didn't need things like prepare > > > > > > > delay, but then we ran into situations where we did need them. > > > > > > > > > > > > > > Just do what everybody else does. Provide a specific compatible string > > > > > > > and match on that in the panel-simple driver. Even if you can read all > > > > > > > the video timings from an EDID EEPROM, you can still provide a mode in > > > > > > > the panel descriptor to serve as a fallback if for example the EEPROM > > > > > > > is faulty on some device. > > > > > > > > > > > > Pinebook used several 768p panels that have slightly different timings > > > > > > and recent batch uses 1080p panel. > > > > > > > > > > > > What panel descriptor should I use as fallback? > > > > > > > > > > You don't use panel descriptors as fallback. The simple-panel driver > > > > > will bind to a panel device and use the corresponding descriptor. If > > > > > your device tree contains the correct information, the descriptor is > > > > > correct for the panel you have. > > > > > > > > > > In other words you need to ensure that you have the correct panel in > > > > > device tree for the board that you're using. This is exactly the same > > > > > thing as for other devices. > > > > > > > > > > One way to to this is to have separate device trees for each variant > > > > > of the board that you want to support. Another variant may be to have > > > > > a common device tree and then have some early firmware update the DTB > > > > > with the correct panel information. > > > > > > > > This would defeat the point of edp, which is to standardize the mess of > > > > panels (at least somewhat) and avoid having to change the DT/ACPI > > > > tables/firmware for every board you ship. Also, we do have DP quirking > > > > infrastructure already (using the OUI), I think if there's something that > > > > doesn't work then we should quirk it there. > > > > > > The problem is that while the attempt may have been to standardize, it > > > failed. It doesn't take into account any of the details such as timing > > > between things like powering up the display and enabling the backlight > > > or similar. I don't know how you'd want to "quirk" those kinds of > > > requirements because they are highly panel specific. > > > > Hm right, we get these from some firmware tables (and mix them with the > > spec one, since some of the firmware values are nonsense). I don't even > > know whether we can read the timings over dp aux somehow (you can power up > > the panel with some pessimistic values to figure those out, and you only > > need dp aux to work, which is much simpler than the entire panel). > > > > > > What does make sense though imo is if we try not to stuff the edp panel > > > > into panel-simple, because it's anything like a simple dumb panel. There's > > > > also some integration awkwardness since with this panel you need to do dp > > > > aux/i2c transactions to get at the information (edid alone isn't good > > > > enough for edp), and I'm not sure how exactly that's supposed to be > > > > instantiated. Maybe a special function to instantiate an edp panel, which > > > > takes both a DT node and the dp_aux controller would be much better, > > > > instead of trying to auto-match against a DT compatible string and load a > > > > panel driver which is almost all fake. > > > > > > > > Or we teach dp_aux to register itself and somehow teach panel-edp how it > > > > can get hold of the dp_aux channel it needs. > > > > > > We already do that. drm_dp_aux registers as an I2C adapter that can be > > > used to read EDID EEPROMs using I2C-over-AUX transactions. We already > > > use that on some platforms. > > > > > > Also note that simple-panel already supports getting video timings from > > > EDID. If a DDC link is present in DT, the driver will load the modes > > > from EDID and use them. > > > > Could we extend this to dp aux somehow? For edp you need the dp aux (which > > then gives you the ddc link automatically). > > I suppose we could do that. We could introduce a new property that would > allow the panel driver to get at the struct drm_dp_aux that can access > the panel. I'm not sure how much that would buy us. I suppose the driver > could go and use that drm_dp_aux to do I2C-over-AUX and ignore any > ddc-bus property in device tree. A drm_dp_aux object could also be used > to access DPCD if that's helpful. > > The driver proposed here doesn't need access to DPCD, so I'm not sure > that would immediately help. You definitely need dp aux to drive edp. That's where a lot of the really important stuff is stored, and it sounds like on non-broken panels even the timings (we've never implemented that on i915 somehow). -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel