Re: [PATCH 4/4] drm/panel: Add Rondo RB070D30 panel

Sam Ravnborg
2019-01-29T15:50:50Z

Hi Maxime.

> > > + }
> > > +
> > > + drm_mode_set_name(mode);
> > > +
> > > + mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
> > > + drm_mode_probed_add(connector, mode);
> > > +
> > > + panel->connector->display_info.bpc = 8;
> > > + panel->connector->display_info.width_mm = 154;
> > > + panel->connector->display_info.height_mm = 85;
> > See comment on height above.
> > Same goes for bpc
>
> Sorry, I'm not sure to follow you here. bpc and height are both set?

I assumed that if we had specified height and width in display_mode
then we did not have to do it here. But I may be wrong.
And for bpc I was plain wrong.

Sam