From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF5D1C282CE for ; Mon, 11 Feb 2019 11:31:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 87D1B214DA for ; Mon, 11 Feb 2019 11:31:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qyRp+3NF"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CuWdPgao" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87D1B214DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=V4zlTrj3P8LjL+GYCKkhw9+9xQjVROkVcA+w/7vbouo=; b=qyRp+3NF2H5KoR Jm5AbDOTaFz44MPlbL5/CWNHkDGIiHwYDX9gLJzaI8YCPCASj31spw4mF1UkHrxVTSBxlhD7I1QBk QxL4//OXahF1F+9axnr35aaBJwQdsqhKXyWJwjbQV7M1DcySuRwcSFBvXT1aQg4zBxqtfGR1q2SLh 1oZdvkftv82ILlh31xmbEZeMolQzzR5ogExgkqW8o3ULlskr0QvIRBTrA60tGlAlpOAG4xnLO7vPB /9+yUixRya5wGjGVu17f8bohErzIbTsxgj3PEURYOW9ut6lW9/6ezzaH+gor1l/8u3QuFK4H6fZi6 O8yO+tlzkwWFrX90BEbA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gt9oM-0006sC-On; Mon, 11 Feb 2019 11:31:42 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gt9oI-0006rQ-IB for linux-arm-kernel@lists.infradead.org; Mon, 11 Feb 2019 11:31:40 +0000 Received: by mail-pf1-x442.google.com with SMTP id n22so2379929pfa.3 for ; Mon, 11 Feb 2019 03:31:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1JEsM2JroaIkgmQdl0RF583/B2IH0sbtfKhWqOtEjUs=; b=CuWdPgao3jxTWpC42B3xsZEZDyFAk2lPD1KD1eLGUXz1wc548X8a22ZQNNAyOUn3qA 30fi/Bu55C3jAfB7dd83OJgWKTQ9y5EDTgtFYgxcMu6PlGKLtu8vT4u477weNfva54dY RfC5ID5AcVPQ2QdQBfY0ADLMQ+cFHlOsbo8qGnsFns07cOQOgYuYwwPsc3Gy8QjCfa1q oGnzM1D7tOKLibD8SLJIemPnHZuwtxJKU9LO+4+blkYA7L8cyN6r5BAX4fDWd08yzfEP CoYT1dyIspgxBp8PRi5jqPuuet9jNvwTgKgOUl+0RaBOrIgDEU9BGnPP03QnZtFEgIqj mNUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1JEsM2JroaIkgmQdl0RF583/B2IH0sbtfKhWqOtEjUs=; b=rMm/M3qqOimBKECnfSYYhGqymYvDeRS99OWiaoMRr8vsN7QvYrmGNcHx84PGihT7E2 /iahPw79eQTZc31P08I0ODhoo8Xey1b620UjqC8tX7rUyXhrpIB1PuUTCWP3SGaZ7R5K 0kheXdt44ndz/M6bJwhdp/kbDvr0GU/Ju4FOEuvu/tAMZRxca8sRR9yFpCGQyw9/nti7 tB+lV+5bgpAdkzlHwRLiLUD+/IcjnTEnSl7dNpMrHd6Jco/8Qd5jVrXXBCeyu4/nNmvX I3evn/URHAQgn3wOKr/vE79sKPHqU0T3r0J28t1SQ6WgUa02RVR+8PPq3yIhh8/+dwvV 5VpA== X-Gm-Message-State: AHQUAuZzNr3CXfGd5hzNY8LYeTlvTGdGe7VMDNeSWFET7tDVsTo6mDAQ UiWpXXHd2b6c6pNtEGEADs0e X-Google-Smtp-Source: AHgI3IZZuo9rgU7o3ot5BBMRbdYb73AQNCudhwnF1oIxRzD93E9ZK/P4t2XDoT8ubAU4REJBl3WKZg== X-Received: by 2002:a65:6242:: with SMTP id q2mr33334510pgv.245.1549884697128; Mon, 11 Feb 2019 03:31:37 -0800 (PST) Received: from mani ([103.59.133.81]) by smtp.gmail.com with ESMTPSA id e21sm48408047pfh.45.2019.02.11.03.31.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Feb 2019 03:31:36 -0800 (PST) Date: Mon, 11 Feb 2019 17:01:28 +0530 From: Manivannan Sadhasivam To: Peter Robinson Subject: Re: [PATCH] arm64: dts: rockchip: Add on-board WiFi/BT support for Rock960 boards Message-ID: <20190211113128.GA22843@mani> References: <20190207055349.27919-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190211_033138_609760_0EC8013D X-CRM114-Status: GOOD ( 22.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: heiko@sntech.de, mani@kernel.org, linux-kernel@vger.kernel.org, dev@vamrs.com, linux-rockchip@lists.infradead.org, ezequiel@collabora.com, linux-arm-kernel@lists.infradead.org, tom@vamrs.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Peter, On Fri, Feb 08, 2019 at 04:45:01PM +0000, Peter Robinson wrote: > Hi Mani, > > On Thu, Feb 7, 2019 at 5:54 AM Manivannan Sadhasivam > wrote: > > > > Add on-board WiFi/BT support for Rock960 boards such as Rock960 based > > on AP6356S and Ficus based on AP6354 wireless modules. > > > > Firmwares for the respective boards are available here: > > > > http://people.linaro.org/~manivannan.sadhasivam/rock960_wifi/ > > http://people.linaro.org/~manivannan.sadhasivam/ficus_wifi/ > > > > Signed-off-by: Manivannan Sadhasivam > > There's some warnings on building these I noticed in testing this on Fedora: > > DTC arch/arm64/boot/dts/rockchip/rk3399-ficus.dtb > arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi:490.3-13: Warning > (reg_format): /dwmmc@fe310000/wifi@1:reg: property has invalid length > (4 bytes) (#address-cells == 2, #size-cells == 1) > arch/arm64/boot/dts/rockchip/rk3399-ficus.dtb: Warning > (pci_device_bus_num): Failed prerequisite 'reg_format' > arch/arm64/boot/dts/rockchip/rk3399-ficus.dtb: Warning (i2c_bus_reg): > Failed prerequisite 'reg_format' > arch/arm64/boot/dts/rockchip/rk3399-ficus.dtb: Warning (spi_bus_reg): > Failed prerequisite 'reg_format' > arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi:488.16-496.4: Warning > (avoid_default_addr_size): /dwmmc@fe310000/wifi@1: Relying on default > #address-cells value > arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi:488.16-496.4: Warning > (avoid_default_addr_size): /dwmmc@fe310000/wifi@1: Relying on default > #size-cells value > > DTC arch/arm64/boot/dts/rockchip/rk3399-rock960.dtb > arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi:490.3-13: Warning > (reg_format): /dwmmc@fe310000/wifi@1:reg: property has invalid length > (4 bytes) (#address-cells == 2, #size-cells == 1) > arch/arm64/boot/dts/rockchip/rk3399-rock960.dtb: Warning > (pci_device_bus_num): Failed prerequisite 'reg_format' > arch/arm64/boot/dts/rockchip/rk3399-rock960.dtb: Warning > (i2c_bus_reg): Failed prerequisite 'reg_format' > arch/arm64/boot/dts/rockchip/rk3399-rock960.dtb: Warning > (spi_bus_reg): Failed prerequisite 'reg_format' > arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi:488.16-496.4: Warning > (avoid_default_addr_size): /dwmmc@fe310000/wifi@1: Relying on default > #address-cells value > arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi:488.16-496.4: Warning > (avoid_default_addr_size): /dwmmc@fe310000/wifi@1: Relying on default > #size-cells value > Hmm. Since the parent node "sdio0" is missing the address/size cells property, the default value has been used by the DTC. I think it would make sense to just drop the reg property from "wifi" node instead of modifying the parent "sdio0" node. If no one has any issue over this, I'll send out another revision with the reg property removed. Thanks, Mani > > --- > > .../boot/dts/rockchip/rk3399-rock960.dtsi | 96 ++++++++++++++++++- > > 1 file changed, 95 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi > > index 56abbb08c133..1b2f7cd82244 100644 > > --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi > > +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi > > @@ -9,6 +9,15 @@ > > #include "rk3399-opp.dtsi" > > > > / { > > + sdio_pwrseq: sdio-pwrseq { > > + compatible = "mmc-pwrseq-simple"; > > + clocks = <&rk808 1>; > > + clock-names = "ext_clock"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&wifi_enable_h>; > > + reset-gpios = <&gpio0 RK_PB2 GPIO_ACTIVE_LOW>; > > + }; > > + > > vcc1v8_s0: vcc1v8-s0 { > > compatible = "regulator-fixed"; > > regulator-name = "vcc1v8_s0"; > > @@ -362,6 +371,20 @@ > > }; > > > > &pinctrl { > > + bt { > > + bt_enable_h: bt-enable-h { > > + rockchip,pins = <0 RK_PB1 RK_FUNC_GPIO &pcfg_pull_none>; > > + }; > > + > > + bt_host_wake_l: bt-host-wake-l { > > + rockchip,pins = <0 RK_PA4 RK_FUNC_GPIO &pcfg_pull_none>; > > + }; > > + > > + bt_wake_l: bt-wake-l { > > + rockchip,pins = <2 RK_PD3 RK_FUNC_GPIO &pcfg_pull_none>; > > + }; > > + }; > > + > > sdmmc { > > sdmmc_bus1: sdmmc-bus1 { > > rockchip,pins = > > @@ -387,6 +410,26 @@ > > }; > > }; > > > > + sdio0 { > > + sdio0_bus4: sdio0-bus4 { > > + rockchip,pins = > > + <2 20 RK_FUNC_1 &pcfg_pull_up_20ma>, > > + <2 21 RK_FUNC_1 &pcfg_pull_up_20ma>, > > + <2 22 RK_FUNC_1 &pcfg_pull_up_20ma>, > > + <2 23 RK_FUNC_1 &pcfg_pull_up_20ma>; > > + }; > > + > > + sdio0_cmd: sdio0-cmd { > > + rockchip,pins = > > + <2 24 RK_FUNC_1 &pcfg_pull_up_20ma>; > > + }; > > + > > + sdio0_clk: sdio0-clk { > > + rockchip,pins = > > + <2 25 RK_FUNC_1 &pcfg_pull_none_20ma>; > > + }; > > + }; > > + > > pmic { > > pmic_int_l: pmic-int-l { > > rockchip,pins = > > @@ -403,6 +446,19 @@ > > <1 14 RK_FUNC_GPIO &pcfg_pull_down>; > > }; > > }; > > + > > + sdio-pwrseq { > > + wifi_enable_h: wifi-enable-h { > > + rockchip,pins = > > + <0 RK_PB2 RK_FUNC_GPIO &pcfg_pull_none>; > > + }; > > + }; > > + > > + wifi { > > + wifi_host_wake_l: wifi-host-wake-l { > > + rockchip,pins = <0 RK_PA3 RK_FUNC_GPIO &pcfg_pull_none>; > > + }; > > + }; > > }; > > > > &pwm2 { > > @@ -413,6 +469,33 @@ > > status = "okay"; > > }; > > > > +&sdio0 { > > + clock-frequency = <50000000>; > > + bus-width = <4>; > > + cap-sdio-irq; > > + cap-sd-highspeed; > > + no-emmc; > > + keep-power-in-suspend; > > + mmc-pwrseq = <&sdio_pwrseq>; > > + non-removable; > > + num-slots = <1>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&sdio0_bus4 &sdio0_cmd &sdio0_clk>; > > + sd-uhs-sdr104; > > + > > + status = "okay"; > > + > > + brcmf: wifi@1 { > > + compatible = "brcm,bcm4329-fmac"; > > + reg = <1>; > > + interrupt-parent = <&gpio0>; > > + interrupts = ; > > + interrupt-names = "host-wake"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&wifi_host_wake_l>; > > + }; > > +}; > > + > > &sdhci { > > bus-width = <8>; > > mmc-hs400-1_8v; > > @@ -439,8 +522,19 @@ > > > > &uart0 { > > pinctrl-names = "default"; > > - pinctrl-0 = <&uart0_xfer &uart0_cts>; > > + pinctrl-0 = <&uart0_xfer &uart0_cts &uart0_rts>; > > status = "okay"; > > + > > + bluetooth { > > + compatible = "brcm,bcm43438-bt"; > > + clocks = <&rk808 1>; > > + clock-names = "ext_clock"; > > + device-wakeup-gpios = <&gpio2 RK_PD3 GPIO_ACTIVE_HIGH>; > > + host-wakeup-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_HIGH>; > > + shutdown-gpios = <&gpio0 RK_PB1 GPIO_ACTIVE_HIGH>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&bt_host_wake_l &bt_wake_l &bt_enable_h>; > > + }; > > }; > > > > &uart2 { > > -- > > 2.17.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel