From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: suzuki.poulose@arm.com, peterz@infradead.org,
linux-kernel@vger.kernel.org, mingo@redhat.com, jolsa@redhat.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] perf tools: Add proper header file for symbols
Date: Mon, 11 Feb 2019 08:46:03 -0300 [thread overview]
Message-ID: <20190211114603.GA3269@kernel.org> (raw)
In-Reply-To: <20190208223543.31836-1-mathieu.poirier@linaro.org>
Em Fri, Feb 08, 2019 at 03:35:43PM -0700, Mathieu Poirier escreveu:
> After 'commit e22c1c751140 ("perf thread: Don't include symbol.h,
> symbol_conf.h is enough")'
>
> Compilation of the perf tools is broken when using the functionality
> provided by the openCSD library:
>
> [...]
>
> ... timerfd: [ on ]
> ... sched_getcpu: [ on ]
> ... sdt: [ OFF ]
> ... setns: [ on ]
> ... libopencsd: [ on ]
>
> [...]
>
> CC util/arm-spe.o
> CC util/arm-spe-pkt-decoder.o
> CC util/s390-cpumsf.o
> CC util/cs-etm.o
> CC util/parse-branch-options.o
> util/cs-etm.c: In function ‘cs_etm__mem_access’:
> util/cs-etm.c:297:24: error: storage size of ‘al’ isn’t known
> struct addr_location al;
>
> And rightly so since file cs-etm.c doesn't include symbol.h, something
> that is rectified in this patch.
Thanks, I'll make sure the openCSD library is present in one of my
containers doing arm64 cross builds so that this gets caught in the
future.
- Arnaldo
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> ---
> tools/perf/util/cs-etm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c
> index 8b3f882d6e2f..0b11d653cfbe 100644
> --- a/tools/perf/util/cs-etm.c
> +++ b/tools/perf/util/cs-etm.c
> @@ -25,6 +25,7 @@
> #include "machine.h"
> #include "map.h"
> #include "perf.h"
> +#include "symbol.h"
> #include "thread.h"
> #include "thread_map.h"
> #include "thread-stack.h"
> --
> 2.17.1
--
- Arnaldo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-11 11:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 22:35 [PATCH] perf tools: Add proper header file for symbols Mathieu Poirier
2019-02-11 11:46 ` Arnaldo Carvalho de Melo [this message]
2019-02-11 14:22 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211114603.GA3269@kernel.org \
--to=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).