Re: [PATCH v3 7/8] drm/sun4i: dsi: Add burst support

Maxime Ripard
2019-02-14T09:44:00Z

[-- Attachment #1.1: Type: text/plain, Size: 2118 bytes --]

On Wed, Feb 13, 2019 at 03:36:48PM +0100, Paul Kocialkowski wrote:
> Hi,
>
> On Mon, 2019-02-11 at 15:41 +0100, Maxime Ripard wrote:
> > From: Konstantin Sudakov <k.sudakov@integrasources.com>
> >
> > The current driver doesn't support the DSI burst operation mode.
> >
> > Let's add the needed quirks to make it work.
> >
> > Signed-off-by: Konstantin Sudakov <k.sudakov@integrasources.com>
> > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> > ---
> > drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 171 ++++++++++++++++++++------
> > 1 file changed, 132 insertions(+), 39 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
> > index e0288e7dc64e..4cb715dc9100 100644
> > --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
> > +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
>
> [...]
>
> > @@ -457,52 +531,71 @@ static void sun6i_dsi_setup_timings(struct sun6i_dsi *dsi,
> > struct mipi_dsi_device *device = dsi->device;
> > unsigned int Bpp = mipi_dsi_pixel_format_to_bpp(device->format) / 8;
> > u16 hbp, hfp, hsa, hblk, vblk;
> > + u32 basic_ctl = 0;
> > size_t bytes;
> > u8 *buffer;
> >
> > /* Do all timing calculations up front to allocate buffer space */
> >
> > - /*
> > - * A sync period is composed of a blanking packet (4 bytes +
> > - * payload + 2 bytes) and a sync event packet (4 bytes). Its
> > - * minimal size is therefore 10 bytes
> > - */
> > + if (device->mode_flags & MIPI_DSI_MODE_VIDEO_BURST) {
> > + hsa = 0;
> > + hbp = 0;
> > + hfp = 0;
> > + hblk = mode->hdisplay * Bpp;
> > + vblk = 0;
>
> It looks a bit strange to zero these variables here while basic_ctl is
> initialized to zero when declared. I think it would be more consistent
> to have these variables set to zero in the same fashion.

You're right, I've fixed this while applying.

> With that fixed:
>
> Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

Thanks!
Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]