From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11623C282C2 for ; Wed, 13 Feb 2019 15:42:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CCC4A222BA for ; Wed, 13 Feb 2019 15:42:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="I+xSEFcr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CCC4A222BA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EhSDBsVr45tOpk/afYPJJjlhhEEy+zpArbg6qdLJvb0=; b=I+xSEFcrUofYKUmPiXPbsPzVo s6C5vmWKX5pVpqtUED9Z5jocPXn0uT6uj7wstOyuSyflOVHRD/T5UR6MlfHUAffHUlI8wyjjpGbdc wG5z/41ykCHsVdu6u39fQS/cO3pK+0zGqWixFESsZyTgWKuYorI89jXS2OP/yEbfKdmXaJ48zYc2b KaAly+saiIFXRqr0rn5ASam82YN8JfeKGX9iCj8XsN1Q9ZUocYPlGD//Lyt7EiPSTyVPAC1BCWIMA L32XSIw9tcbYVZe71YojiS2gMn25/B93SVE7px8ffh6xjnxyQtA5gutOySumci6ETE5u+jfRElTRp +q/M8gcpg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtwfh-0006BE-Jf; Wed, 13 Feb 2019 15:42:01 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtwfd-0006AZ-6Y for linux-arm-kernel@lists.infradead.org; Wed, 13 Feb 2019 15:41:59 +0000 Received: from localhost (aaubervilliers-681-1-89-68.w90-88.abo.wanadoo.fr [90.88.30.68]) (Authenticated sender: maxime.ripard@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 7A2A9240012; Wed, 13 Feb 2019 15:41:45 +0000 (UTC) Date: Wed, 13 Feb 2019 16:41:44 +0100 From: Maxime Ripard To: Robin Murphy Subject: Re: [PATCH v3 5/7] drm/sun4i: Rely on dma interconnect for our RAM offset Message-ID: <20190213154144.5m5qxbfh2qmzwatn@flea> References: <16cb9f67-6b10-fbc3-6222-5364e718721b@arm.com> MIME-Version: 1.0 In-Reply-To: <16cb9f67-6b10-fbc3-6222-5364e718721b@arm.com> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190213_074157_539946_C927EF35 X-CRM114-Status: GOOD ( 24.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Yong Deng , Arnd Bergmann , Daniel Vetter , dri-devel@lists.freedesktop.org, Dave Martin , Paul Kocialkowski , Chen-Yu Tsai , Rob Herring , Thomas Petazzoni , Frank Rowand , Georgi Djakov , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============5579612424860946833==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5579612424860946833== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="d7l7xjpoqu2z746x" Content-Disposition: inline --d7l7xjpoqu2z746x Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Robin, Thanks for your feedback! On Tue, Feb 12, 2019 at 06:46:40PM +0000, Robin Murphy wrote: > On 11/02/2019 15:02, Maxime Ripard wrote: > > Now that we can express our DMA topology, rely on those property instea= d of > > hardcoding an offset from the dma_addr_t which wasn't really great. > >=20 > > We still need to add some code to deal with the old DT that would lack = that > > property, but we move the offset to the DRM device dma_pfn_offset to be > > able to rely on just the dma_addr_t associated to the GEM object. > >=20 > > Acked-by: Daniel Vetter > > Signed-off-by: Maxime Ripard > > --- > > drivers/gpu/drm/sun4i/sun4i_backend.c | 28 +++++++++++++++++++++-----= -- > > 1 file changed, 21 insertions(+), 7 deletions(-) > >=20 > > diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/drm/su= n4i/sun4i_backend.c > > index 9e9255ee59cd..1846a1b30fea 100644 > > --- a/drivers/gpu/drm/sun4i/sun4i_backend.c > > +++ b/drivers/gpu/drm/sun4i/sun4i_backend.c > > @@ -383,13 +383,6 @@ int sun4i_backend_update_layer_buffer(struct sun4i= _backend *backend, > > paddr =3D drm_fb_cma_get_gem_addr(fb, state, 0); > > DRM_DEBUG_DRIVER("Setting buffer address to %pad\n", &paddr); > > - /* > > - * backend DMA accesses DRAM directly, bypassing the system > > - * bus. As such, the address range is different and the buffer > > - * address needs to be corrected. > > - */ > > - paddr -=3D PHYS_OFFSET; > > - > > if (fb->format->is_yuv) > > return sun4i_backend_update_yuv_buffer(backend, fb, paddr); > > @@ -835,6 +828,27 @@ static int sun4i_backend_bind(struct device *dev, = struct device *master, > > dev_set_drvdata(dev, backend); > > spin_lock_init(&backend->frontend_lock); > > + if (of_find_property(dev->of_node, "interconnects", NULL)) { > > + /* > > + * This assume we have the same DMA constraints for all our the > > + * devices in our pipeline (all the backends, but also the > > + * frontends). This sounds bad, but it has always been the case > > + * for us, and DRM doesn't do per-device allocation either, so > > + * we would need to fix DRM first... > > + */ > > + ret =3D of_dma_configure(drm->dev, dev->of_node, true); >=20 > It would be even nicer if we could ensure that drm->dev originates from a= DT > node which has the appropriate interconnects property itself, such that we > can assume it's already configured correctly. The thing is drm->dev comes from a node in the DT that is a virtual node, and therefore doesn't have any resources attached, so I'm not sure we have any other way, unfortunately. Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --d7l7xjpoqu2z746x Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXGQ6uAAKCRDj7w1vZxhR xbcrAQCEh1n4PhkK+dn+4WpQ1biwl3IG6QgA2yRSmoSg9ifHoQD6AtuVsCOMes58 jmZVxAAvWJpuWbVmFvidFiAlLvvQMQw= =TNDy -----END PGP SIGNATURE----- --d7l7xjpoqu2z746x-- --===============5579612424860946833== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5579612424860946833==--