From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8482C43381 for ; Thu, 14 Feb 2019 14:36:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99774222D7 for ; Thu, 14 Feb 2019 14:36:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qbuL+ckH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99774222D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=a61aufKHBc56SkEzvCfmquotr/3hgtyx7lUOfLO2q8M=; b=qbuL+ckHMBOgvg QvVs3zVaki0ZTdINgbHDgIkNFDduLBdSp8K1FKaPRCNNPjN5ksY8Rse9VIENtBfBjE6yKKVdZlnvV DOyNQAMVRww0cAyWKJxcn445ERNke83ihDGWtulyTKhU0bdMFiSn60QzJctF6X69h+NFXiK41T5o7 mgkapUAWaZo56RciuZB5fZ3hlPgXbKOXHzexeHRLRbSPCP7/4Ye+/zp9OViCBJCmQthEj58LSAmAF tPlJVvF3wT856HChm7Z9F2gsPlc2vmbdUC5I63WgQZ/DkxdTtxY3UH9ELSxQFiEC8Ro8Spp4FrN4J KzJAnAiYH0bTu9Wh9A+g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1guI7V-0006Zz-EW; Thu, 14 Feb 2019 14:36:09 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1guI7R-0006Yl-Lq for linux-arm-kernel@lists.infradead.org; Thu, 14 Feb 2019 14:36:07 +0000 Received: from localhost (aaubervilliers-681-1-89-68.w90-88.abo.wanadoo.fr [90.88.30.68]) (Authenticated sender: maxime.ripard@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 182E8240005; Thu, 14 Feb 2019 14:35:55 +0000 (UTC) Date: Thu, 14 Feb 2019 15:35:55 +0100 From: Maxime Ripard To: Frank Lee Subject: Re: [PATCH 1/4] arm64: dts: allwinner: h6: orangepi: Add CPU supply regulator Message-ID: <20190214143555.4jago2wp4vojz7rk@flea> References: <20190214130910.9201-1-tiny.windzz@gmail.com> <20190214130910.9201-2-tiny.windzz@gmail.com> <20190214134617.b44pa7onf3brmhhj@flea> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190214_063605_858756_7AC9D902 X-CRM114-Status: GOOD ( 19.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, Linux Kernel Mailing List , Chen-Yu Tsai , robh+dt@kernel.org, Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Thu, Feb 14, 2019 at 10:07:02PM +0800, Frank Lee wrote: > On Thu, Feb 14, 2019 at 9:46 PM Maxime Ripard wrote: > > Thanks for your patches > > > > On Thu, Feb 14, 2019 at 08:09:07AM -0500, Yangtao Li wrote: > > > The original orangepi use the dcdca to supply the CPU cores. According > > > to the axp805 spec, the range of dcdca is 0.6 to 1.1v, 1.12 to 1.52v. > > > In order to support more CPU frequency, slightly increase the voltage > > > maximum and minimum. > > > > > > Signed-off-by: Yangtao Li > > > --- > > > arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi | 8 ++++++-- > > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi > > > index b2526dac2fcf..e7aebaf91ede 100644 > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi > > > @@ -159,8 +159,8 @@ > > > > > > reg_dcdca: dcdca { > > > regulator-always-on; > > > - regulator-min-microvolt = <810000>; > > > - regulator-max-microvolt = <1080000>; > > > + regulator-min-microvolt = <800000>; > > > + regulator-max-microvolt = <1160000>; > > > > This violates the minimum and maximum recommended voltages in the H6 > > datasheet. Could you clarify why you are doing so (ideally in the > > commit log)? > > In fact, in sunxi's sdk, the actual minimum and maximum voltage of the > cpu is smaller or larger than the datasheet. > > For some better quality ic, the minimum voltage can be smaller. > For some poor quality ic, the maximum voltage needs to be increased a little. Ok, that should definitely be part of the commit log then :) Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel