From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9FAAC43381 for ; Thu, 14 Feb 2019 20:48:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 88DFD21B68 for ; Thu, 14 Feb 2019 20:48:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OdaXZFD4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=poorly.run header.i=@poorly.run header.b="QWlKv6+f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88DFD21B68 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=poorly.run Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pebiSF5SaJaTg495WL38EOGYqGxtQmfSNZuFJ66tDTY=; b=OdaXZFD4D2dLnH PZq/pc1XkfHjcHsqHhrnjBZTRoTVyPnSRBpYEEt3G+KACheUwZ3KHOPoNEW/kDfiULUi9TfCZ5eBZ LBBE1k5/Hlt/ilfUpZNW76++bImfCcOzv38JTI3NHgVgIFP1cThy7nze1IJ0rJ5SOBkEFQ5SFpIer sFnMWPVsaGaAN7qFzl7VDGssk7/bqWxl90aCem9OAb500Wp+Pw8Evvono+J+4DE7oEjr3vmIeNhy9 rN6R/E6Q845bOgYD8bdOybu/ekhGHePSE2BwLR6eCO5Ifws3KBvbkmmCqMgoCXVBlUmrts6oW8Udp cmq2DNJN6RYTZCAL9xUw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1guNvn-0007B5-RA; Thu, 14 Feb 2019 20:48:27 +0000 Received: from mail-qt1-x844.google.com ([2607:f8b0:4864:20::844]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1guNvj-0007A1-UH for linux-arm-kernel@lists.infradead.org; Thu, 14 Feb 2019 20:48:25 +0000 Received: by mail-qt1-x844.google.com with SMTP id n32so8454374qte.11 for ; Thu, 14 Feb 2019 12:48:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=poorly.run; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=GneO+662dvgEVfHBE4flzPB1dAILormUzzmyDMsEYyU=; b=QWlKv6+fUmSJeFFYEzNRW5NhgclPr5wskbK3IIzM1FQ0gnJAxZCel2NVUqZ1VZgC1w ir0QXanpcBaHEk1J+P4J5AZvP7tG0DxvMykAC17sxGbI/huFHiX0GCSkS/o0YlIlmQfQ u5+Wb5wm0g85Ll+6XJeJpInp8E4/DkHmUR/hhB5wiiXlCWuEcMVNXJDFgitq2HZ7h9Le gg/4Bmb7H1qALWnybnhIQft2+gE/kTXD5Ac5nNTqXfUJ/o7WrXPR2FYTFagNgXwXNRNY 8k01i4+4XM9WNlXCm1NPuBMqHtYPnI1IzDgEVoF9igtt2r3gSY1fojOfjJ+bt9W96Ufl m4Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=GneO+662dvgEVfHBE4flzPB1dAILormUzzmyDMsEYyU=; b=m+JfE353IXTNrM1JJpEVqnUfNDmmKjD5jOjkZjAXqPNitO6YhXikGMuPdNcUnVq4+8 D6ayHc1FyHEJqlWY8HelpgKSGxU1VQURw2IaKHvLxeof1QQaAmN2j11AwJdKutPTw5Ie sGzeIl588hYDS0mUbOGDYJG5+cgWXPsoO6EDA1Obyw7BEhPrH+YkjBbCgvznj2x5BUYZ PAkA2I6k0XkshVSrfos7eP+3tDnlsnN/kTfRXBS3vgw9LZl6hkdfMMXwmBj5QU7MMgHe 8T5a3gFptu/P+Znv43jweSSifNh7pcTX7diDrdM+Xw4mr5a96LpCCdjLF+y2E3JysUGj uHhw== X-Gm-Message-State: AHQUAubmRuL4wzwrW/syQ8mq5xKDPnnFUx2nqS50wBzBaX1EuIFZYF/i QUHOdzUvGqmL0kERDtBeo5YySw== X-Google-Smtp-Source: AHgI3IYAktSAVcy0WAZehwS5gnft0O1Zek9k3dgnK2EMjWqP6Z/b3AlExS2AN649A8lcU/s1ao/+cQ== X-Received: by 2002:aed:3f05:: with SMTP id p5mr4791939qtf.114.1550177302625; Thu, 14 Feb 2019 12:48:22 -0800 (PST) Received: from localhost ([2620:0:1013:11:89c6:2139:5435:371d]) by smtp.gmail.com with ESMTPSA id p127sm1587057qke.97.2019.02.14.12.48.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Feb 2019 12:48:22 -0800 (PST) Date: Thu, 14 Feb 2019 15:48:21 -0500 From: Sean Paul To: Jitao Shi Subject: Re: [PATCH 1/3] drm/mediatek: move mipi_dsi_host_register to probe Message-ID: <20190214204821.GP114153@art_vandelay> References: <20190214044243.129920-1-jitao.shi@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190214044243.129920-1-jitao.shi@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190214_124824_051991_ACDC0488 X-CRM114-Status: GOOD ( 21.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , stonea168@163.com, dri-devel@lists.freedesktop.org, Ajay Kumar , drinkcat@chromium.org, Vincent Palatin , linux-mediatek@lists.infradead.org, cawa.cheng@mediatek.com, bibby.hsieh@mediatek.com, ck.hu@mediatek.com, Russell King , Thierry Reding , linux-pwm@vger.kernel.org, Sascha Hauer , Pawel Moll , Ian Campbell , Inki Dae , Rob Herring , Sean Paul , yingjoe.chen@mediatek.com, Matthias Brugger , eddie.huang@mediatek.com, linux-arm-kernel@lists.infradead.org, Rahul Sharma , srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org, Philipp Zabel , Kumar Gala , Andy Yan Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 14, 2019 at 12:42:41PM +0800, Jitao Shi wrote: > DSI panel driver need attach function which is inculde in > mipi_dsi_host_ops. Which function is required from dsi_host? Sean > > If mipi_dsi_host_register is not in probe, dsi panel will > probe fail or more delay. > > So move the mipi_dsi_host_register to probe from bind. > > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 49 ++++++++++++++++++------------ > 1 file changed, 30 insertions(+), 19 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > index 27b507eb4a99..93fa255b4aad 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -1045,12 +1045,6 @@ static int mtk_dsi_bind(struct device *dev, struct device *master, void *data) > return ret; > } > > - ret = mipi_dsi_host_register(&dsi->host); > - if (ret < 0) { > - dev_err(dev, "failed to register DSI host: %d\n", ret); > - goto err_ddp_comp_unregister; > - } > - > ret = mtk_dsi_create_conn_enc(drm, dsi); > if (ret) { > DRM_ERROR("Encoder create failed with %d\n", ret); > @@ -1060,8 +1054,6 @@ static int mtk_dsi_bind(struct device *dev, struct device *master, void *data) > return 0; > > err_unregister: > - mipi_dsi_host_unregister(&dsi->host); > -err_ddp_comp_unregister: > mtk_ddp_comp_unregister(drm, &dsi->ddp_comp); > return ret; > } > @@ -1097,31 +1089,37 @@ static int mtk_dsi_probe(struct platform_device *pdev) > > dsi->host.ops = &mtk_dsi_ops; > dsi->host.dev = dev; > + dsi->dev = dev; > + ret = mipi_dsi_host_register(&dsi->host); > + if (ret < 0) { > + dev_err(dev, "failed to register DSI host: %d\n", ret); > + return -EPROBE_DEFER; > + } > > ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, > &dsi->panel, &dsi->bridge); > if (ret) > - return ret; > + goto err_unregister_host; > > dsi->engine_clk = devm_clk_get(dev, "engine"); > if (IS_ERR(dsi->engine_clk)) { > ret = PTR_ERR(dsi->engine_clk); > dev_err(dev, "Failed to get engine clock: %d\n", ret); > - return ret; > + goto err_unregister_host; > } > > dsi->digital_clk = devm_clk_get(dev, "digital"); > if (IS_ERR(dsi->digital_clk)) { > ret = PTR_ERR(dsi->digital_clk); > dev_err(dev, "Failed to get digital clock: %d\n", ret); > - return ret; > + goto err_unregister_host; > } > > dsi->hs_clk = devm_clk_get(dev, "hs"); > if (IS_ERR(dsi->hs_clk)) { > ret = PTR_ERR(dsi->hs_clk); > dev_err(dev, "Failed to get hs clock: %d\n", ret); > - return ret; > + goto err_unregister_host; > } > > regs = platform_get_resource(pdev, IORESOURCE_MEM, 0); > @@ -1129,33 +1127,35 @@ static int mtk_dsi_probe(struct platform_device *pdev) > if (IS_ERR(dsi->regs)) { > ret = PTR_ERR(dsi->regs); > dev_err(dev, "Failed to ioremap memory: %d\n", ret); > - return ret; > + goto err_unregister_host; > } > > dsi->phy = devm_phy_get(dev, "dphy"); > if (IS_ERR(dsi->phy)) { > ret = PTR_ERR(dsi->phy); > dev_err(dev, "Failed to get MIPI-DPHY: %d\n", ret); > - return ret; > + goto err_unregister_host; > } > > comp_id = mtk_ddp_comp_get_id(dev->of_node, MTK_DSI); > if (comp_id < 0) { > dev_err(dev, "Failed to identify by alias: %d\n", comp_id); > - return comp_id; > + ret = comp_id; > + goto err_unregister_host; > } > > ret = mtk_ddp_comp_init(dev, dev->of_node, &dsi->ddp_comp, comp_id, > &mtk_dsi_funcs); > if (ret) { > dev_err(dev, "Failed to initialize component: %d\n", ret); > - return ret; > + goto err_unregister_host; > } > > irq_num = platform_get_irq(pdev, 0); > if (irq_num < 0) { > dev_err(&pdev->dev, "failed to request dsi irq resource\n"); > - return -EPROBE_DEFER; > + ret = -EPROBE_DEFER; > + goto err_unregister_host; > } > > irq_set_status_flags(irq_num, IRQ_TYPE_LEVEL_LOW); > @@ -1163,14 +1163,25 @@ static int mtk_dsi_probe(struct platform_device *pdev) > IRQF_TRIGGER_LOW, dev_name(&pdev->dev), dsi); > if (ret) { > dev_err(&pdev->dev, "failed to request mediatek dsi irq\n"); > - return -EPROBE_DEFER; > + ret = -EPROBE_DEFER; > + goto err_unregister_host; > } > > init_waitqueue_head(&dsi->irq_wait_queue); > > platform_set_drvdata(pdev, dsi); > > - return component_add(&pdev->dev, &mtk_dsi_component_ops); > + ret = component_add(&pdev->dev, &mtk_dsi_component_ops); > + if (ret) { > + ret = -EPROBE_DEFER; > + goto err_unregister_host; > + } > + > + return 0; > + > +err_unregister_host: > + mipi_dsi_host_unregister(&dsi->host); > + return ret; > } > > static int mtk_dsi_remove(struct platform_device *pdev) > -- > 2.20.1 > -- Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel