From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>,
netdev@vger.kernel.org, linux-can@vger.kernel.org,
Ludovic.Desroches@microchip.com, mkl@pengutronix.de,
linux-arm-kernel@lists.infradead.org, davem@davemloft.net,
wg@grandegger.com
Subject: Re: [PATCH] can: mark expected switch fall-throughs
Date: Fri, 15 Feb 2019 00:21:22 +0100 [thread overview]
Message-ID: <20190214232122.GS10129@piout.net> (raw)
In-Reply-To: <c597ac66-e79d-50e4-6906-923bd18834e9@embeddedor.com>
On 14/02/2019 17:14:05-0600, Gustavo A. R. Silva wrote:
> >>> Also, the gcc documentation says that -Wimplicit-fallthrough=3
> >>> recognizes /* fallthrough */ as a proper fall through comment (and I
> >>> tested with gcc 8.2).
> >>>
> >>
> >> Yeah. But that's not the relevant change in this case. Notice that the
> >> comment was moved to the very bottom of the previous case.
> >>
> >
> > Yes and it doesn't matter for gcc, I tested with gcc 8.2.
> >
>
> Yeah. But, again, you are missing the relevant part of the patch.
>
Right, I misread the patch and though you were moving the comment after
the case statement.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-14 23:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 18:06 [PATCH] can: mark expected switch fall-throughs Gustavo A. R. Silva
2019-01-30 8:11 ` Nicolas.Ferre
2019-02-14 21:37 ` Gustavo A. R. Silva
2019-02-14 22:17 ` Alexandre Belloni
2019-02-14 23:04 ` Gustavo A. R. Silva
2019-02-14 23:07 ` Alexandre Belloni
2019-02-14 23:14 ` Gustavo A. R. Silva
2019-02-14 23:21 ` Alexandre Belloni [this message]
2019-02-19 2:57 ` Gustavo A. R. Silva
2019-02-26 8:02 ` Marc Kleine-Budde
2019-02-26 15:24 ` Gustavo A. R. Silva
2019-05-08 17:30 ` Gustavo A. R. Silva
2019-05-21 19:06 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214232122.GS10129@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=davem@davemloft.net \
--cc=gustavo@embeddedor.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).