From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 248FEC43381 for ; Fri, 15 Feb 2019 13:35:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA64B21925 for ; Fri, 15 Feb 2019 13:35:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZPhL36DY"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="d9PtjzjV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA64B21925 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=l5T8y9lvNOgSkruFL32w8qpXhYO+DILtISt/7lfVgvE=; b=ZPhL36DYn8SwmI S28rNVtq7NwXjD7ILWntuiHWW2lxAfOhziqTqYfH/OAlsoCMSRatSedJ0A66D0H/SF9d2JobUNNFp Y6fUeb63cHDT44gANVS4kG31fcVqzD8U1nD/IRE4jJhuvS/fKM4NSekmqrKKqiY0CgrPjN7nsVVlZ EbkVQ3NKrLntXCdB+u7WK3WAnQ7XeaQBxMtRIQLtZIsVe7BebZK6VHmxoH6hQg6e37LUWRSux6zBC 9wLP0vfYassnbBEDOKyfycePDK/dbs7B8Xvt95ytf0Y+Tg6V6FVDgMtRr5X5gT0w1xvfiIT9ADDai /1PEStxUXm0OJs704OHw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gude0-0006mV-1E; Fri, 15 Feb 2019 13:35:08 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1guddw-00061y-Hl for linux-arm-kernel@lists.infradead.org; Fri, 15 Feb 2019 13:35:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=sae7oI0BakmA1YYtB52K/s24aAoF9FG6Hk2jAt8wpiw=; b=d9PtjzjVgLlBZikcGn6EOet4oT ras8mlPdntQ4UIz5AzE7m0zsC/rJrOk3lHGaKLrzqDVvC/D7mNpo7uZaPwpjPstICpTTyeaB6fPY4 z+4wsSftF7BrnSO2q6fseMfUqBRemX/2HxdPn3Y0c46b20MwY5IMIJhJZe/B4DQO+wWc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1guddr-00055W-Q5; Fri, 15 Feb 2019 14:34:59 +0100 Date: Fri, 15 Feb 2019 14:34:59 +0100 From: Andrew Lunn To: Claudiu Manoil Subject: Re: [PATCH net-next v2 3/3] enetc: Add ENETC PF level external MDIO support Message-ID: <20190215133459.GH5699@lunn.ch> References: <1550225414-12125-1-git-send-email-claudiu.manoil@nxp.com> <1550225414-12125-4-git-send-email-claudiu.manoil@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1550225414-12125-4-git-send-email-claudiu.manoil@nxp.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190215_053504_767239_786EA6FB X-CRM114-Status: GOOD ( 11.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, netdev@vger.kernel.org, alexandru.marginean@nxp.com, linux-kernel@vger.kernel.org, Li Yang , Shawn Guo , "David S . Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 15, 2019 at 12:10:14PM +0200, Claudiu Manoil wrote: > Each ENETC PF has its own MDIO interface, the corresponding > MDIO registers are mapped in the ENETC's Port register block. > The current patch adds a driver for these PF level MDIO buses, > so that each PF can manage directly its own external link. > > Signed-off-by: Alex Marginean > Signed-off-by: Claudiu Manoil > --- > v2 - used readx_poll_timeout() > - added mdio node child to the port node Hi Claudiu Please document this in the device tree binding. > + /* return all Fs if nothing was there */ > + if (enetc_rd_reg(®s->mdio_cfg) & MDIO_CFG_RD_ER) { > + dev_err(&bus->dev, > + "Error while reading PHY%d reg at %d.%hhu\n", > + phy_id, dev_addr, regnum); > + return 0xffff; I'm not sure you want a dev_err() here. The device tree binding allows you to have a phy node without a reg value. When that happens, the core code will scan all 32 addresses to find the PHY. This is going to spam the log. dev_dbg() might be better. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel