From: Eric Biggers <ebiggers@kernel.org>
To: Christoph Manszewski <c.manszewski@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Vladimir Zapolskiy <vz@mleia.com>,
Kamil Konieczny <k.konieczny@partner.samsung.com>,
linux-samsung-soc@vger.kernel.org
Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: [Bug] s5p-sss crypto driver doesn't set next AES-CBC IV
Date: Fri, 15 Feb 2019 10:51:00 -0800 [thread overview]
Message-ID: <20190215185058.GB12909@gmail.com> (raw)
Hello,
The AES-CBC implementation in the s5p-sss crypto driver is failing the improved
crypto self-tests I currently have out for review. The improved tests check
that all CBC implementations update the IV buffer to be the last ciphertext
block. This has always been required so that requests can be chained, but
unfortunately it wasn't tested for by the self-tests until now.
See the boot logs for Exynos platforms from the KernelCI job here:
https://kernelci.org/boot/all/job/ardb/branch/for-kernelci/kernel/v5.0-rc1-149-g64c945c018af/
alg: skcipher: cbc-aes-s5p encryption test failed (wrong output IV) on test vector 0, cfg=\"in-place\"
00000000: 3d af ba 42 9d 9e b4 30 b4 22 da 80 2c 9f ac 41
You can reproduce by pulling from
https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git
branch "iv-out-testing", unsetting CONFIG_CRYPTO_MANAGER_DISABLE_TESTS,
setting CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y, rebooting and checking dmesg.
(CRYPTO_MANAGER_EXTRA_TESTS is probably unneeded for this, but you might as well
use it. Also you can optionally revert the last patch, which makes crypto
self-test failures cause a kernel panic for testing purposes. It's possible
that ctr-aes-s5p is failing too but it was just never gotten to...)
The patch series is also available on the linux-crypto mailing list:
https://patchwork.kernel.org/cover/10811951/
Note that I don't have this hardware myself, so if it turns out that no one is
interested in fixing this anytime soon I'll instead have to propose disabling
these algorithm(s) until they can be fixed.
Thanks,
- Eric
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2019-02-15 18:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190215185148epcas3p23960bfe37c629ebb2103e673509949f4@epcas3p2.samsung.com>
2019-02-15 18:51 ` Eric Biggers [this message]
2019-02-16 9:52 ` [Bug] s5p-sss crypto driver doesn't set next AES-CBC IV Krzysztof Kozlowski
2019-02-19 9:58 ` Kamil Konieczny
2019-02-19 10:11 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190215185058.GB12909@gmail.com \
--to=ebiggers@kernel.org \
--cc=c.manszewski@samsung.com \
--cc=k.konieczny@partner.samsung.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).