From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29A7CC43381 for ; Mon, 18 Feb 2019 08:49:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F015D2089F for ; Mon, 18 Feb 2019 08:49:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fZrh7VSJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F015D2089F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pXASJ3xV1CxrW0F0EYffms089brHDjB9tXsFYrZMb1M=; b=fZrh7VSJbwIX5q5lH8Ypqy3ZK gp99UhVfP9DczaIFHrFS5cXzKBK+BXGH15umXoB9RySBchDPe3epv/dq4rLr6c0kSFaxDLoJVwUEq XMKaZrBvVzWJjdMrmLrFn7Ke/DbaUXENg1bRAOd++DJGGKDLr3ugy8NJz2Lz/6AmBRP6UCZVgBfHT g9d5uIW9CDsmxOszFPxAxl3iexw15FtT8NB7DPmfF+D9Hwto3X+PMF8zTZRFciWoF7eg+xOzwC1bQ t2lmOU+ud4zOc31Vn8hvdIwUOyIaBK8dRMsEA1HWM0nmcFqIxBk0Z6azw6+c24Qp1GZHlOcV8AHci 4fMoC/8lg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gvecV-0006uV-Ou; Mon, 18 Feb 2019 08:49:47 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gvecR-0006u4-Rd for linux-arm-kernel@lists.infradead.org; Mon, 18 Feb 2019 08:49:45 +0000 X-Originating-IP: 90.88.30.68 Received: from localhost (aaubervilliers-681-1-89-68.w90-88.abo.wanadoo.fr [90.88.30.68]) (Authenticated sender: maxime.ripard@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id F0A84E0009; Mon, 18 Feb 2019 08:49:31 +0000 (UTC) Date: Mon, 18 Feb 2019 09:49:31 +0100 From: Maxime Ripard To: Yangtao Li Subject: Re: [PATCH 2/5] nvmem: sunxi-sid: add support for H5's SID controller Message-ID: <20190218084931.fdut6d4cgwkwvihx@flea> References: <20190217162316.14111-1-tiny.windzz@gmail.com> <20190217162316.14111-3-tiny.windzz@gmail.com> MIME-Version: 1.0 In-Reply-To: <20190217162316.14111-3-tiny.windzz@gmail.com> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190218_004944_039316_933D8883 X-CRM114-Status: GOOD ( 14.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, wens@csie.org, robh+dt@kernel.org, srinivas.kandagatla@linaro.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============2075985724198844044==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2075985724198844044== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="scnr26aml4g7phhd" Content-Disposition: inline --scnr26aml4g7phhd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 17, 2019 at 11:23:13AM -0500, Yangtao Li wrote: > Add support for H5's SID controller. >=20 > Signed-off-by: Yangtao Li > --- > drivers/nvmem/sunxi_sid.c | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/drivers/nvmem/sunxi_sid.c b/drivers/nvmem/sunxi_sid.c > index 570a2e354f30..036029e90921 100644 > --- a/drivers/nvmem/sunxi_sid.c > +++ b/drivers/nvmem/sunxi_sid.c > @@ -219,11 +219,17 @@ static const struct sunxi_sid_cfg sun50i_a64_cfg = =3D { > .size =3D 0x100, > }; > =20 > +static const struct sunxi_sid_cfg sun50i_h5_cfg =3D { > + .value_offset =3D 0x200, > + .size =3D 0x100, > +}; IIRC, there was an endianness issue on the newer SoCs, with the driver converting the data from big endian to little endian, while it's actually stored little endian in the SID. Have you checked the SID content? Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --scnr26aml4g7phhd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXGpxmwAKCRDj7w1vZxhR xXx7AQDcwq0iKz7NwrOgeLiQJtBdc0cgjMZh9PBcdpG0bCWIBwD7BwtI5UEDPuB5 GNkfU1d6DR0iUKSDPFYUTL3dTKlK0QU= =Okil -----END PGP SIGNATURE----- --scnr26aml4g7phhd-- --===============2075985724198844044== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2075985724198844044==--