* [PATCH v2 09/15] dt-bindings: serial: Add Milbeaut serial driver description
@ 2019-02-08 12:27 Sugaya Taichi
2019-02-18 19:57 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Sugaya Taichi @ 2019-02-08 12:27 UTC (permalink / raw)
To: linux-serial, devicetree, linux-arm-kernel, linux-kernel
Cc: Mark Rutland, Shinji Kanematsu, Masami Hiramatsu, Sugaya Taichi,
Greg Kroah-Hartman, Jassi Brar, Rob Herring, Takao Orito,
Kazuhiro Kasai
Add DT bindings document for Milbeaut serial driver.
Signed-off-by: Sugaya Taichi <sugaya.taichi@socionext.com>
---
.../devicetree/bindings/serial/milbeaut-uart.txt | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
create mode 100644 Documentation/devicetree/bindings/serial/milbeaut-uart.txt
diff --git a/Documentation/devicetree/bindings/serial/milbeaut-uart.txt b/Documentation/devicetree/bindings/serial/milbeaut-uart.txt
new file mode 100644
index 0000000..8f61c38
--- /dev/null
+++ b/Documentation/devicetree/bindings/serial/milbeaut-uart.txt
@@ -0,0 +1,21 @@
+Socionext Milbeaut UART controller
+
+Required properties:
+- compatible: should be "socionext,milbeaut-usio-uart".
+- reg: offset and length of the register set for the device.
+- interrupts: two interrupts specifier.
+- clocks: phandle to the input clock.
+- interrupt-names: should be "rx", "tx".
+
+Optional properties:
+- uart-flow-enable: flow control enable.
+
+Example:
+ usio1: usio_uart@1e700010 {
+ compatible = "socionext,milbeaut-usio-uart";
+ reg = <0x1e700010 0x10>;
+ interrupts = <0 141 0x4>, <0 149 0x4>;
+ interrupt-names = "rx", "tx";
+ clocks = <&clk 2>;
+ uart-flow-enable;
+ };
--
1.9.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2 09/15] dt-bindings: serial: Add Milbeaut serial driver description
2019-02-08 12:27 [PATCH v2 09/15] dt-bindings: serial: Add Milbeaut serial driver description Sugaya Taichi
@ 2019-02-18 19:57 ` Rob Herring
2019-02-19 8:11 ` Sugaya, Taichi
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2019-02-18 19:57 UTC (permalink / raw)
To: Sugaya Taichi
Cc: Mark Rutland, devicetree, Masami Hiramatsu, Shinji Kanematsu,
Greg Kroah-Hartman, linux-kernel, Jassi Brar, linux-serial,
Takao Orito, Kazuhiro Kasai, linux-arm-kernel
On Fri, Feb 08, 2019 at 09:27:29PM +0900, Sugaya Taichi wrote:
> Add DT bindings document for Milbeaut serial driver.
>
> Signed-off-by: Sugaya Taichi <sugaya.taichi@socionext.com>
> ---
> .../devicetree/bindings/serial/milbeaut-uart.txt | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/serial/milbeaut-uart.txt
>
> diff --git a/Documentation/devicetree/bindings/serial/milbeaut-uart.txt b/Documentation/devicetree/bindings/serial/milbeaut-uart.txt
> new file mode 100644
> index 0000000..8f61c38
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/serial/milbeaut-uart.txt
> @@ -0,0 +1,21 @@
> +Socionext Milbeaut UART controller
> +
> +Required properties:
> +- compatible: should be "socionext,milbeaut-usio-uart".
> +- reg: offset and length of the register set for the device.
> +- interrupts: two interrupts specifier.
> +- clocks: phandle to the input clock.
> +- interrupt-names: should be "rx", "tx".
Put this next to 'interrupts'
> +
> +Optional properties:
> +- uart-flow-enable: flow control enable.
We already have a standard property for this: auto-flow-control
> +
> +Example:
> + usio1: usio_uart@1e700010 {
serial@...
> + compatible = "socionext,milbeaut-usio-uart";
> + reg = <0x1e700010 0x10>;
> + interrupts = <0 141 0x4>, <0 149 0x4>;
> + interrupt-names = "rx", "tx";
> + clocks = <&clk 2>;
> + uart-flow-enable;
> + };
> --
> 1.9.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2 09/15] dt-bindings: serial: Add Milbeaut serial driver description
2019-02-18 19:57 ` Rob Herring
@ 2019-02-19 8:11 ` Sugaya, Taichi
0 siblings, 0 replies; 3+ messages in thread
From: Sugaya, Taichi @ 2019-02-19 8:11 UTC (permalink / raw)
To: Rob Herring
Cc: Mark Rutland, devicetree, Masami Hiramatsu, Shinji Kanematsu,
Greg Kroah-Hartman, linux-kernel, Jassi Brar, linux-serial,
Takao Orito, Kazuhiro Kasai, linux-arm-kernel
Hi,
On 2019/02/19 4:57, Rob Herring wrote:
> On Fri, Feb 08, 2019 at 09:27:29PM +0900, Sugaya Taichi wrote:
>> Add DT bindings document for Milbeaut serial driver.
>>
>> Signed-off-by: Sugaya Taichi <sugaya.taichi@socionext.com>
>> ---
>> .../devicetree/bindings/serial/milbeaut-uart.txt | 21 +++++++++++++++++++++
>> 1 file changed, 21 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/serial/milbeaut-uart.txt
>>
>> diff --git a/Documentation/devicetree/bindings/serial/milbeaut-uart.txt b/Documentation/devicetree/bindings/serial/milbeaut-uart.txt
>> new file mode 100644
>> index 0000000..8f61c38
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/serial/milbeaut-uart.txt
>> @@ -0,0 +1,21 @@
>> +Socionext Milbeaut UART controller
>> +
>> +Required properties:
>> +- compatible: should be "socionext,milbeaut-usio-uart".
>> +- reg: offset and length of the register set for the device.
>> +- interrupts: two interrupts specifier.
>> +- clocks: phandle to the input clock.
>> +- interrupt-names: should be "rx", "tx".
>
> Put this next to 'interrupts'
>
OK, change the order.
>> +
>> +Optional properties:
>> +- uart-flow-enable: flow control enable.
>
> We already have a standard property for this: auto-flow-control
>
Okay, I change the property name to "auto-flow-control"
>> +
>> +Example:
>> + usio1: usio_uart@1e700010 {
>
> serial@...
>
I got it.
Thanks,
Sugaya Taichi
>> + compatible = "socionext,milbeaut-usio-uart";
>> + reg = <0x1e700010 0x10>;
>> + interrupts = <0 141 0x4>, <0 149 0x4>;
>> + interrupt-names = "rx", "tx";
>> + clocks = <&clk 2>;
>> + uart-flow-enable;
>> + };
>> --
>> 1.9.1
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-19 8:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-08 12:27 [PATCH v2 09/15] dt-bindings: serial: Add Milbeaut serial driver description Sugaya Taichi
2019-02-18 19:57 ` Rob Herring
2019-02-19 8:11 ` Sugaya, Taichi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox